refactoring: naming and typos in code

[zielint0]

There are many typos / errors / misspellings that

• harm readability
• decrease maintainability

I hope there are no obstacles to fix them (API compatibility?)

• refactor: occurences -> occurrences refactor: fix naming occurences (re-introduced) #2214

• refactor: fix naming: RECURSIVE_WILCARD -> RECURSIVE_WILDCARD refactor: fix naming: RECURSIVE_WILCARD -> RECURSIVE_WILDCARD (re-introduced) #2213

• CtRole.java: ANNONYMOUS_EXECUTABLE -> ANONYMOUS_EXECUTABLE

• src/main/java/spoon/reflect/meta/impl/ModelRoleHandlers.java: CtClass_ANNONYMOUS_EXECUTABLE_RoleHandler -> CtClass_ANONYMOUS_EXECUTABLE_RoleHandler

• refactor: fix typo in element printer helper.java QALIFIED_NAME_SEPARATORS -> QUALIFIED_NAME_SEPARATORS refactor: fix typo in element printer helper.java #2223

• fix typo: Occurence->Occurrence fix typo: Occurence->Occurrence (important for consistency, see previous changes!) #2249

• refactor: fix some typos refactor: fix some typos #2253

I would like to go forward and FIX them all.

@surli
Any opinions?

[surli]

I hope there are no obstacles to fix them (API compatibility?)

Actually yes this is a problem.
For me typo are the least problem we have in Spoon.
We might be more careful when reviewing the code to avoid them as much as possible, but existing typo are not harmful as long as everything is well documented.
Fixing them might led to API breaking changes that we really do not want.

I would say that the only moment we might be able to fix them is before a major release: then if we already break some things we might agree on breaking more things for a good reason.

In the meantime I'd keep the typo.

[zielint0]

@surli

Just remark: while developing software, I observed that code rot starts from small things (like typos, formatting, etc.). Then bigger flaws follow (broken window). Removing any flaws (sacrificing backward compatibility) imho pays in the long run. I know, sounds terrible! ;-)

Also, what is counterintuitive, typos have many disadvantages.

• how to find out if spelling mistakes in source code are a serious issue or not? [closed]
• How A Typo In Zerocoin’s Source Code Allowed Hackers To Steal $592,000

This is counter intuitive but typos in practice makes development slower (one has to learn and remember misspelled names of variables, functions, classes), make attacks easier (see Zerocoin case) and make code looking unprofessional.

[zielint0]

CtRole.java: ANNONYMOUS_EXECUTABLE -> ANONYMOUS_EXECUTABLE

I tried, but no luck so far.

#2219
#2220

[pvojtechovsky]

@zielint0 can we close this one?

[zielint0]

I would like to fix few more until 2019 and close it myself.
This is not abandoned nor forgotten ;-)