Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDG one: Need to fix bad data #6

Open
odscjames opened this issue Mar 25, 2021 · 1 comment
Open

SDG one: Need to fix bad data #6

odscjames opened this issue Mar 25, 2021 · 1 comment

Comments

@odscjames
Copy link
Contributor

Some "Primary SDG Targets" outcome metrics have a comma at the end - this creates duplicate data.

INDIGO-Initiative/indigo-data-standard#7 will add checks for this to the Data Quality Tool, which will result in this being highlighted and cleaned up in the data.

In the mean time we should correct for bad data; both in Jupyter notebook here and in website

@odscjames
Copy link
Contributor Author

In def sankey_vis add a new line with a strip call

  if OUTCOME_METRIC_PRIMARY in outcome_metric_types:

                primary_sdg_target = m.get('primary_sdg_target', {}).get('value')
                primary_sdg_goal = m.get('primary_sdg_goal', {}).get('value')

                if primary_sdg_target and primary_sdg_goal:
                    primary_sdg_target = primary_sdg_target.strip(" ,")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant