Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After one succesfull download of a tour bundle, later ones fail #38

Open
hannolans opened this issue Nov 22, 2012 · 9 comments
Open

After one succesfull download of a tour bundle, later ones fail #38

hannolans opened this issue Nov 22, 2012 · 9 comments

Comments

@hannolans
Copy link
Contributor

When I create a tour I can succesfully download a tour bundle. After the first time I still get a progress bar but then at the end 'An error occurred'.
Probably because the file name already exists?

@hannolans
Copy link
Contributor Author

Tested and this doesn't happen when you first delete the bundle attachment (part of a tour node) manually by editing the node before creating a new bundle.

Debugged further and it is caused by this if statement:

// If we have a stale tmp file delete it
if (file_exists($path)) {
    unlink($path);
}

If you disable unlink($path), it doesn't fail:

// If we have a stale tmp file delete it
if (file_exists($path)) {
//    unlink($path);
}

@kjaebker
Copy link
Contributor

Could this be a permission issue on the file that was originally created?

@Ambrosiani
Copy link

ah – I ran into this problem as well.

@Ambrosiani
Copy link

specific error message (this is the first bundle after changing the name of the node, so at least I get the bundle):

Strict warning: Only variables should be passed by reference in tap_preprocess_tap_tourml_asset() (line 68 of /Applications/MAMP/htdocs/tap/sites/all/modules/tap-cms/modules/tap/tap.templates.inc).
Strict warning: Only variables should be passed by reference in tap_preprocess_tap_tourml_multipart_asset() (line 135 of /Applications/MAMP/htdocs/tap/sites/all/modules/tap-cms/modules/tap/tap.templates.inc).
Strict warning: Only variables should be passed by reference in tap_preprocess_tap_tourml_asset() (line 68 of /Applications/MAMP/htdocs/tap/sites/all/modules/tap-cms/modules/tap/tap.templates.inc).
Strict warning: Only variables should be passed by reference in tap_preprocess_tap_tourml_multipart_asset() (line 135 of /Applications/MAMP/htdocs/tap/sites/all/modules/tap-cms/modules/tap/tap.templates.inc).

@karnold
Copy link
Contributor

karnold commented Nov 29, 2012

Ambrosiani, are you running php 5.3? these errors are typical when running on php 5.2

@Ambrosiani
Copy link

hi, I'm running php 5.4.4 (on MAMP 2.1.1). Any specific php setting I should try out?

@karnold
Copy link
Contributor

karnold commented Nov 29, 2012

try downgrading to php 5.3

@Ambrosiani
Copy link

OK, I'll try that and get back to you!

@Ambrosiani
Copy link

hmm, php 5.3 seems to cause a lot of conflicts with the underlying modules. I'll keep experimenting a bit and just disregard this problem at the moment.

edit: never mind, cacheing was the problem. With php 5.3.14 bundle exporting works without throwing error messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants