Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Cashboxes page does not always load is_auxiliary properly #976

Closed
jniles opened this issue Nov 29, 2016 · 2 comments · Fixed by #1159
Closed

(bug) Cashboxes page does not always load is_auxiliary properly #976

jniles opened this issue Nov 29, 2016 · 2 comments · Fixed by #1159
Assignees
@jniles @sfount
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Nov 29, 2016

In production, we are seeing the cashboxes radio select not always properly configured with "primary" or "auxiliary" cashboxes. The database has a definition for this table, the radio buttons do not show it on the edit cashbox page.
@jniles jniles added the Bug label Nov 29, 2016
@sfount
Copy link
Contributor

sfount commented Nov 29, 2016

I cannot reproduce this on my local machine, however I can observe the behavior on the server. I will debug this when there are no active users on the system.

@jniles
Copy link
Collaborator Author

jniles commented Jan 29, 2017

I'll look into this one.

@jniles jniles self-assigned this Jan 29, 2017
jniles pushed a commit to jniles/bhima that referenced this issue Feb 9, 2017
fix(cashbox): ensure is_auxiliary is updated
577cf8f 
This commit should fix the issues in cashbox management where cashboxes
were not properly updated with the is_auxiliary field.  It also
generally improves the code by:
 1. Using the translate directive on the client.
 2. Using `db.one()` on the server.
 3. Using `FilterParser` on the server.

Closes Third-Culture-Software#976.
@jniles jniles mentioned this issue Feb 9, 2017
Merged
4 tasks
jniles pushed a commit to jniles/bhima that referenced this issue Feb 10, 2017
fix(cashbox): ensure is_auxiliary is updated
cf0cfc5 
This commit should fix the issues in cashbox management where cashboxes
were not properly updated with the is_auxiliary field.  It also
generally improves the code by:
 1. Using the translate directive on the client.
 2. Using `db.one()` on the server.
 3. Using `FilterParser` on the server.

Closes Third-Culture-Software#976.
sfount pushed a commit that referenced this issue Feb 14, 2017
@sfount
fix(cashbox): ensure is_auxiliary is updated
8a4a2f8 
This commit should fix the issues in cashbox management where cashboxes
were not properly updated with the is_auxiliary field.  It also
generally improves the code by:
 1. Using the translate directive on the client.
 2. Using `db.one()` on the server.
 3. Using `FilterParser` on the server.

Closes #976.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

@sfount sfount

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cashbox): ensure is_auxiliary is updated jniles/bhima
2 participants
@jniles @sfount