Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) bhima build breaks during minification #704

Closed
jniles opened this issue Sep 9, 2016 · 0 comments · Fixed by #705
Closed

(bug) bhima build breaks during minification #704

jniles opened this issue Sep 9, 2016 · 0 comments · Fixed by #705
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Sep 9, 2016

The bhima build no longer minifies code properly when the UGLIFY variable is set to true. Instead the build halts with an intangible error due to not using pump().

Steps to Reproduce

  1. Change UGLIFY to true in gulpfile.js
  2. Run npm run app or npm run dev in the console.
  3. Observe the output

Expected Result
The build terminates and the app starts up

Actual Result
An incomprehensible error.

Recommendation
Make pump() a dev dependency and ensure that minifcation works as expected.
@jniles jniles added the Bug label Sep 9, 2016
@jniles jniles added this to the Future milestone Sep 9, 2016
jniles pushed a commit to jniles/bhima that referenced this issue Sep 9, 2016
fix(build): build minifies using uglifyjs
6c40cf2 
This commit fixes a bug in which ECMAScript 6 features were used in the
client, breaking `uglify`'s build.  These features have been removed in
favor of their ES5 alternates.

The `pump` module has been added as a development dependency due to
better gulp build errors.

Closes Third-Culture-Software#704.
@jniles jniles mentioned this issue Sep 9, 2016
Merged
4 tasks
jniles pushed a commit to jniles/bhima that referenced this issue Sep 9, 2016
fix(build): build minifies using uglifyjs
3d40738 
This commit fixes a bug in which ECMAScript 6 features were used in the
client, breaking `uglify`'s build.  These features have been removed in
favor of their ES5 alternates.

The `pump` module has been added as a development dependency due to
better gulp build errors.

Closes Third-Culture-Software#704.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): build minifies using uglifyjs jniles/bhima
1 participant
@jniles