Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Reports module does not update report definition on transition #1821

Closed
sfount opened this issue Jun 27, 2017 · 1 comment
Closed

(bug) Reports module does not update report definition on transition #1821

sfount opened this issue Jun 27, 2017 · 1 comment
Assignees
@sfount
Labels
Bug client module

Comments

@sfount
Copy link
Contributor

sfount commented Jun 27, 2017

Currently the reports module structure (title and archive button) is in an external reports.html. This allows the structure to share the report definition details with the report generation template (in a ui-view).

The report details are not updated or refreshed when the user transitions to another report. This leaves invalid archive links as well as the incorrect title displayed for the report.
@sfount sfount self-assigned this Jun 27, 2017
@jniles
Copy link
Collaborator

jniles commented Jul 17, 2017

@sfount what is the progress on this one? Can I tackle it?

jniles added a commit to jniles/bhima that referenced this issue Jul 18, 2017
@jniles
fix(reports): hack to refresh reportData
88e8aac 
This commit implements a $rootScope hack to refresh the $state's
reportData.

Closes Third-Culture-Software#1821.
@jniles jniles mentioned this issue Jul 18, 2017
Merged
jniles added a commit to jniles/bhima that referenced this issue Jul 26, 2017
@jniles
fix(reports): hack to refresh reportData
6a4c955 
This commit implements a $rootScope hack to refresh the $state's
reportData.

Closes Third-Culture-Software#1821.
jniles added a commit to jniles/bhima that referenced this issue Jul 28, 2017
@jniles
fix(reports): hack to refresh reportData
5e7056b 
This commit implements a $rootScope hack to refresh the $state's
reportData.

Closes Third-Culture-Software#1821.
bors bot added a commit that referenced this issue Jul 30, 2017
@bors
Merge #1876 #1894
58e2e30 
1876: fix(reports): hack to refresh reportData r=sfount

~~This commit implements a $rootScope hack to refresh the $state's reportData.~~  [See updated description](#1876 (comment))

Closes #1821.

1894: fix(debtor groups): fix debtor group title label r=jniles

This commit fixes a mis-translation in the debtor groups title.  It now
reads "debtor groups" instead of "creditor groups".

![bugcreditorgroupmislabel](https://user-images.githubusercontent.com/896472/28711912-2be8d9c2-7357-11e7-8bc9-bee93e661a16.png)
_Fig 1: Original Bug in Title_


![bugcreditorgroupmislabelfixed](https://user-images.githubusercontent.com/896472/28711911-2bd696cc-7357-11e7-972a-ce93fdefad93.png)
_Fig 2: Fixed Title_
@bors bors bot closed this as completed in #1876 Jul 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfount sfount

Labels
Bug client module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jniles @sfount