Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(journal): order Trial Balance by account number #1602

Conversation

jniles
Copy link
Collaborator

@jniles jniles commented May 5, 2017

This commit orders the trial balance by the account number for better predictability in account
ordering. Ideally, the accounts should be ordered respecting their account tree ordering ... but
this can be optimized later as necessary.

Closes #1599.


Thank you for contributing!

Before submitting this pull request, please verify that you have:

  • Run your code through ESLint. Check out our styleguide.
  • Run integration tests.
  • Run end-to-end tests.
  • Accurately described the changes your are making in this pull request.

For a more detailed checklist, see the official review checklist that this PR will be evaluated against.

Ensuring that the above checkboxes are completed will help speed the review process and help build a stronger application. Thanks!

This commit orders the trial balance by the account number for better predictability in account
ordering.  Ideally, the accounts should be ordered respecting their account tree ordering ... but
this can be optimized later as necessary.

Closes Third-Culture-Software#1599.
@jniles jniles added the Bug Fix label May 5, 2017
Copy link
Contributor

@sfount sfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@jniles jniles merged commit c309572 into Third-Culture-Software:master May 8, 2017
@jniles jniles deleted the fix-trial-balance--account-order branch May 8, 2017 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants