Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) Complex Vouchers do not update with the correct currency in the footer #1286

Closed
jniles opened this issue Feb 28, 2017 · 0 comments · Fixed by #1344
Closed

(bug) Complex Vouchers do not update with the correct currency in the footer #1286

jniles opened this issue Feb 28, 2017 · 0 comments · Fixed by #1344
Assignees
@jniles
Labels
Bug

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 28, 2017 •
edited
Loading

The Complex Voucher grid caches the currency in the footer and does not update it when the user changes currency. The solution is to use a footerCellFilter. See below:

journalvoucherstotalscurrencyincorrect
Fig 1 : Journal Vouchers Currency Rendering Broken
@jniles jniles added the Bug label Feb 28, 2017
@jniles jniles self-assigned this Mar 2, 2017
jniles pushed a commit to jniles/bhima that referenced this issue Mar 12, 2017
fix(vouchers): sync voucher currency w/ footer
07ef36b 
This commit fixes the voucher footer aggregation, keeping it in sync
with the form's selected currency.

Closes Third-Culture-Software#1286.
jniles pushed a commit to jniles/bhima that referenced this issue Mar 12, 2017
fix(vouchers): sync voucher currency w/ footer
458ca49 
This commit fixes the voucher footer aggregation, keeping it in sync
with the form's selected currency.

Closes Third-Culture-Software#1286.
@jniles jniles mentioned this issue Mar 12, 2017
Merged
4 tasks
sfount pushed a commit that referenced this issue Mar 14, 2017
@sfount
fix(vouchers): sync voucher currency w/ footer
c4c817e 
This commit fixes the voucher footer aggregation, keeping it in sync
with the form's selected currency.

Closes #1286.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jniles jniles

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vouchers): sync voucher currency w/ footer jniles/bhima
1 participant
@jniles