Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature request): use gulp to conditionally replace variables in index.html #1219

Closed
jniles opened this issue Feb 19, 2017 · 0 comments · Fixed by #1220
Closed

(feature request): use gulp to conditionally replace variables in index.html #1219

jniles opened this issue Feb 19, 2017 · 0 comments · Fixed by #1220

Comments

@jniles
Copy link
Collaborator

jniles commented Feb 19, 2017

As we begin more serious deployments, it is necessary to start thinking about differences between production and development. Currently, many of our assets are delivered unoptimized because that's how we deal with them in development. By being able to rewrite variables in index.html, we will be able to turn on/off features of angular, moment, and others to make sure the clients get the fastest and smallest experience.

@jniles jniles self-assigned this Feb 19, 2017
jniles pushed a commit to jniles/bhima that referenced this issue Feb 20, 2017
This commit builds the gulp file with revision control such that our
caching scheme can be implemented at infinite and reduce network load.

Closes Third-Culture-Software#1219.
jniles pushed a commit to jniles/bhima that referenced this issue Feb 20, 2017
This commit builds the gulp file with revision control such that our
caching scheme can be implemented at infinite and reduce network load.

Closes Third-Culture-Software#1219.
jniles pushed a commit that referenced this issue Feb 21, 2017
This commit builds the gulp file with revision control such that our
caching scheme can be implemented at infinite and reduce network load.

Closes #1219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant