Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(perf): use flatEntityAccess for the majority of our grids #1039

Closed
jniles opened this issue Dec 9, 2016 · 4 comments
Closed

(perf): use flatEntityAccess for the majority of our grids #1039

jniles opened this issue Dec 9, 2016 · 4 comments
Assignees
Labels

Comments

@jniles
Copy link
Collaborator

jniles commented Dec 9, 2016

One useful performance increase might be to enabled flatEntityAccess for the majority of our grids, particularly the registries. Since we are not mutating data at all in these pages, there is no need to do large , nested traversals of the dataset.

Reference Documentation.

@jniles jniles added the Refactor label Dec 9, 2016
@jniles jniles added this to the Future milestone Dec 9, 2016
@jniles
Copy link
Collaborator Author

jniles commented Dec 13, 2016

I'll tackle this issue. I'll also work on adding:

  1. fastWatch to grids which can use it (documentation).
  2. 'ngTouch' support (documentation)

@jniles jniles self-assigned this Dec 13, 2016
@sfount
Copy link
Contributor

sfount commented Dec 13, 2016

Sounds good to me.

I think that ngTouch support is primarily required for registries and modules that we expect to be used on mobile/ tablets. Modules like the posting journal may not want to implement these if this is a performance overhead on desktop.

@jniles
Copy link
Collaborator Author

jniles commented Dec 13, 2016

If I understand ngTouch correctly, we will add it to the entire repository. Is there something I am missing?

@sfount
Copy link
Contributor

sfount commented Dec 13, 2016 via email

jniles pushed a commit to jniles/bhima that referenced this issue Dec 14, 2016
This commit changes the majority of the ui-grids to use
`flatEntityAccess` and `fastWatch` where possible.  This includes all of
the registries.

It also adds the `ngTouch` module for better behavior on mobile.

Closes Third-Culture-Software#1039.
jniles pushed a commit to jniles/bhima that referenced this issue Dec 20, 2016
This commit changes the majority of the ui-grids to use
`flatEntityAccess` and `fastWatch` where possible.  This includes all of
the registries.

It also adds the `ngTouch` module for better behavior on mobile.

Closes Third-Culture-Software#1039.
sfount pushed a commit that referenced this issue Dec 21, 2016
This commit changes the majority of the ui-grids to use
`flatEntityAccess` and `fastWatch` where possible.  This includes all of
the registries.

It also adds the `ngTouch` module for better behavior on mobile.

Closes #1039.
jniles pushed a commit to jniles/bhima that referenced this issue Dec 22, 2016
This commit changes the majority of the ui-grids to use
`flatEntityAccess` and `fastWatch` where possible.  This includes all of
the registries.

It also adds the `ngTouch` module for better behavior on mobile.

Closes Third-Culture-Software#1039.
jniles pushed a commit to jniles/bhima that referenced this issue Jan 8, 2017
This commit changes the majority of the ui-grids to use
`flatEntityAccess` and `fastWatch` where possible.  This includes all of
the registries.

It also adds the `ngTouch` module for better behavior on mobile.

Closes Third-Culture-Software#1039.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants