Skip to content

Commit

Permalink
fix(ci): build latest chrome for e2e tests
Browse files Browse the repository at this point in the history
This commit makes Travis download the latest chrome to run end to end
tests.  Previous tests bugged out as the webdriver became out of date
with Travis's bundled google-chrome installation.

This is also more technically correct from a testing standpoint since we
expect our users to be running the latest chrome browser.
  • Loading branch information
Jonathan Niles committed Aug 1, 2016
1 parent 82de652 commit 6a575e6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@ sudo: required
dist: trusty

before_install:
- export DISPLAY=:99.0
- export CHROME_BIN=/usr/bin/google-chrome
- sudo apt-get update -qq
- sudo apt-get install -qq mysql-server-5.6 mysql-client-5.6 mysql-client-core-5.6
- sudo apt-get install wkhtmltopdf
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
- wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
- sudo dpkg -i google-chrome*.deb

services:
- mysql
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"start": "sh/deploy.sh",
"karma": "./node_modules/.bin/karma start --single-run --no-auto-watch --concurrency 1 karma.conf.js",
"lint": "./node_modules/.bin/jshint server/ && ./node_modules/.bin/jshint client/src/js/ && ./node_modules/.bin/jshint client/src/partials/",
"test:ends" : "./sh/test-ends.sh",
"test:integration" : "./sh/integration-tests.sh",
"test:ends": "./sh/test-ends.sh",
"test:integration": "./sh/integration-tests.sh",
"app_windows": "gulp build && cd bin && set NODE_ENV=production && node server/app.js",
"dev_windows": "gulp build && cd bin && set NODE_ENV=development && node server/app.js",
"watch": "./node_modules/.bin/gulp watch-client"
Expand Down

0 comments on commit 6a575e6

Please sign in to comment.