From 5f570acf4001f9a6352bfb218f7298f8dd1e9bf7 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 14:48:39 +0200
Subject: [PATCH 01/13] getUpdateOnLoadCode for all Inputs

---
 .../Component/Input/Field/Checkbox.php        | 15 +++++++++
 .../Component/Input/Field/Group.php           | 17 ++++++++--
 .../Component/Input/Field/Input.php           | 31 -------------------
 .../Component/Input/Field/MultiSelect.php     | 26 ++++++++++++++++
 .../Component/Input/Field/Numeric.php         | 15 +++++++++
 .../Component/Input/Field/Password.php        | 15 +++++++++
 .../Component/Input/Field/Radio.php           | 14 +++++++++
 .../Component/Input/Field/Select.php          | 20 ------------
 .../Component/Input/Field/Tag.php             | 17 ++++++++++
 .../Component/Input/Field/Text.php            | 20 ------------
 .../Component/Input/Field/Textarea.php        | 15 +++++++++
 .../templates/default/Input/tpl.checkbox.html |  2 +-
 .../default/Input/tpl.multiselect.html        |  2 +-
 .../templates/default/Input/tpl.numeric.html  |  2 +-
 .../templates/default/Input/tpl.password.html |  2 +-
 .../templates/default/Input/tpl.select.html   |  2 +-
 src/UI/templates/default/Input/tpl.text.html  |  2 +-
 17 files changed, 137 insertions(+), 80 deletions(-)

diff --git a/src/UI/Implementation/Component/Input/Field/Checkbox.php b/src/UI/Implementation/Component/Input/Field/Checkbox.php
index b959a678bc6c..d88d0ea383cc 100644
--- a/src/UI/Implementation/Component/Input/Field/Checkbox.php
+++ b/src/UI/Implementation/Component/Input/Field/Checkbox.php
@@ -7,6 +7,7 @@
 
 use ILIAS\Data\Factory as DataFactory;
 use ILIAS\UI\Component as C;
+use ILIAS\UI\Component\Signal;
 use ILIAS\UI\Implementation\Component\JavaScriptBindable;
 use ILIAS\UI\Implementation\Component\Triggerer;
 use ILIAS\UI\Implementation\Component\Input\InputData;
@@ -85,4 +86,18 @@ public function withInput(InputData $post_input) {
 
 		return $clone;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').prop('checked').toString());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').prop('checked').toString());";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Group.php b/src/UI/Implementation/Component/Input/Field/Group.php
index 5ee19500d964..dadc2105e704 100644
--- a/src/UI/Implementation/Component/Input/Field/Group.php
+++ b/src/UI/Implementation/Component/Input/Field/Group.php
@@ -66,9 +66,7 @@ public function withRequired($is_required) {
 	}
 
 	public function withOnUpdate(Signal $signal) {
-		//TODO: use $clone = parent::withOnUpdate($signal); once the exception there
-		//is solved.
-		$clone = $this->withTriggeredSignal($signal, 'update');
+		$clone = parent::withOnUpdate($signal);
 		$inputs = [];
 		foreach ($this->inputs as $key => $input) {
 			$inputs[$key] = $input->withOnUpdate($signal);
@@ -76,4 +74,17 @@ public function withOnUpdate(Signal $signal) {
 		$clone->inputs = $inputs;
 		return $clone;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function () {
+			/*
+			 * Currently, there is no use case for Group here. The single Inputs
+			 * within the Group are responsible for handling getUpdateOnLoadCode().
+			 */
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Input.php b/src/UI/Implementation/Component/Input/Field/Input.php
index 80aebf940d34..11a29531708c 100644
--- a/src/UI/Implementation/Component/Input/Field/Input.php
+++ b/src/UI/Implementation/Component/Input/Field/Input.php
@@ -467,34 +467,11 @@ final public function getContent() {
 		return $this->content;
 	}
 
-	/**
-	 * @inheritdoc
-	 */
-	public function getUpdateOnLoadCode(): \Closure
-	{
-		throw new \Exception(
-			"This is not implemented yet. Every Input needs to implement ".
-			"this, but to be able to move on currently this is broken. ".
-			"If you see this message, please file a bug at mantis.ilias.de. ".
-			"Also have a look into the roadmap: \"Implement `Input::getUpdateOnLoadCode`, ".
-			"`Input::withOnUpdate` and `Input::appendOnUpdate` for every Input"
-		);
-		// TODO: This method will need to be removed.
-	}
-
 	/**
 	 * @inheritdoc
 	 */
 	public function withOnUpdate(Signal $signal)
 	{
-		// TODO: This exception will need to be removed.
-		throw new \Exception(
-			"This is not implemented yet. Every Input needs to implement ".
-			"this, but to be able to move on currently this is broken. ".
-			"If you see this message, please file a bug at mantis.ilias.de. ".
-			"Also have a look into the roadmap: \"Implement `Input::getUpdateOnLoadCode`, ".
-			"`Input::withOnUpdate` and `Input::appendOnUpdate` for every Input"
-		);
 		return $this->withTriggeredSignal($signal, 'update');
 	}
 
@@ -503,14 +480,6 @@ public function withOnUpdate(Signal $signal)
 	 */
 	public function appendOnUpdate(Signal $signal)
 	{
-		// TODO: This exception will need to be removed.
-		throw new \Exception(
-			"This is not implemented yet. Every Input needs to implement ".
-			"this, but to be able to move on currently this is broken. ".
-			"If you see this message, please file a bug at mantis.ilias.de. ".
-			"Also have a look into the roadmap: \"Implement `Input::getUpdateOnLoadCode`, ".
-			"`Input::withOnUpdate` and `Input::appendOnUpdate` for every Input"
-		);
 		return $this->appendTriggeredSignal($signal, 'update');
 	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/MultiSelect.php b/src/UI/Implementation/Component/Input/Field/MultiSelect.php
index a7702b5b9572..086796c70758 100644
--- a/src/UI/Implementation/Component/Input/Field/MultiSelect.php
+++ b/src/UI/Implementation/Component/Input/Field/MultiSelect.php
@@ -6,6 +6,7 @@
 
 use ILIAS\UI\Component as C;
 use ILIAS\Data\Factory as DataFactory;
+use ILIAS\UI\Component\Signal;
 
 /**
  * This implements the multi-select input.
@@ -63,4 +64,29 @@ function ($value) {
 		return $constraint;
 	}
 
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+				$code = "var checkedBoxes = function() {
+					var options = {};
+					var options_combined = [];
+					$('#$id').find('input').each(function() {
+						options[$(this).val()] = $(this).prop('checked').toString();
+					});
+					for (let [key, value] of Object.entries(options)) {
+						options_combined.push(key + ': ' + value);
+					}
+					return options_combined.join(', ');
+				}
+				$('#$id').on('input', function(event) {
+					il.UI.input.onFieldUpdate(event, '$id', checkedBoxes());
+				});
+				il.UI.input.onFieldUpdate(event, '$id', checkedBoxes());
+				";
+				return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Numeric.php b/src/UI/Implementation/Component/Input/Field/Numeric.php
index 101b79117384..ff2ffa794ca6 100644
--- a/src/UI/Implementation/Component/Input/Field/Numeric.php
+++ b/src/UI/Implementation/Component/Input/Field/Numeric.php
@@ -7,6 +7,7 @@
 
 use ILIAS\Data\Factory as DataFactory;
 use ILIAS\UI\Component as C;
+use ILIAS\UI\Component\Signal;
 
 /**
  * This implements the numeric input.
@@ -51,4 +52,18 @@ protected function isClientSideValueOk($value) {
 	protected function getConstraintForRequirement() {
 		return $this->refinery->numeric()->isNumeric();
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Password.php b/src/UI/Implementation/Component/Input/Field/Password.php
index 34830654e9d0..bc3ce4a54184 100644
--- a/src/UI/Implementation/Component/Input/Field/Password.php
+++ b/src/UI/Implementation/Component/Input/Field/Password.php
@@ -7,6 +7,7 @@
 use ILIAS\UI\Component as C;
 use ILIAS\Data\Password as PWD;
 use ILIAS\Data\Factory as DataFactory;
+use ILIAS\UI\Component\Signal;
 use ILIAS\UI\Implementation\Component\ComponentHelper;
 use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 use ILIAS\UI\Implementation\Component\JavaScriptBindable;
@@ -159,4 +160,18 @@ public function getRevealSignal() {
 	public function getMaskSignal() {
 		return $this->signal_mask;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').find('input').val().replace(/./g, '*'));
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').find('input').val().replace(/./g, '*'));";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Radio.php b/src/UI/Implementation/Component/Input/Field/Radio.php
index 6da60361a02f..c53bf6ee2211 100644
--- a/src/UI/Implementation/Component/Input/Field/Radio.php
+++ b/src/UI/Implementation/Component/Input/Field/Radio.php
@@ -5,6 +5,7 @@
 namespace ILIAS\UI\Implementation\Component\Input\Field;
 
 use ILIAS\UI\Component as C;
+use ILIAS\UI\Component\Signal;
 use ILIAS\UI\Implementation\Component\Input\InputData;
 use ILIAS\UI\Implementation\Component\Input\NameSource;
 use ILIAS\UI\Implementation\Component\JavaScriptBindable;
@@ -160,4 +161,17 @@ public function withInput(InputData $post_input) {
 		return $clone;
 	}
 
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id input:checked').val());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id input:checked').val());";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Select.php b/src/UI/Implementation/Component/Input/Field/Select.php
index 52a75893b01e..ed20f54b02b8 100644
--- a/src/UI/Implementation/Component/Input/Field/Select.php
+++ b/src/UI/Implementation/Component/Input/Field/Select.php
@@ -74,24 +74,4 @@ public function getUpdateOnLoadCode(): \Closure
 			return $code;
 		};
 	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function withOnUpdate(Signal $signal)
-	{
-		// TODO: This method will need to be removed.
-		// See ILIAS\UI\Implementation\Component\Input\Field\Input
-		return $this->withTriggeredSignal($signal, 'update');
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function appendOnUpdate(Signal $signal)
-	{
-		// TODO: This method will need to be removed.
-		// See ILIAS\UI\Implementation\Component\Input\Field\Input
-		return $this->appendTriggeredSignal($signal, 'update');
-	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Tag.php b/src/UI/Implementation/Component/Input/Field/Tag.php
index 88bff16c16f0..fc1fc1bae975 100644
--- a/src/UI/Implementation/Component/Input/Field/Tag.php
+++ b/src/UI/Implementation/Component/Input/Field/Tag.php
@@ -286,4 +286,21 @@ public function withAdditionalOnTagAdded(Signal $signal): C\Input\Field\Tag {
 	public function withAdditionalOnTagRemoved(Signal $signal): C\Input\Field\Tag {
 		return $this->appendTriggeredSignal($signal, self::EVENT_ITEM_REMOVED);
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('itemAdded', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());
+			});
+			$('#$id').on('itemRemoved', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Text.php b/src/UI/Implementation/Component/Input/Field/Text.php
index ed5bb43e4528..f6867363d67d 100644
--- a/src/UI/Implementation/Component/Input/Field/Text.php
+++ b/src/UI/Implementation/Component/Input/Field/Text.php
@@ -55,24 +55,4 @@ public function getUpdateOnLoadCode(): \Closure
 			return $code;
 		};
 	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function withOnUpdate(Signal $signal)
-	{
-		// TODO: This method will need to be removed.
-		// See ILIAS\UI\Implementation\Component\Input\Field\Input
-		return $this->withTriggeredSignal($signal, 'update');
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function appendOnUpdate(Signal $signal)
-	{
-		// TODO: This method will need to be removed.
-		// See ILIAS\UI\Implementation\Component\Input\Field\Input
-		return $this->appendTriggeredSignal($signal, 'update');
-	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Textarea.php b/src/UI/Implementation/Component/Input/Field/Textarea.php
index 9df296e9e762..cf87a0e7958b 100644
--- a/src/UI/Implementation/Component/Input/Field/Textarea.php
+++ b/src/UI/Implementation/Component/Input/Field/Textarea.php
@@ -5,6 +5,7 @@
 namespace ILIAS\UI\Implementation\Component\Input\Field;
 
 use ILIAS\UI\Component as C;
+use ILIAS\UI\Component\Signal;
 use ILIAS\UI\Implementation\Component\JavaScriptBindable;
 use ILIAS\Data\Factory as DataFactory;
 
@@ -105,4 +106,18 @@ public function isLimited()
 		}
 		return false;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').val());";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/templates/default/Input/tpl.checkbox.html b/src/UI/templates/default/Input/tpl.checkbox.html
index 8fa5d7a924ee..6924eb84b83c 100644
--- a/src/UI/templates/default/Input/tpl.checkbox.html
+++ b/src/UI/templates/default/Input/tpl.checkbox.html
@@ -1 +1 @@
-<input type="checkbox" <!-- BEGIN id --> id="{ID}"<!-- END id --> value="checked" <!-- BEGIN value --> {VALUE}="checked" <!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
+<input type="checkbox" id="{ID}" value="checked" <!-- BEGIN value --> {VALUE}="checked" <!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
diff --git a/src/UI/templates/default/Input/tpl.multiselect.html b/src/UI/templates/default/Input/tpl.multiselect.html
index 835e3baa1c8a..7b8d961ee503 100644
--- a/src/UI/templates/default/Input/tpl.multiselect.html
+++ b/src/UI/templates/default/Input/tpl.multiselect.html
@@ -1,4 +1,4 @@
-<ul class="il-input-multiselect">
+<ul class="il-input-multiselect" id="{ID}">
 	<!-- BEGIN option -->
 	<li><input type="checkbox" name="{NAME}[]" value="{VALUE}" {CHECKED} {DISABLED}/> <span>{LABEL}</span> </li>
 	<!-- END option -->
diff --git a/src/UI/templates/default/Input/tpl.numeric.html b/src/UI/templates/default/Input/tpl.numeric.html
index dced9fc18560..0532ffc420ed 100644
--- a/src/UI/templates/default/Input/tpl.numeric.html
+++ b/src/UI/templates/default/Input/tpl.numeric.html
@@ -1 +1 @@
-<input type="number"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
+<input id="{ID}" type="number"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
diff --git a/src/UI/templates/default/Input/tpl.password.html b/src/UI/templates/default/Input/tpl.password.html
index 973994d7da90..6da554eeb32b 100644
--- a/src/UI/templates/default/Input/tpl.password.html
+++ b/src/UI/templates/default/Input/tpl.password.html
@@ -1,4 +1,4 @@
-<div class="il-input-password"<!-- BEGIN id --> id="{ID}"<!-- END id -->>
+<div class="il-input-password" id="{ID}">
 	<input type="password" name="{NAME}"<!-- BEGIN value --> value="{VALUE}"<!-- END value --><!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
 	<!-- BEGIN revelation -->
 	<span class="revelation-glyph revelation-reveal">
diff --git a/src/UI/templates/default/Input/tpl.select.html b/src/UI/templates/default/Input/tpl.select.html
index 11d0be5bc908..68d852a84208 100644
--- a/src/UI/templates/default/Input/tpl.select.html
+++ b/src/UI/templates/default/Input/tpl.select.html
@@ -1,4 +1,4 @@
-<select<!-- BEGIN id --> id="{ID}"<!-- END id --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled -->>
+<select id="{ID}" name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled -->>
 	<!-- BEGIN options -->
 	<option {HIDDEN} {SELECTED} {DISABLED_OPTION} value={VALUE}>
 		{VALUE_STR}
diff --git a/src/UI/templates/default/Input/tpl.text.html b/src/UI/templates/default/Input/tpl.text.html
index 80285a14d9ec..9ef954bead19 100644
--- a/src/UI/templates/default/Input/tpl.text.html
+++ b/src/UI/templates/default/Input/tpl.text.html
@@ -1 +1 @@
-<input<!-- BEGIN id --> id="{ID}"<!-- END id --> type="text"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
+<input id="{ID}" type="text"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />

From c3b27670fd958088ca0953858d5034333d752fbe Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 15:07:01 +0200
Subject: [PATCH 02/13] Make more Inputs to Filter Inputs

---
 src/UI/Component/Input/Field/MultiSelect.php  |  2 +-
 src/UI/Component/Input/Field/Numeric.php      |  2 +-
 src/UI/Component/Input/Field/Tag.php          |  2 +-
 .../Input/Field/FilterContextRenderer.php     | 87 ++++++++++++++++++-
 4 files changed, 88 insertions(+), 5 deletions(-)

diff --git a/src/UI/Component/Input/Field/MultiSelect.php b/src/UI/Component/Input/Field/MultiSelect.php
index 588e0ad6c2c3..9906bdc8a336 100644
--- a/src/UI/Component/Input/Field/MultiSelect.php
+++ b/src/UI/Component/Input/Field/MultiSelect.php
@@ -7,7 +7,7 @@
 /**
  * This describes a multi-select input.
  */
-interface MultiSelect extends Input {
+interface MultiSelect extends FilterInput {
 
 	/**
 	 * Get options as value=>label.
diff --git a/src/UI/Component/Input/Field/Numeric.php b/src/UI/Component/Input/Field/Numeric.php
index e98d0eeff11f..9dae54bcdef0 100644
--- a/src/UI/Component/Input/Field/Numeric.php
+++ b/src/UI/Component/Input/Field/Numeric.php
@@ -8,6 +8,6 @@
 /**
  * This describes numeric inputs.
  */
-interface Numeric extends Input {
+interface Numeric extends FilterInput {
 
 }
diff --git a/src/UI/Component/Input/Field/Tag.php b/src/UI/Component/Input/Field/Tag.php
index 8a4beafb9d32..d773214a781f 100644
--- a/src/UI/Component/Input/Field/Tag.php
+++ b/src/UI/Component/Input/Field/Tag.php
@@ -14,7 +14,7 @@
  *
  * @package ILIAS\UI\Component\Input\Field
  */
-interface Tag extends Input, InputInternal {
+interface Tag extends FilterInput, InputInternal {
 
 	/**
 	 * @return string[] of tags such as [ 'Interesting', 'Boring', 'Animating', 'Repetitious' ]
diff --git a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
index ce3e05d725f9..7b3aa89bb275 100644
--- a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
+++ b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
@@ -49,8 +49,14 @@ protected function renderNoneGroupInput(Component\Input\Field\Input $input, Rend
 
 		if ($input instanceof Component\Input\Field\Text) {
 			$input_tpl = $this->getTemplate("tpl.text.html", true, true);
+		} elseif ($input instanceof Component\Input\Field\Numeric) {
+			$input_tpl = $this->getTemplate("tpl.numeric.html", true, true);
+		} elseif ($input instanceof Component\Input\Field\Tag) {
+			$input_tpl = $this->getTemplate("tpl.tag_input.html", true, true);
 		} elseif ($input instanceof Component\Input\Field\Select) {
 			$input_tpl = $this->getTemplate("tpl.select.html", true, true);
+		} elseif ($input instanceof Component\Input\Field\MultiSelect) {
+			$input_tpl = $this->getTemplate("tpl.multiselect.html", true, true);
 		} else {
 			throw new \LogicException("Cannot render '" . get_class($input) . "'");
 		}
@@ -158,6 +164,7 @@ protected function renderInputField(Template $tpl, Input $input) {
 
 		switch (true) {
 			case ($input instanceof Text):
+			case ($input instanceof Numeric):
 				$tpl->setVariable("NAME", $input->getName());
 
 				if ($input->getValue() !== null) {
@@ -177,6 +184,43 @@ protected function renderInputField(Template $tpl, Input $input) {
 				$tpl = $this->renderSelectInput($tpl, $input);
 				break;
 
+			case ($input instanceof MultiSelect):
+				$tpl = $this->renderMultiSelectInput($tpl, $input);
+				break;
+
+			case ($input instanceof Tag):
+				$configuration = $input->getConfiguration();
+				$input = $input->withAdditionalOnLoadCode(
+					function ($id) use ($configuration) {
+						$encoded = json_encode($configuration);
+
+						return "il.UI.Input.tagInput.init('{$id}', {$encoded});";
+					}
+				);
+				$id = $this->bindJavaScript($input);
+				/**
+				 * @var $input \ILIAS\UI\Implementation\Component\Input\Field\Tag
+				 */
+				$tpl->setVariable("ID", $id);
+				$tpl->setVariable("NAME", $input->getName());
+				if ($input->isDisabled()) {
+					$tpl->setCurrentBlock("disabled");
+					$tpl->setVariable("DISABLED", "disabled");
+					$tpl->parseCurrentBlock();
+				}
+				if ($input->getValue()) {
+					$value = $input->getValue();
+					$tpl->setVariable("VALUE_COMMA_SEPARATED", implode(",", $value));
+					foreach ($value as $tag) {
+						$tpl->setCurrentBlock('existing_tags');
+						$tpl->setVariable("FIELD_ID", $id);
+						$tpl->setVariable("FIELD_NAME", $input->getName());
+						$tpl->setVariable("TAG_NAME", $tag);
+						$tpl->parseCurrentBlock();
+					}
+				}
+				break;
+
 		}
 
 		foreach ($input->getTriggeredSignals() as $s)
@@ -194,11 +238,42 @@ protected function renderInputField(Template $tpl, Input $input) {
 			return $code;
 		});
 		$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
-		$this->maybeRenderId($input, $tpl);
+		$id = $this->bindJavaScript($input);
+		if ($id !== null) {
+			$tpl->setVariable("ID", $id);
+		}
 
 		return $tpl->get();
 	}
 
+
+	public function renderMultiSelectInput(Template $tpl, MultiSelect $input) : Template	{
+		$value = $input->getValue();
+		$name = $input->getName();
+
+		foreach ($input->getOptions() as $opt_value => $opt_label) {
+			$tpl->setCurrentBlock("option");
+			$tpl->setVariable("NAME", $name);
+			$tpl->setVariable("VALUE", $opt_value);
+			$tpl->setVariable("LABEL", $opt_label);
+
+			if($value && in_array($opt_value, $value)) {
+				$tpl->setVariable("CHECKED", 'checked="checked"');
+			}
+			if ($input->isDisabled()) {
+				$tpl->setVariable("DISABLED", 'disabled="disabled"');
+			}
+
+			$tpl->parseCurrentBlock();
+		}
+		return $tpl;
+	}
+
+	/**
+	 * @param Template $tpl
+	 * @param Select $input
+	 * @return Template
+	 */
 	public function renderSelectInput(Template $tpl, Select $input)
 	{
 		if ($input->isDisabled()) {
@@ -289,6 +364,11 @@ public function registerResources(ResourceRegistry $registry) {
 		parent::registerResources($registry);
 		$registry->register('./src/UI/templates/js/Input/Container/filter.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
+		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
+		$registry->register('./libs/bower/bower_components/typeahead.js/dist/typeahead.bundle.js');
+		$registry->register('./libs/bower/bower_components/bootstrap-tagsinput/dist/bootstrap-tagsinput.min.js');
+		$registry->register('./libs/bower/bower_components/bootstrap-tagsinput/dist/bootstrap-tagsinput-typeahead.css');
+		$registry->register('./src/UI/templates/js/Input/Field/tagInput.js');
 	}
 
 
@@ -298,8 +378,11 @@ public function registerResources(ResourceRegistry $registry) {
 	protected function getComponentInterfaceName() {
 		return [
 			Component\Input\Field\Text::class,
+			Component\Input\Field\Numeric::class,
+			Component\Input\Field\Group::class,
+			Component\Input\Field\Tag::class,
 			Component\Input\Field\Select::class,
-			Component\Input\Field\Group::class
+			Component\Input\Field\MultiSelect::class
 		];
 	}
 }
\ No newline at end of file

From 989feba712a49a770d20d36c5b570e69e36d45db Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 15:13:28 +0200
Subject: [PATCH 03/13] Removed Tag Input for now because of ugly rendering in
 Filters

---
 .../Input/Field/FilterContextRenderer.php     | 40 -------------------
 1 file changed, 40 deletions(-)

diff --git a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
index 7b3aa89bb275..95d136a69221 100644
--- a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
+++ b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
@@ -51,8 +51,6 @@ protected function renderNoneGroupInput(Component\Input\Field\Input $input, Rend
 			$input_tpl = $this->getTemplate("tpl.text.html", true, true);
 		} elseif ($input instanceof Component\Input\Field\Numeric) {
 			$input_tpl = $this->getTemplate("tpl.numeric.html", true, true);
-		} elseif ($input instanceof Component\Input\Field\Tag) {
-			$input_tpl = $this->getTemplate("tpl.tag_input.html", true, true);
 		} elseif ($input instanceof Component\Input\Field\Select) {
 			$input_tpl = $this->getTemplate("tpl.select.html", true, true);
 		} elseif ($input instanceof Component\Input\Field\MultiSelect) {
@@ -188,39 +186,6 @@ protected function renderInputField(Template $tpl, Input $input) {
 				$tpl = $this->renderMultiSelectInput($tpl, $input);
 				break;
 
-			case ($input instanceof Tag):
-				$configuration = $input->getConfiguration();
-				$input = $input->withAdditionalOnLoadCode(
-					function ($id) use ($configuration) {
-						$encoded = json_encode($configuration);
-
-						return "il.UI.Input.tagInput.init('{$id}', {$encoded});";
-					}
-				);
-				$id = $this->bindJavaScript($input);
-				/**
-				 * @var $input \ILIAS\UI\Implementation\Component\Input\Field\Tag
-				 */
-				$tpl->setVariable("ID", $id);
-				$tpl->setVariable("NAME", $input->getName());
-				if ($input->isDisabled()) {
-					$tpl->setCurrentBlock("disabled");
-					$tpl->setVariable("DISABLED", "disabled");
-					$tpl->parseCurrentBlock();
-				}
-				if ($input->getValue()) {
-					$value = $input->getValue();
-					$tpl->setVariable("VALUE_COMMA_SEPARATED", implode(",", $value));
-					foreach ($value as $tag) {
-						$tpl->setCurrentBlock('existing_tags');
-						$tpl->setVariable("FIELD_ID", $id);
-						$tpl->setVariable("FIELD_NAME", $input->getName());
-						$tpl->setVariable("TAG_NAME", $tag);
-						$tpl->parseCurrentBlock();
-					}
-				}
-				break;
-
 		}
 
 		foreach ($input->getTriggeredSignals() as $s)
@@ -365,10 +330,6 @@ public function registerResources(ResourceRegistry $registry) {
 		$registry->register('./src/UI/templates/js/Input/Container/filter.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
 		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
-		$registry->register('./libs/bower/bower_components/typeahead.js/dist/typeahead.bundle.js');
-		$registry->register('./libs/bower/bower_components/bootstrap-tagsinput/dist/bootstrap-tagsinput.min.js');
-		$registry->register('./libs/bower/bower_components/bootstrap-tagsinput/dist/bootstrap-tagsinput-typeahead.css');
-		$registry->register('./src/UI/templates/js/Input/Field/tagInput.js');
 	}
 
 
@@ -380,7 +341,6 @@ protected function getComponentInterfaceName() {
 			Component\Input\Field\Text::class,
 			Component\Input\Field\Numeric::class,
 			Component\Input\Field\Group::class,
-			Component\Input\Field\Tag::class,
 			Component\Input\Field\Select::class,
 			Component\Input\Field\MultiSelect::class
 		];

From 379f911ddaa6a03abe901a3355ee99a67f48d722 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 15:23:11 +0200
Subject: [PATCH 04/13] Corrected PHPDoc for some functions

---
 .../Component/Input/Field/FilterContextRenderer.php | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
index 95d136a69221..caedf70030c5 100644
--- a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
+++ b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
@@ -125,7 +125,7 @@ protected function renderProxyFieldWithContext(Template $input_tpl, Input $input
 
 
 	/**
-	 * @param Template $tpl
+	 * @param Template $input_tpl
 	 * @param Input    $input
 	 * @param RendererInterface    $default_renderer
 	 *
@@ -153,9 +153,7 @@ protected function renderProxyField(Template $input_tpl, Input $input, RendererI
 
 	/**
 	 * @param Template $tpl
-	 * @param Input    $input
-	 * @param RendererInterface    $default_renderer
-	 *
+	 * @param Input $input
 	 * @return string
 	 */
 	protected function renderInputField(Template $tpl, Input $input) {
@@ -211,7 +209,11 @@ protected function renderInputField(Template $tpl, Input $input) {
 		return $tpl->get();
 	}
 
-
+	/**
+	 * @param Template $tpl
+	 * @param MultiSelect $input
+	 * @return Template
+	 */
 	public function renderMultiSelectInput(Template $tpl, MultiSelect $input) : Template	{
 		$value = $input->getValue();
 		$name = $input->getName();
@@ -275,6 +277,7 @@ public function renderSelectInput(Template $tpl, Select $input)
 	}
 
 	/**
+	 * @param array $input_labels
 	 * @param RendererInterface $default_renderer
 	 *
 	 * @return string

From 45980f3fdcb7200a6a5a1abc1d59c5e23085e559 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 15:42:54 +0200
Subject: [PATCH 05/13] Template for withonUpdate in Forms

---
 .../Init/classes/class.ilInitialisation.php   |  1 +
 .../Component/Input/Container/Form/Form.php   | 12 ++++-
 .../Input/Container/Form/Factory.php          |  9 +++-
 .../Component/Input/Container/Form/Form.php   | 40 ++++++++++++++-
 .../Input/Container/Form/Renderer.php         | 23 +++++++--
 .../Input/Container/Form/Standard.php         |  5 +-
 .../Component/Input/Field/Renderer.php        | 51 ++++++++++++-------
 .../templates/default/Input/tpl.standard.html |  2 +-
 src/UI/templates/js/Input/Container/form.js   | 29 +++++++++++
 9 files changed, 145 insertions(+), 27 deletions(-)
 create mode 100644 src/UI/templates/js/Input/Container/form.js

diff --git a/Services/Init/classes/class.ilInitialisation.php b/Services/Init/classes/class.ilInitialisation.php
index 55f0bd2c7736..14a21e0d9473 100644
--- a/Services/Init/classes/class.ilInitialisation.php
+++ b/Services/Init/classes/class.ilInitialisation.php
@@ -1605,6 +1605,7 @@ public static function initUIFramework(\ILIAS\DI\Container $c) {
 		};
 		$c["ui.factory.input.container.form"] = function($c) {
 			return new ILIAS\UI\Implementation\Component\Input\Container\Form\Factory(
+				$c["ui.signal_generator"],
 				$c["ui.factory.input.field"]
 			);
 		};
diff --git a/src/UI/Component/Input/Container/Form/Form.php b/src/UI/Component/Input/Container/Form/Form.php
index 9ef8160e042c..03d0011ae174 100644
--- a/src/UI/Component/Input/Container/Form/Form.php
+++ b/src/UI/Component/Input/Container/Form/Form.php
@@ -7,12 +7,15 @@
 use ILIAS\UI\Component\Component;
 use ILIAS\Refinery\Transformation;
 
+use ILIAS\UI\Component\JavaScriptBindable;
+use ILIAS\UI\Component\Signal;
+use ILIAS\UI\Component\Triggerable;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
  * This describes commonalities between all forms.
  */
-interface Form extends Component {
+interface Form extends Component, JavaScriptBindable, Triggerable {
 
 	/**
 	 * Get the inputs contained in the form.
@@ -53,4 +56,11 @@ public function getData();
 	 * TODO: there should be a further method to attach the different submit buttons
 	 */
 
+	/**
+	 * Get the signal to update this form
+	 *
+	 * @return Signal
+	 */
+	public function getUpdateSignal();
+
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Factory.php b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
index d0964895071d..5ab626431847 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Factory.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
@@ -6,16 +6,23 @@
 
 use ILIAS\UI\Component\Input\Container\Form as F;
 use ILIAS\UI\Implementation\Component\Input;
+use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 class Factory implements F\Factory {
+	/**
+	 * @var SignalGeneratorInterface
+	 */
+	protected $signal_generator;
 	/**
 	 * @var Input\Field\Factory
 	 */
 	protected $field_factory;
 
 	public function __construct(
+		SignalGeneratorInterface $signal_generator,
 		Input\Field\Factory $field_factory
 	) {
+		$this->signal_generator = $signal_generator;
 		$this->field_factory = $field_factory;
 	}
 
@@ -23,6 +30,6 @@ public function __construct(
 	 * @inheritdoc
 	 */
 	public function standard($post_url, array $inputs) {
-		return new Standard($this->field_factory, $post_url, $inputs);
+		return new Standard($this->signal_generator, $this->field_factory, $post_url, $inputs);
 	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Form.php b/src/UI/Implementation/Component/Input/Container/Form/Form.php
index c55c1f312bb2..b52c281d4857 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Form.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Form.php
@@ -13,6 +13,9 @@
 use ILIAS\Data;
 use ILIAS\Refinery;
 
+use ILIAS\UI\Implementation\Component\JavaScriptBindable;
+use ILIAS\UI\Implementation\Component\Signal;
+use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
@@ -21,6 +24,7 @@
 abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource {
 
 	use ComponentHelper;
+	use JavaScriptBindable;
 	/**
 	 * @var    C\Input\Field\Group
 	 */
@@ -35,12 +39,21 @@ abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource
 	 * @var    int
 	 */
 	private $count = 0;
+	/**
+	 * @var SignalGeneratorInterface
+	 */
+	protected $signal_generator;
+
+	/**
+	 * @var Signal
+	 */
+	protected $update_signal;
 
 
 	/**
 	 * @param array $inputs
 	 */
-	public function __construct(Input\Field\Factory $field_factory, array $inputs) {
+	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $field_factory, array $inputs) {
 		$classes = [CI\Input\Field\Input::class];
 		$this->checkArgListElements("input", $inputs, $classes);
 		// TODO: this is a dependency and should be treated as such. `use` statements can be removed then.
@@ -50,6 +63,8 @@ public function __construct(Input\Field\Factory $field_factory, array $inputs) {
 			""
 		)->withNameFrom($this);
 		$this->transformation = null;
+		$this->signal_generator = $signal_generator;
+		$this->initSignals();
 	}
 
 
@@ -143,4 +158,27 @@ public function getNewName() {
 
 		return $name;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateSignal() {
+		return $this->update_signal;
+	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function withResetSignals() {
+		$clone = clone $this;
+		$clone->initSignals();
+		return $clone;
+	}
+
+	/**
+	 * Set the update signal for this input
+	 */
+	protected function initSignals() {
+		$this->update_signal = $this->signal_generator->create();
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
index 3a524ca30167..669087930308 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
@@ -5,6 +5,7 @@
 namespace ILIAS\UI\Implementation\Component\Input\Container\Form;
 
 use ILIAS\UI\Implementation\Render\AbstractComponentRenderer;
+use ILIAS\UI\Component\Input\Container\Form;
 use ILIAS\UI\Renderer as RendererInterface;
 use ILIAS\UI\Component;
 
@@ -16,7 +17,7 @@ class Renderer extends AbstractComponentRenderer {
 	public function render(Component\Component $component, RendererInterface $default_renderer) {
 		$this->checkComponent($component);
 
-		if ($component instanceof Component\Input\Container\Form\Standard) {
+		if ($component instanceof Form\Standard) {
 			return $this->renderStandard($component, $default_renderer);
 		}
 
@@ -24,9 +25,13 @@ public function render(Component\Component $component, RendererInterface $defaul
 	}
 
 
-	protected function renderStandard(Component\Input\Container\Form\Standard $component, RendererInterface $default_renderer) {
+	protected function renderStandard(Form\Standard $component, RendererInterface $default_renderer) {
 		$tpl = $this->getTemplate("tpl.standard.html", true, true);
 
+		$component = $this->registerSignals($component);
+		$id = $this->bindJavaScript($component);
+		$tpl->setVariable('ID_FORM', $id);
+
 		if($component->getPostURL()!= ""){
 			$tpl->setCurrentBlock("action");
 			$tpl->setVariable("URL", $component->getPostURL());
@@ -42,12 +47,24 @@ protected function renderStandard(Component\Input\Container\Form\Standard $compo
 		$tpl->setVariable("BUTTONS_TOP", $default_renderer->render($submit_button));
 		$tpl->setVariable("BUTTONS_BOTTOM", $default_renderer->render($submit_button));
 
-		$tpl->setVariable("INPUTS", $default_renderer->render($component->getInputGroup()));
+		$input_group = $component->getInputGroup();
+		$input_group = $input_group->withOnUpdate($component->getUpdateSignal());
+		$tpl->setVariable("INPUTS", $default_renderer->render($input_group));
 
 		return $tpl->get();
 	}
 
 
+	protected function registerSignals(Form\Form $form) {
+		$update = $form->getUpdateSignal();
+		return $form->withAdditionalOnLoadCode(function($id) use ($update) {
+			$code =
+				"$(document).on('{$update}', function(event, signalData) { il.UI.form.onInputUpdate(event, signalData, '{$id}'); return false; });";
+			return $code;
+		});
+	}
+
+
 	/**
 	 * @inheritdoc
 	 */
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Standard.php b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
index 341824601f97..1d11f7bdac2f 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Standard.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
@@ -6,6 +6,7 @@
 
 use ILIAS\UI\Component as C;
 use ILIAS\UI\Implementation\Component\Input;
+use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 /**
  * This implements a standard form.
@@ -18,8 +19,8 @@ class Standard extends Form implements C\Input\Container\Form\Standard {
 	protected $post_url;
 
 
-	public function __construct(Input\Field\Factory $input_factory, $post_url, array $inputs) {
-		parent::__construct($input_factory, $inputs);
+	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $input_factory, $post_url, array $inputs) {
+		parent::__construct($signal_generator, $input_factory, $inputs);
 		$this->checkStringArg("post_url", $post_url);
 		$this->post_url = $post_url;
 	}
diff --git a/src/UI/Implementation/Component/Input/Field/Renderer.php b/src/UI/Implementation/Component/Input/Field/Renderer.php
index e39b0e6d97f0..cd970cb223b8 100644
--- a/src/UI/Implementation/Component/Input/Field/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Field/Renderer.php
@@ -53,6 +53,32 @@ public function registerResources(ResourceRegistry $registry) {
 		$registry->register('./src/UI/templates/js/Input/Field/textarea.js');
 		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
+		$registry->register('./src/UI/templates/js/Input/Container/form.js');
+	}
+
+
+	/**
+	 * @param Input $input
+	 * @return Input|\ILIAS\UI\Implementation\Component\JavaScriptBindable
+	 */
+	protected function setSignals(Input $input) {
+		foreach ($input->getTriggeredSignals() as $s)
+		{
+			$signals[] = [
+				"signal_id" => $s->getSignal()->getId(),
+				"event" => $s->getEvent(),
+				"options" => $s->getSignal()->getOptions()
+			];
+		}
+		$signals = json_encode($signals);
+
+		$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
+			$code = "il.UI.input.setSignalsForId('$id', $signals);";
+			return $code;
+		});
+		$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
+
+		return $input;
 	}
 
 
@@ -129,19 +155,6 @@ protected function renderFieldGroups(Group $group, RendererInterface $default_re
 		return $inputs;
 	}
 
-	/**
-	 * @param Component\JavascriptBindable $component
-	 * @param                              $tpl
-	 */
-	protected function maybeRenderId(Component\JavascriptBindable $component, Template $tpl) {
-		$id = $this->bindJavaScript($component);
-		if ($id !== null) {
-			$tpl->setCurrentBlock("with_id");
-			$tpl->setVariable("ID", $id);
-			$tpl->parseCurrentBlock();
-		}
-	}
-
 
 	/**
 	 * @param Section           $section
@@ -302,11 +315,6 @@ protected function renderInputField(Template $tpl, Input $input, $id) {
 					$tpl->setVariable("DISABLED", 'disabled="disabled"');
 					$tpl->parseCurrentBlock();
 				}
-				if ($id) {
-					$tpl->setCurrentBlock("id");
-					$tpl->setVariable("ID", $id);
-					$tpl->parseCurrentBlock();
-				}
 				break;
 			case ($input instanceof Select):
 				$tpl = $this->renderSelectInput($tpl, $input);
@@ -349,6 +357,12 @@ function ($id) use ($configuration) {
 				break;
 		}
 
+		$input = $this->setSignals($input);
+		$id = $this->bindJavaScript($input);
+		if ($id !== null) {
+			$tpl->setVariable("ID", $id);
+		}
+
 		return $tpl->get();
 	}
 
@@ -492,6 +506,7 @@ protected function renderRadioField(Component\Input\Field\Radio $input, Renderer
 		$input = $input->withAdditionalOnLoadCode(function ($id) {
 			return "il.UI.Input.radio.init('$id');";
 		});
+		$input = $this->setSignals($input);
 		$id = $this->bindJavaScript($input);
 		$input_tpl->setVariable("ID", $id);
 
diff --git a/src/UI/templates/default/Input/tpl.standard.html b/src/UI/templates/default/Input/tpl.standard.html
index 73000bfbbb67..1479f5dc0d5c 100644
--- a/src/UI/templates/default/Input/tpl.standard.html
+++ b/src/UI/templates/default/Input/tpl.standard.html
@@ -1,4 +1,4 @@
-<form role="form" class="il-standard-form form-horizontal" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
+<form role="form" class="il-standard-form form-horizontal" id="{ID_FORM}" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
 	<div class="il-standard-form-header clearfix">
 		<div class="il-standard-form-cmd">{BUTTONS_TOP}</div>
 	</div>
diff --git a/src/UI/templates/js/Input/Container/form.js b/src/UI/templates/js/Input/Container/form.js
new file mode 100644
index 000000000000..6babfe8f39c8
--- /dev/null
+++ b/src/UI/templates/js/Input/Container/form.js
@@ -0,0 +1,29 @@
+/**
+ * Form
+ *
+ * @author <killing@leifos.com>
+ */
+
+var il = il || {};
+il.UI = il.UI || {};
+
+il.UI.form = (function ($) {
+
+	/**
+	 *
+	 * @param event
+	 * @param signalData
+	 */
+	var onInputUpdate = function (event, signalData) {
+		console.log(signalData.options.string_value);
+	};
+
+
+	/**
+	 * Public interface
+	 */
+	return {
+		onInputUpdate: onInputUpdate
+	};
+
+})($);
\ No newline at end of file

From dd9e6517026704867758859802515e9fd32f5b63 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 15:55:58 +0200
Subject: [PATCH 06/13] Remove withonUpdate in Forms due to missing use case

This reverts commit 45980f3fdcb7200a6a5a1abc1d59c5e23085e559.
---
 .../Init/classes/class.ilInitialisation.php   |  1 -
 .../Component/Input/Container/Form/Form.php   | 12 +----
 .../Input/Container/Form/Factory.php          |  9 +---
 .../Component/Input/Container/Form/Form.php   | 40 +--------------
 .../Input/Container/Form/Renderer.php         | 23 ++-------
 .../Input/Container/Form/Standard.php         |  5 +-
 .../Component/Input/Field/Renderer.php        | 51 +++++++------------
 .../templates/default/Input/tpl.standard.html |  2 +-
 src/UI/templates/js/Input/Container/form.js   | 29 -----------
 9 files changed, 27 insertions(+), 145 deletions(-)
 delete mode 100644 src/UI/templates/js/Input/Container/form.js

diff --git a/Services/Init/classes/class.ilInitialisation.php b/Services/Init/classes/class.ilInitialisation.php
index 14a21e0d9473..55f0bd2c7736 100644
--- a/Services/Init/classes/class.ilInitialisation.php
+++ b/Services/Init/classes/class.ilInitialisation.php
@@ -1605,7 +1605,6 @@ public static function initUIFramework(\ILIAS\DI\Container $c) {
 		};
 		$c["ui.factory.input.container.form"] = function($c) {
 			return new ILIAS\UI\Implementation\Component\Input\Container\Form\Factory(
-				$c["ui.signal_generator"],
 				$c["ui.factory.input.field"]
 			);
 		};
diff --git a/src/UI/Component/Input/Container/Form/Form.php b/src/UI/Component/Input/Container/Form/Form.php
index 03d0011ae174..9ef8160e042c 100644
--- a/src/UI/Component/Input/Container/Form/Form.php
+++ b/src/UI/Component/Input/Container/Form/Form.php
@@ -7,15 +7,12 @@
 use ILIAS\UI\Component\Component;
 use ILIAS\Refinery\Transformation;
 
-use ILIAS\UI\Component\JavaScriptBindable;
-use ILIAS\UI\Component\Signal;
-use ILIAS\UI\Component\Triggerable;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
  * This describes commonalities between all forms.
  */
-interface Form extends Component, JavaScriptBindable, Triggerable {
+interface Form extends Component {
 
 	/**
 	 * Get the inputs contained in the form.
@@ -56,11 +53,4 @@ public function getData();
 	 * TODO: there should be a further method to attach the different submit buttons
 	 */
 
-	/**
-	 * Get the signal to update this form
-	 *
-	 * @return Signal
-	 */
-	public function getUpdateSignal();
-
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Factory.php b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
index 5ab626431847..d0964895071d 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Factory.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
@@ -6,23 +6,16 @@
 
 use ILIAS\UI\Component\Input\Container\Form as F;
 use ILIAS\UI\Implementation\Component\Input;
-use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 class Factory implements F\Factory {
-	/**
-	 * @var SignalGeneratorInterface
-	 */
-	protected $signal_generator;
 	/**
 	 * @var Input\Field\Factory
 	 */
 	protected $field_factory;
 
 	public function __construct(
-		SignalGeneratorInterface $signal_generator,
 		Input\Field\Factory $field_factory
 	) {
-		$this->signal_generator = $signal_generator;
 		$this->field_factory = $field_factory;
 	}
 
@@ -30,6 +23,6 @@ public function __construct(
 	 * @inheritdoc
 	 */
 	public function standard($post_url, array $inputs) {
-		return new Standard($this->signal_generator, $this->field_factory, $post_url, $inputs);
+		return new Standard($this->field_factory, $post_url, $inputs);
 	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Form.php b/src/UI/Implementation/Component/Input/Container/Form/Form.php
index b52c281d4857..c55c1f312bb2 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Form.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Form.php
@@ -13,9 +13,6 @@
 use ILIAS\Data;
 use ILIAS\Refinery;
 
-use ILIAS\UI\Implementation\Component\JavaScriptBindable;
-use ILIAS\UI\Implementation\Component\Signal;
-use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
@@ -24,7 +21,6 @@
 abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource {
 
 	use ComponentHelper;
-	use JavaScriptBindable;
 	/**
 	 * @var    C\Input\Field\Group
 	 */
@@ -39,21 +35,12 @@ abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource
 	 * @var    int
 	 */
 	private $count = 0;
-	/**
-	 * @var SignalGeneratorInterface
-	 */
-	protected $signal_generator;
-
-	/**
-	 * @var Signal
-	 */
-	protected $update_signal;
 
 
 	/**
 	 * @param array $inputs
 	 */
-	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $field_factory, array $inputs) {
+	public function __construct(Input\Field\Factory $field_factory, array $inputs) {
 		$classes = [CI\Input\Field\Input::class];
 		$this->checkArgListElements("input", $inputs, $classes);
 		// TODO: this is a dependency and should be treated as such. `use` statements can be removed then.
@@ -63,8 +50,6 @@ public function __construct(SignalGeneratorInterface $signal_generator, Input\Fi
 			""
 		)->withNameFrom($this);
 		$this->transformation = null;
-		$this->signal_generator = $signal_generator;
-		$this->initSignals();
 	}
 
 
@@ -158,27 +143,4 @@ public function getNewName() {
 
 		return $name;
 	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getUpdateSignal() {
-		return $this->update_signal;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function withResetSignals() {
-		$clone = clone $this;
-		$clone->initSignals();
-		return $clone;
-	}
-
-	/**
-	 * Set the update signal for this input
-	 */
-	protected function initSignals() {
-		$this->update_signal = $this->signal_generator->create();
-	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
index 669087930308..3a524ca30167 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
@@ -5,7 +5,6 @@
 namespace ILIAS\UI\Implementation\Component\Input\Container\Form;
 
 use ILIAS\UI\Implementation\Render\AbstractComponentRenderer;
-use ILIAS\UI\Component\Input\Container\Form;
 use ILIAS\UI\Renderer as RendererInterface;
 use ILIAS\UI\Component;
 
@@ -17,7 +16,7 @@ class Renderer extends AbstractComponentRenderer {
 	public function render(Component\Component $component, RendererInterface $default_renderer) {
 		$this->checkComponent($component);
 
-		if ($component instanceof Form\Standard) {
+		if ($component instanceof Component\Input\Container\Form\Standard) {
 			return $this->renderStandard($component, $default_renderer);
 		}
 
@@ -25,13 +24,9 @@ public function render(Component\Component $component, RendererInterface $defaul
 	}
 
 
-	protected function renderStandard(Form\Standard $component, RendererInterface $default_renderer) {
+	protected function renderStandard(Component\Input\Container\Form\Standard $component, RendererInterface $default_renderer) {
 		$tpl = $this->getTemplate("tpl.standard.html", true, true);
 
-		$component = $this->registerSignals($component);
-		$id = $this->bindJavaScript($component);
-		$tpl->setVariable('ID_FORM', $id);
-
 		if($component->getPostURL()!= ""){
 			$tpl->setCurrentBlock("action");
 			$tpl->setVariable("URL", $component->getPostURL());
@@ -47,24 +42,12 @@ protected function renderStandard(Form\Standard $component, RendererInterface $d
 		$tpl->setVariable("BUTTONS_TOP", $default_renderer->render($submit_button));
 		$tpl->setVariable("BUTTONS_BOTTOM", $default_renderer->render($submit_button));
 
-		$input_group = $component->getInputGroup();
-		$input_group = $input_group->withOnUpdate($component->getUpdateSignal());
-		$tpl->setVariable("INPUTS", $default_renderer->render($input_group));
+		$tpl->setVariable("INPUTS", $default_renderer->render($component->getInputGroup()));
 
 		return $tpl->get();
 	}
 
 
-	protected function registerSignals(Form\Form $form) {
-		$update = $form->getUpdateSignal();
-		return $form->withAdditionalOnLoadCode(function($id) use ($update) {
-			$code =
-				"$(document).on('{$update}', function(event, signalData) { il.UI.form.onInputUpdate(event, signalData, '{$id}'); return false; });";
-			return $code;
-		});
-	}
-
-
 	/**
 	 * @inheritdoc
 	 */
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Standard.php b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
index 1d11f7bdac2f..341824601f97 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Standard.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
@@ -6,7 +6,6 @@
 
 use ILIAS\UI\Component as C;
 use ILIAS\UI\Implementation\Component\Input;
-use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 /**
  * This implements a standard form.
@@ -19,8 +18,8 @@ class Standard extends Form implements C\Input\Container\Form\Standard {
 	protected $post_url;
 
 
-	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $input_factory, $post_url, array $inputs) {
-		parent::__construct($signal_generator, $input_factory, $inputs);
+	public function __construct(Input\Field\Factory $input_factory, $post_url, array $inputs) {
+		parent::__construct($input_factory, $inputs);
 		$this->checkStringArg("post_url", $post_url);
 		$this->post_url = $post_url;
 	}
diff --git a/src/UI/Implementation/Component/Input/Field/Renderer.php b/src/UI/Implementation/Component/Input/Field/Renderer.php
index cd970cb223b8..e39b0e6d97f0 100644
--- a/src/UI/Implementation/Component/Input/Field/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Field/Renderer.php
@@ -53,32 +53,6 @@ public function registerResources(ResourceRegistry $registry) {
 		$registry->register('./src/UI/templates/js/Input/Field/textarea.js');
 		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
-		$registry->register('./src/UI/templates/js/Input/Container/form.js');
-	}
-
-
-	/**
-	 * @param Input $input
-	 * @return Input|\ILIAS\UI\Implementation\Component\JavaScriptBindable
-	 */
-	protected function setSignals(Input $input) {
-		foreach ($input->getTriggeredSignals() as $s)
-		{
-			$signals[] = [
-				"signal_id" => $s->getSignal()->getId(),
-				"event" => $s->getEvent(),
-				"options" => $s->getSignal()->getOptions()
-			];
-		}
-		$signals = json_encode($signals);
-
-		$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
-			$code = "il.UI.input.setSignalsForId('$id', $signals);";
-			return $code;
-		});
-		$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
-
-		return $input;
 	}
 
 
@@ -155,6 +129,19 @@ protected function renderFieldGroups(Group $group, RendererInterface $default_re
 		return $inputs;
 	}
 
+	/**
+	 * @param Component\JavascriptBindable $component
+	 * @param                              $tpl
+	 */
+	protected function maybeRenderId(Component\JavascriptBindable $component, Template $tpl) {
+		$id = $this->bindJavaScript($component);
+		if ($id !== null) {
+			$tpl->setCurrentBlock("with_id");
+			$tpl->setVariable("ID", $id);
+			$tpl->parseCurrentBlock();
+		}
+	}
+
 
 	/**
 	 * @param Section           $section
@@ -315,6 +302,11 @@ protected function renderInputField(Template $tpl, Input $input, $id) {
 					$tpl->setVariable("DISABLED", 'disabled="disabled"');
 					$tpl->parseCurrentBlock();
 				}
+				if ($id) {
+					$tpl->setCurrentBlock("id");
+					$tpl->setVariable("ID", $id);
+					$tpl->parseCurrentBlock();
+				}
 				break;
 			case ($input instanceof Select):
 				$tpl = $this->renderSelectInput($tpl, $input);
@@ -357,12 +349,6 @@ function ($id) use ($configuration) {
 				break;
 		}
 
-		$input = $this->setSignals($input);
-		$id = $this->bindJavaScript($input);
-		if ($id !== null) {
-			$tpl->setVariable("ID", $id);
-		}
-
 		return $tpl->get();
 	}
 
@@ -506,7 +492,6 @@ protected function renderRadioField(Component\Input\Field\Radio $input, Renderer
 		$input = $input->withAdditionalOnLoadCode(function ($id) {
 			return "il.UI.Input.radio.init('$id');";
 		});
-		$input = $this->setSignals($input);
 		$id = $this->bindJavaScript($input);
 		$input_tpl->setVariable("ID", $id);
 
diff --git a/src/UI/templates/default/Input/tpl.standard.html b/src/UI/templates/default/Input/tpl.standard.html
index 1479f5dc0d5c..73000bfbbb67 100644
--- a/src/UI/templates/default/Input/tpl.standard.html
+++ b/src/UI/templates/default/Input/tpl.standard.html
@@ -1,4 +1,4 @@
-<form role="form" class="il-standard-form form-horizontal" id="{ID_FORM}" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
+<form role="form" class="il-standard-form form-horizontal" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
 	<div class="il-standard-form-header clearfix">
 		<div class="il-standard-form-cmd">{BUTTONS_TOP}</div>
 	</div>
diff --git a/src/UI/templates/js/Input/Container/form.js b/src/UI/templates/js/Input/Container/form.js
deleted file mode 100644
index 6babfe8f39c8..000000000000
--- a/src/UI/templates/js/Input/Container/form.js
+++ /dev/null
@@ -1,29 +0,0 @@
-/**
- * Form
- *
- * @author <killing@leifos.com>
- */
-
-var il = il || {};
-il.UI = il.UI || {};
-
-il.UI.form = (function ($) {
-
-	/**
-	 *
-	 * @param event
-	 * @param signalData
-	 */
-	var onInputUpdate = function (event, signalData) {
-		console.log(signalData.options.string_value);
-	};
-
-
-	/**
-	 * Public interface
-	 */
-	return {
-		onInputUpdate: onInputUpdate
-	};
-
-})($);
\ No newline at end of file

From d80ffe0f8179b2c276a51270edf75e0c1e657a10 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 17:02:03 +0200
Subject: [PATCH 07/13] Removed unnecessary resource

---
 .../Component/Input/Field/FilterContextRenderer.php              | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
index caedf70030c5..993454176e2c 100644
--- a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
+++ b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
@@ -332,7 +332,6 @@ public function registerResources(ResourceRegistry $registry) {
 		parent::registerResources($registry);
 		$registry->register('./src/UI/templates/js/Input/Container/filter.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
-		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
 	}
 
 

From bde5047bf646174abf2ace2b396d9907a0a2a7f1 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Tue, 18 Jun 2019 15:42:54 +0200
Subject: [PATCH 08/13] Template for withonUpdate in Forms

---
 .../Init/classes/class.ilInitialisation.php   |  1 +
 .../Component/Input/Container/Form/Form.php   | 12 ++++-
 .../Input/Container/Form/Factory.php          |  9 +++-
 .../Component/Input/Container/Form/Form.php   | 40 ++++++++++++++-
 .../Input/Container/Form/Renderer.php         | 23 +++++++--
 .../Input/Container/Form/Standard.php         |  5 +-
 .../Component/Input/Field/Renderer.php        | 51 ++++++++++++-------
 .../templates/default/Input/tpl.standard.html |  2 +-
 src/UI/templates/js/Input/Container/form.js   | 29 +++++++++++
 9 files changed, 145 insertions(+), 27 deletions(-)
 create mode 100644 src/UI/templates/js/Input/Container/form.js

diff --git a/Services/Init/classes/class.ilInitialisation.php b/Services/Init/classes/class.ilInitialisation.php
index c98ccf9f7c1e..2e4793a065e4 100644
--- a/Services/Init/classes/class.ilInitialisation.php
+++ b/Services/Init/classes/class.ilInitialisation.php
@@ -1605,6 +1605,7 @@ public static function initUIFramework(\ILIAS\DI\Container $c) {
 		};
 		$c["ui.factory.input.container.form"] = function($c) {
 			return new ILIAS\UI\Implementation\Component\Input\Container\Form\Factory(
+				$c["ui.signal_generator"],
 				$c["ui.factory.input.field"]
 			);
 		};
diff --git a/src/UI/Component/Input/Container/Form/Form.php b/src/UI/Component/Input/Container/Form/Form.php
index 9ef8160e042c..03d0011ae174 100644
--- a/src/UI/Component/Input/Container/Form/Form.php
+++ b/src/UI/Component/Input/Container/Form/Form.php
@@ -7,12 +7,15 @@
 use ILIAS\UI\Component\Component;
 use ILIAS\Refinery\Transformation;
 
+use ILIAS\UI\Component\JavaScriptBindable;
+use ILIAS\UI\Component\Signal;
+use ILIAS\UI\Component\Triggerable;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
  * This describes commonalities between all forms.
  */
-interface Form extends Component {
+interface Form extends Component, JavaScriptBindable, Triggerable {
 
 	/**
 	 * Get the inputs contained in the form.
@@ -53,4 +56,11 @@ public function getData();
 	 * TODO: there should be a further method to attach the different submit buttons
 	 */
 
+	/**
+	 * Get the signal to update this form
+	 *
+	 * @return Signal
+	 */
+	public function getUpdateSignal();
+
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Factory.php b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
index d0964895071d..5ab626431847 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Factory.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
@@ -6,16 +6,23 @@
 
 use ILIAS\UI\Component\Input\Container\Form as F;
 use ILIAS\UI\Implementation\Component\Input;
+use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 class Factory implements F\Factory {
+	/**
+	 * @var SignalGeneratorInterface
+	 */
+	protected $signal_generator;
 	/**
 	 * @var Input\Field\Factory
 	 */
 	protected $field_factory;
 
 	public function __construct(
+		SignalGeneratorInterface $signal_generator,
 		Input\Field\Factory $field_factory
 	) {
+		$this->signal_generator = $signal_generator;
 		$this->field_factory = $field_factory;
 	}
 
@@ -23,6 +30,6 @@ public function __construct(
 	 * @inheritdoc
 	 */
 	public function standard($post_url, array $inputs) {
-		return new Standard($this->field_factory, $post_url, $inputs);
+		return new Standard($this->signal_generator, $this->field_factory, $post_url, $inputs);
 	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Form.php b/src/UI/Implementation/Component/Input/Container/Form/Form.php
index c55c1f312bb2..b52c281d4857 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Form.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Form.php
@@ -13,6 +13,9 @@
 use ILIAS\Data;
 use ILIAS\Refinery;
 
+use ILIAS\UI\Implementation\Component\JavaScriptBindable;
+use ILIAS\UI\Implementation\Component\Signal;
+use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
@@ -21,6 +24,7 @@
 abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource {
 
 	use ComponentHelper;
+	use JavaScriptBindable;
 	/**
 	 * @var    C\Input\Field\Group
 	 */
@@ -35,12 +39,21 @@ abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource
 	 * @var    int
 	 */
 	private $count = 0;
+	/**
+	 * @var SignalGeneratorInterface
+	 */
+	protected $signal_generator;
+
+	/**
+	 * @var Signal
+	 */
+	protected $update_signal;
 
 
 	/**
 	 * @param array $inputs
 	 */
-	public function __construct(Input\Field\Factory $field_factory, array $inputs) {
+	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $field_factory, array $inputs) {
 		$classes = [CI\Input\Field\Input::class];
 		$this->checkArgListElements("input", $inputs, $classes);
 		// TODO: this is a dependency and should be treated as such. `use` statements can be removed then.
@@ -50,6 +63,8 @@ public function __construct(Input\Field\Factory $field_factory, array $inputs) {
 			""
 		)->withNameFrom($this);
 		$this->transformation = null;
+		$this->signal_generator = $signal_generator;
+		$this->initSignals();
 	}
 
 
@@ -143,4 +158,27 @@ public function getNewName() {
 
 		return $name;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateSignal() {
+		return $this->update_signal;
+	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function withResetSignals() {
+		$clone = clone $this;
+		$clone->initSignals();
+		return $clone;
+	}
+
+	/**
+	 * Set the update signal for this input
+	 */
+	protected function initSignals() {
+		$this->update_signal = $this->signal_generator->create();
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
index 904b59cd23a7..d7a4a1cc1624 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
@@ -5,6 +5,7 @@
 namespace ILIAS\UI\Implementation\Component\Input\Container\Form;
 
 use ILIAS\UI\Implementation\Render\AbstractComponentRenderer;
+use ILIAS\UI\Component\Input\Container\Form;
 use ILIAS\UI\Renderer as RendererInterface;
 use ILIAS\UI\Component;
 
@@ -16,7 +17,7 @@ class Renderer extends AbstractComponentRenderer {
 	public function render(Component\Component $component, RendererInterface $default_renderer) {
 		$this->checkComponent($component);
 
-		if ($component instanceof Component\Input\Container\Form\Standard) {
+		if ($component instanceof Form\Standard) {
 			return $this->renderStandard($component, $default_renderer);
 		}
 
@@ -24,9 +25,13 @@ public function render(Component\Component $component, RendererInterface $defaul
 	}
 
 
-	protected function renderStandard(Component\Input\Container\Form\Standard $component, RendererInterface $default_renderer) {
+	protected function renderStandard(Form\Standard $component, RendererInterface $default_renderer) {
 		$tpl = $this->getTemplate("tpl.standard.html", true, true);
 
+		$component = $this->registerSignals($component);
+		$id = $this->bindJavaScript($component);
+		$tpl->setVariable('ID_FORM', $id);
+
 		if($component->getPostURL()!= ""){
 			$tpl->setCurrentBlock("action");
 			$tpl->setVariable("URL", $component->getPostURL());
@@ -39,12 +44,24 @@ protected function renderStandard(Component\Input\Container\Form\Standard $compo
 		$tpl->setVariable("BUTTONS_TOP", $default_renderer->render($submit_button));
 		$tpl->setVariable("BUTTONS_BOTTOM", $default_renderer->render($submit_button));
 
-		$tpl->setVariable("INPUTS", $default_renderer->render($component->getInputGroup()));
+		$input_group = $component->getInputGroup();
+		$input_group = $input_group->withOnUpdate($component->getUpdateSignal());
+		$tpl->setVariable("INPUTS", $default_renderer->render($input_group));
 
 		return $tpl->get();
 	}
 
 
+	protected function registerSignals(Form\Form $form) {
+		$update = $form->getUpdateSignal();
+		return $form->withAdditionalOnLoadCode(function($id) use ($update) {
+			$code =
+				"$(document).on('{$update}', function(event, signalData) { il.UI.form.onInputUpdate(event, signalData, '{$id}'); return false; });";
+			return $code;
+		});
+	}
+
+
 	/**
 	 * @inheritdoc
 	 */
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Standard.php b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
index 341824601f97..1d11f7bdac2f 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Standard.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
@@ -6,6 +6,7 @@
 
 use ILIAS\UI\Component as C;
 use ILIAS\UI\Implementation\Component\Input;
+use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 /**
  * This implements a standard form.
@@ -18,8 +19,8 @@ class Standard extends Form implements C\Input\Container\Form\Standard {
 	protected $post_url;
 
 
-	public function __construct(Input\Field\Factory $input_factory, $post_url, array $inputs) {
-		parent::__construct($input_factory, $inputs);
+	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $input_factory, $post_url, array $inputs) {
+		parent::__construct($signal_generator, $input_factory, $inputs);
 		$this->checkStringArg("post_url", $post_url);
 		$this->post_url = $post_url;
 	}
diff --git a/src/UI/Implementation/Component/Input/Field/Renderer.php b/src/UI/Implementation/Component/Input/Field/Renderer.php
index e39b0e6d97f0..cd970cb223b8 100644
--- a/src/UI/Implementation/Component/Input/Field/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Field/Renderer.php
@@ -53,6 +53,32 @@ public function registerResources(ResourceRegistry $registry) {
 		$registry->register('./src/UI/templates/js/Input/Field/textarea.js');
 		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
+		$registry->register('./src/UI/templates/js/Input/Container/form.js');
+	}
+
+
+	/**
+	 * @param Input $input
+	 * @return Input|\ILIAS\UI\Implementation\Component\JavaScriptBindable
+	 */
+	protected function setSignals(Input $input) {
+		foreach ($input->getTriggeredSignals() as $s)
+		{
+			$signals[] = [
+				"signal_id" => $s->getSignal()->getId(),
+				"event" => $s->getEvent(),
+				"options" => $s->getSignal()->getOptions()
+			];
+		}
+		$signals = json_encode($signals);
+
+		$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
+			$code = "il.UI.input.setSignalsForId('$id', $signals);";
+			return $code;
+		});
+		$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
+
+		return $input;
 	}
 
 
@@ -129,19 +155,6 @@ protected function renderFieldGroups(Group $group, RendererInterface $default_re
 		return $inputs;
 	}
 
-	/**
-	 * @param Component\JavascriptBindable $component
-	 * @param                              $tpl
-	 */
-	protected function maybeRenderId(Component\JavascriptBindable $component, Template $tpl) {
-		$id = $this->bindJavaScript($component);
-		if ($id !== null) {
-			$tpl->setCurrentBlock("with_id");
-			$tpl->setVariable("ID", $id);
-			$tpl->parseCurrentBlock();
-		}
-	}
-
 
 	/**
 	 * @param Section           $section
@@ -302,11 +315,6 @@ protected function renderInputField(Template $tpl, Input $input, $id) {
 					$tpl->setVariable("DISABLED", 'disabled="disabled"');
 					$tpl->parseCurrentBlock();
 				}
-				if ($id) {
-					$tpl->setCurrentBlock("id");
-					$tpl->setVariable("ID", $id);
-					$tpl->parseCurrentBlock();
-				}
 				break;
 			case ($input instanceof Select):
 				$tpl = $this->renderSelectInput($tpl, $input);
@@ -349,6 +357,12 @@ function ($id) use ($configuration) {
 				break;
 		}
 
+		$input = $this->setSignals($input);
+		$id = $this->bindJavaScript($input);
+		if ($id !== null) {
+			$tpl->setVariable("ID", $id);
+		}
+
 		return $tpl->get();
 	}
 
@@ -492,6 +506,7 @@ protected function renderRadioField(Component\Input\Field\Radio $input, Renderer
 		$input = $input->withAdditionalOnLoadCode(function ($id) {
 			return "il.UI.Input.radio.init('$id');";
 		});
+		$input = $this->setSignals($input);
 		$id = $this->bindJavaScript($input);
 		$input_tpl->setVariable("ID", $id);
 
diff --git a/src/UI/templates/default/Input/tpl.standard.html b/src/UI/templates/default/Input/tpl.standard.html
index 73000bfbbb67..1479f5dc0d5c 100644
--- a/src/UI/templates/default/Input/tpl.standard.html
+++ b/src/UI/templates/default/Input/tpl.standard.html
@@ -1,4 +1,4 @@
-<form role="form" class="il-standard-form form-horizontal" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
+<form role="form" class="il-standard-form form-horizontal" id="{ID_FORM}" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
 	<div class="il-standard-form-header clearfix">
 		<div class="il-standard-form-cmd">{BUTTONS_TOP}</div>
 	</div>
diff --git a/src/UI/templates/js/Input/Container/form.js b/src/UI/templates/js/Input/Container/form.js
new file mode 100644
index 000000000000..6babfe8f39c8
--- /dev/null
+++ b/src/UI/templates/js/Input/Container/form.js
@@ -0,0 +1,29 @@
+/**
+ * Form
+ *
+ * @author <killing@leifos.com>
+ */
+
+var il = il || {};
+il.UI = il.UI || {};
+
+il.UI.form = (function ($) {
+
+	/**
+	 *
+	 * @param event
+	 * @param signalData
+	 */
+	var onInputUpdate = function (event, signalData) {
+		console.log(signalData.options.string_value);
+	};
+
+
+	/**
+	 * Public interface
+	 */
+	return {
+		onInputUpdate: onInputUpdate
+	};
+
+})($);
\ No newline at end of file

From 07b64491edb91e9e2f616e4886a306bcfb6d224c Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Wed, 17 Jul 2019 17:08:58 +0200
Subject: [PATCH 09/13] Made OnUpdate work in Forms without a special use case
 + getUpdateOnLoadcode for DateTime and Duration + solved conflicts / made
 improvements in Input Renderer and some Templates

---
 .../Input/Container/Form/Renderer.php         | 18 +-----
 .../Component/Input/Field/DateTime.php        | 16 ++++-
 .../Component/Input/Field/Duration.php        | 21 +++++++
 .../Component/Input/Field/MultiSelect.php     | 30 +++++-----
 .../Component/Input/Field/Renderer.php        | 58 ++++++++++++++-----
 .../templates/default/Input/tpl.checkbox.html |  2 +-
 .../default/Input/tpl.multiselect.html        |  2 +-
 .../templates/default/Input/tpl.numeric.html  |  2 +-
 .../templates/default/Input/tpl.password.html |  2 +-
 .../templates/default/Input/tpl.select.html   |  2 +-
 .../templates/default/Input/tpl.standard.html |  2 +-
 src/UI/templates/default/Input/tpl.text.html  |  2 +-
 .../templates/default/Input/tpl.textarea.html |  4 +-
 src/UI/templates/js/Input/Container/form.js   | 29 ----------
 14 files changed, 104 insertions(+), 86 deletions(-)
 delete mode 100644 src/UI/templates/js/Input/Container/form.js

diff --git a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
index d7a4a1cc1624..2755852c73db 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Renderer.php
@@ -28,10 +28,6 @@ public function render(Component\Component $component, RendererInterface $defaul
 	protected function renderStandard(Form\Standard $component, RendererInterface $default_renderer) {
 		$tpl = $this->getTemplate("tpl.standard.html", true, true);
 
-		$component = $this->registerSignals($component);
-		$id = $this->bindJavaScript($component);
-		$tpl->setVariable('ID_FORM', $id);
-
 		if($component->getPostURL()!= ""){
 			$tpl->setCurrentBlock("action");
 			$tpl->setVariable("URL", $component->getPostURL());
@@ -44,24 +40,12 @@ protected function renderStandard(Form\Standard $component, RendererInterface $d
 		$tpl->setVariable("BUTTONS_TOP", $default_renderer->render($submit_button));
 		$tpl->setVariable("BUTTONS_BOTTOM", $default_renderer->render($submit_button));
 
-		$input_group = $component->getInputGroup();
-		$input_group = $input_group->withOnUpdate($component->getUpdateSignal());
-		$tpl->setVariable("INPUTS", $default_renderer->render($input_group));
+		$tpl->setVariable("INPUTS", $default_renderer->render($component->getInputGroup()));
 
 		return $tpl->get();
 	}
 
 
-	protected function registerSignals(Form\Form $form) {
-		$update = $form->getUpdateSignal();
-		return $form->withAdditionalOnLoadCode(function($id) use ($update) {
-			$code =
-				"$(document).on('{$update}', function(event, signalData) { il.UI.form.onInputUpdate(event, signalData, '{$id}'); return false; });";
-			return $code;
-		});
-	}
-
-
 	/**
 	 * @inheritdoc
 	 */
diff --git a/src/UI/Implementation/Component/Input/Field/DateTime.php b/src/UI/Implementation/Component/Input/Field/DateTime.php
index 866097412115..c470e4566b03 100644
--- a/src/UI/Implementation/Component/Input/Field/DateTime.php
+++ b/src/UI/Implementation/Component/Input/Field/DateTime.php
@@ -246,4 +246,18 @@ public function withAdditionalPickerconfig(array $config): DateTime
 		return $clone;
 	}
 
-}
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input dp.change', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', $('#$id').find('input').val());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').find('input').val());";
+			return $code;
+		};
+	}
+
+}
\ No newline at end of file
diff --git a/src/UI/Implementation/Component/Input/Field/Duration.php b/src/UI/Implementation/Component/Input/Field/Duration.php
index 8dee9465e955..30255f9b7225 100644
--- a/src/UI/Implementation/Component/Input/Field/Duration.php
+++ b/src/UI/Implementation/Component/Input/Field/Duration.php
@@ -317,4 +317,25 @@ protected function getConstraintForRequirement() {
 		return null;
 	}
 
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "var combinedDuration = function() {
+				var options = [];
+				$('#$id').find('input').each(function() {
+					options.push($(this).val());
+				});
+				return options.join(' - ');
+			}
+			$('#$id').on('input dp.change', function(event) {
+				il.UI.input.onFieldUpdate(event, '$id', combinedDuration());
+			});
+			il.UI.input.onFieldUpdate(event, '$id', combinedDuration());";
+			return $code;
+		};
+	}
+
 }
diff --git a/src/UI/Implementation/Component/Input/Field/MultiSelect.php b/src/UI/Implementation/Component/Input/Field/MultiSelect.php
index 086796c70758..5065d09fcd3a 100644
--- a/src/UI/Implementation/Component/Input/Field/MultiSelect.php
+++ b/src/UI/Implementation/Component/Input/Field/MultiSelect.php
@@ -70,23 +70,23 @@ function ($value) {
 	public function getUpdateOnLoadCode(): \Closure
 	{
 		return function ($id) {
-				$code = "var checkedBoxes = function() {
-					var options = {};
-					var options_combined = [];
-					$('#$id').find('input').each(function() {
-						options[$(this).val()] = $(this).prop('checked').toString();
-					});
-					for (let [key, value] of Object.entries(options)) {
-						options_combined.push(key + ': ' + value);
-					}
-					return options_combined.join(', ');
-				}
-				$('#$id').on('input', function(event) {
-					il.UI.input.onFieldUpdate(event, '$id', checkedBoxes());
+			$code = "var checkedBoxes = function() {
+				var options = {};
+				var options_combined = [];
+				$('#$id').find('input').each(function() {
+					options[$(this).val()] = $(this).prop('checked').toString();
 				});
+				for (let [key, value] of Object.entries(options)) {
+					options_combined.push(key + ': ' + value);
+				}
+				return options_combined.join(', ');
+			}
+			$('#$id').on('input', function(event) {
 				il.UI.input.onFieldUpdate(event, '$id', checkedBoxes());
-				";
-				return $code;
+			});
+			il.UI.input.onFieldUpdate(event, '$id', checkedBoxes());
+			";
+			return $code;
 		};
 	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Renderer.php b/src/UI/Implementation/Component/Input/Field/Renderer.php
index a4c353b2e749..e1fef1a8e179 100644
--- a/src/UI/Implementation/Component/Input/Field/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Field/Renderer.php
@@ -72,7 +72,6 @@ public function registerResources(ResourceRegistry $registry) {
 		$registry->register('./src/UI/templates/js/Input/Field/radioInput.js');
 		$registry->register('./src/UI/templates/js/Input/Field/input.js');
 		$registry->register('./src/UI/templates/js/Input/Field/duration.js');
-		$registry->register('./src/UI/templates/js/Input/Container/form.js');
 	}
 
 
@@ -89,14 +88,17 @@ protected function setSignals(Input $input) {
 				"options" => $s->getSignal()->getOptions()
 			];
 		}
-		$signals = json_encode($signals);
+		if ($signals !== null) {
+			$signals = json_encode($signals);
 
-		$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
-			$code = "il.UI.input.setSignalsForId('$id', $signals);";
-			return $code;
-		});
-		$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
 
+			$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
+				$code = "il.UI.input.setSignalsForId('$id', $signals);";
+				return $code;
+			});
+
+			$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
+		}
 		return $input;
 	}
 
@@ -182,6 +184,20 @@ protected function renderFieldGroups(Group $group, RendererInterface $default_re
 	}
 
 
+	/**
+	 * @param Component\JavascriptBindable $component
+	 * @param                              $tpl
+	 */
+	protected function maybeRenderId(Component\JavascriptBindable $component, Template $tpl) {
+		$id = $this->bindJavaScript($component);
+		if ($id !== null) {
+			$tpl->setCurrentBlock("id");
+			$tpl->setVariable("ID", $id);
+			$tpl->parseCurrentBlock();
+		}
+	}
+
+
 	/**
 	 * @param Section           $section
 	 * @param RendererInterface $default_renderer
@@ -313,12 +329,14 @@ protected function renderInputFieldWithContext(Template $input_tpl, Input $input
 	 */
 	protected function renderInputField(Template $tpl, Input $input, $id) {
 
+		$input = $this->setSignals($input);
+
 		if($input instanceof Component\Input\Field\Password) {
 			$id = $this->additionalRenderPassword($tpl, $input);
 		}
 
 		if($input instanceof Textarea){
-			$tpl = $this->renderTextareaField($tpl, $input);
+			$id = $this->renderTextareaField($tpl, $input);
 		}
 
 		$tpl->setVariable("NAME", $input->getName());
@@ -341,6 +359,11 @@ protected function renderInputField(Template $tpl, Input $input, $id) {
 					$tpl->setVariable("DISABLED", 'disabled="disabled"');
 					$tpl->parseCurrentBlock();
 				}
+				if ($id) {
+					$tpl->setCurrentBlock("id");
+					$tpl->setVariable("ID", $id);
+					$tpl->parseCurrentBlock();
+				}
 				break;
 			case ($input instanceof Select):
 				$tpl = $this->renderSelectInput($tpl, $input);
@@ -386,10 +409,8 @@ function ($id) use ($configuration) {
 				break;
 		}
 
-		$input = $this->setSignals($input);
-		$id = $this->bindJavaScript($input);
-		if ($id !== null) {
-			$tpl->setVariable("ID", $id);
+		if ($id === null) {
+			$this->maybeRenderId($input, $tpl);
 		}
 
 		return $tpl->get();
@@ -461,7 +482,6 @@ public function renderMultiSelectInput(Template $tpl, MultiSelect $input) : Temp
 	 * @return string | false
 	 */
 	protected function additionalRenderPassword(Template $tpl, Component\Input\Field\Password $input) {
-		$id = false;
 		if($input->getRevelation()) {
 			global $DIC;
 			$f = $this->getUIFactory();
@@ -484,6 +504,7 @@ protected function additionalRenderPassword(Template $tpl, Component\Input\Field
 					;
 				});
 			$id = $this->bindJavaScript($input);
+			$tpl->setVariable("ID", $id);
 
 			$glyph_reveal = $f->symbol()->glyph()->eyeopen("#")
 				->withOnClick($sig_reveal);
@@ -510,16 +531,21 @@ protected function renderTextareaField(Template $tpl, Textarea $input)
 			$min = $input->getMinLimit();
 			$max = $input->getMaxLimit();
 
-			$input = $input->withOnLoadCode(function($id) use($counter_id_prefix, $min, $max) {
+			$input = $input->withAdditionalOnLoadCode(function($id) use($counter_id_prefix, $min, $max) {
 				return "il.UI.textarea.changeCounter('$id','$counter_id_prefix','$min','$max');";
 			});
 
 			$textarea_id = $this->bindJavaScript($input);
+			$tpl->setCurrentBlock("id");
 			$tpl->setVariable("ID", $textarea_id);
+			$tpl->parseCurrentBlock();
+			$tpl->setCurrentBlock("limit");
+			$tpl->setVariable("COUNT_ID", $textarea_id);
 			$tpl->setVariable("FEEDBACK_MAX_LIMIT", $max);
+			$tpl->parseCurrentBlock();
 		}
 
-		return $tpl;
+		return $textarea_id;
 	}
 
 
@@ -670,6 +696,7 @@ protected function renderDateTimeInput(Template $tpl, DateTime $input): string
 		}
 		require_once("./Services/Calendar/classes/class.ilCalendarUtil.php");
 		\ilCalendarUtil::initDateTimePicker();
+		$input = $this->setSignals($input);
 		$input = $input->withAdditionalOnLoadCode(function($id) use ($config) {
 			return '$("#'.$id.'").datetimepicker('.json_encode($config).')';
 		});
@@ -717,6 +744,7 @@ protected function renderDurationInput(Duration $input, RendererInterface $defau
 			$tpl->parseCurrentBlock();
 		}
 
+		$input = $this->setSignals($input);
 		$input = $input->withAdditionalOnLoadCode(
 			function($id) {
 				return "$(document).ready(function() {
diff --git a/src/UI/templates/default/Input/tpl.checkbox.html b/src/UI/templates/default/Input/tpl.checkbox.html
index 6924eb84b83c..57b2f9540d8e 100644
--- a/src/UI/templates/default/Input/tpl.checkbox.html
+++ b/src/UI/templates/default/Input/tpl.checkbox.html
@@ -1 +1 @@
-<input type="checkbox" id="{ID}" value="checked" <!-- BEGIN value --> {VALUE}="checked" <!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
+<input type="checkbox"<!-- BEGIN id --> id="{ID}"<!-- END id --> value="checked" <!-- BEGIN value --> {VALUE}="checked" <!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
diff --git a/src/UI/templates/default/Input/tpl.multiselect.html b/src/UI/templates/default/Input/tpl.multiselect.html
index 7b8d961ee503..3505473f1fb9 100644
--- a/src/UI/templates/default/Input/tpl.multiselect.html
+++ b/src/UI/templates/default/Input/tpl.multiselect.html
@@ -1,4 +1,4 @@
-<ul class="il-input-multiselect" id="{ID}">
+<ul class="il-input-multiselect"<!-- BEGIN id --> id="{ID}"<!-- END id -->>
 	<!-- BEGIN option -->
 	<li><input type="checkbox" name="{NAME}[]" value="{VALUE}" {CHECKED} {DISABLED}/> <span>{LABEL}</span> </li>
 	<!-- END option -->
diff --git a/src/UI/templates/default/Input/tpl.numeric.html b/src/UI/templates/default/Input/tpl.numeric.html
index 0532ffc420ed..abbce9993e31 100644
--- a/src/UI/templates/default/Input/tpl.numeric.html
+++ b/src/UI/templates/default/Input/tpl.numeric.html
@@ -1 +1 @@
-<input id="{ID}" type="number"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
+<input<!-- BEGIN id --> id="{ID}"<!-- END id --> type="number"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
diff --git a/src/UI/templates/default/Input/tpl.password.html b/src/UI/templates/default/Input/tpl.password.html
index 6da554eeb32b..973994d7da90 100644
--- a/src/UI/templates/default/Input/tpl.password.html
+++ b/src/UI/templates/default/Input/tpl.password.html
@@ -1,4 +1,4 @@
-<div class="il-input-password" id="{ID}">
+<div class="il-input-password"<!-- BEGIN id --> id="{ID}"<!-- END id -->>
 	<input type="password" name="{NAME}"<!-- BEGIN value --> value="{VALUE}"<!-- END value --><!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
 	<!-- BEGIN revelation -->
 	<span class="revelation-glyph revelation-reveal">
diff --git a/src/UI/templates/default/Input/tpl.select.html b/src/UI/templates/default/Input/tpl.select.html
index 68d852a84208..11d0be5bc908 100644
--- a/src/UI/templates/default/Input/tpl.select.html
+++ b/src/UI/templates/default/Input/tpl.select.html
@@ -1,4 +1,4 @@
-<select id="{ID}" name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled -->>
+<select<!-- BEGIN id --> id="{ID}"<!-- END id --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled -->>
 	<!-- BEGIN options -->
 	<option {HIDDEN} {SELECTED} {DISABLED_OPTION} value={VALUE}>
 		{VALUE_STR}
diff --git a/src/UI/templates/default/Input/tpl.standard.html b/src/UI/templates/default/Input/tpl.standard.html
index 1479f5dc0d5c..73000bfbbb67 100644
--- a/src/UI/templates/default/Input/tpl.standard.html
+++ b/src/UI/templates/default/Input/tpl.standard.html
@@ -1,4 +1,4 @@
-<form role="form" class="il-standard-form form-horizontal" id="{ID_FORM}" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
+<form role="form" class="il-standard-form form-horizontal" enctype="multipart/formdata" <!-- BEGIN action --> action="{URL}"<!-- END action --> method="post" novalidate="novalidate">
 	<div class="il-standard-form-header clearfix">
 		<div class="il-standard-form-cmd">{BUTTONS_TOP}</div>
 	</div>
diff --git a/src/UI/templates/default/Input/tpl.text.html b/src/UI/templates/default/Input/tpl.text.html
index 9ef954bead19..80285a14d9ec 100644
--- a/src/UI/templates/default/Input/tpl.text.html
+++ b/src/UI/templates/default/Input/tpl.text.html
@@ -1 +1 @@
-<input id="{ID}" type="text"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
+<input<!-- BEGIN id --> id="{ID}"<!-- END id --> type="text"<!-- BEGIN value --> value="{VALUE}"<!-- END value --> name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" />
diff --git a/src/UI/templates/default/Input/tpl.textarea.html b/src/UI/templates/default/Input/tpl.textarea.html
index 6897b64522e5..8ed7275bbb86 100644
--- a/src/UI/templates/default/Input/tpl.textarea.html
+++ b/src/UI/templates/default/Input/tpl.textarea.html
@@ -1,2 +1,2 @@
-<textarea name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm" id="{ID}"><!-- BEGIN value -->{VALUE}<!-- END value --></textarea>
-<div id="textarea_feedback_{ID}" data-maxchars="{FEEDBACK_MAX_LIMIT}"></div>
\ No newline at end of file
+<textarea name="{NAME}"<!-- BEGIN disabled --> {DISABLED}<!-- END disabled --> class="form-control form-control-sm"<!-- BEGIN id --> id="{ID}"<!-- END id -->><!-- BEGIN value -->{VALUE}<!-- END value --></textarea>
+<!-- BEGIN limit --><div id="textarea_feedback_{COUNT_ID}" data-maxchars="{FEEDBACK_MAX_LIMIT}"></div><!-- END limit -->
\ No newline at end of file
diff --git a/src/UI/templates/js/Input/Container/form.js b/src/UI/templates/js/Input/Container/form.js
deleted file mode 100644
index 6babfe8f39c8..000000000000
--- a/src/UI/templates/js/Input/Container/form.js
+++ /dev/null
@@ -1,29 +0,0 @@
-/**
- * Form
- *
- * @author <killing@leifos.com>
- */
-
-var il = il || {};
-il.UI = il.UI || {};
-
-il.UI.form = (function ($) {
-
-	/**
-	 *
-	 * @param event
-	 * @param signalData
-	 */
-	var onInputUpdate = function (event, signalData) {
-		console.log(signalData.options.string_value);
-	};
-
-
-	/**
-	 * Public interface
-	 */
-	return {
-		onInputUpdate: onInputUpdate
-	};
-
-})($);
\ No newline at end of file

From 6f94004ef1ddfba744c87117ca4badedfb47cde8 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Thu, 18 Jul 2019 10:50:20 +0200
Subject: [PATCH 10/13] Removed Signal stuff from Form

---
 .../Init/classes/class.ilInitialisation.php   |  1 -
 .../Component/Input/Container/Form/Form.php   | 12 +-----
 .../Input/Container/Form/Factory.php          |  9 +----
 .../Component/Input/Container/Form/Form.php   | 40 +------------------
 .../Input/Container/Form/Standard.php         |  5 +--
 5 files changed, 5 insertions(+), 62 deletions(-)

diff --git a/Services/Init/classes/class.ilInitialisation.php b/Services/Init/classes/class.ilInitialisation.php
index 784cde7aac02..b132b2137680 100644
--- a/Services/Init/classes/class.ilInitialisation.php
+++ b/Services/Init/classes/class.ilInitialisation.php
@@ -1613,7 +1613,6 @@ public static function initUIFramework(\ILIAS\DI\Container $c) {
 		};
 		$c["ui.factory.input.container.form"] = function($c) {
 			return new ILIAS\UI\Implementation\Component\Input\Container\Form\Factory(
-				$c["ui.signal_generator"],
 				$c["ui.factory.input.field"]
 			);
 		};
diff --git a/src/UI/Component/Input/Container/Form/Form.php b/src/UI/Component/Input/Container/Form/Form.php
index 03d0011ae174..9ef8160e042c 100644
--- a/src/UI/Component/Input/Container/Form/Form.php
+++ b/src/UI/Component/Input/Container/Form/Form.php
@@ -7,15 +7,12 @@
 use ILIAS\UI\Component\Component;
 use ILIAS\Refinery\Transformation;
 
-use ILIAS\UI\Component\JavaScriptBindable;
-use ILIAS\UI\Component\Signal;
-use ILIAS\UI\Component\Triggerable;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
  * This describes commonalities between all forms.
  */
-interface Form extends Component, JavaScriptBindable, Triggerable {
+interface Form extends Component {
 
 	/**
 	 * Get the inputs contained in the form.
@@ -56,11 +53,4 @@ public function getData();
 	 * TODO: there should be a further method to attach the different submit buttons
 	 */
 
-	/**
-	 * Get the signal to update this form
-	 *
-	 * @return Signal
-	 */
-	public function getUpdateSignal();
-
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Factory.php b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
index 5ab626431847..d0964895071d 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Factory.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Factory.php
@@ -6,23 +6,16 @@
 
 use ILIAS\UI\Component\Input\Container\Form as F;
 use ILIAS\UI\Implementation\Component\Input;
-use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 class Factory implements F\Factory {
-	/**
-	 * @var SignalGeneratorInterface
-	 */
-	protected $signal_generator;
 	/**
 	 * @var Input\Field\Factory
 	 */
 	protected $field_factory;
 
 	public function __construct(
-		SignalGeneratorInterface $signal_generator,
 		Input\Field\Factory $field_factory
 	) {
-		$this->signal_generator = $signal_generator;
 		$this->field_factory = $field_factory;
 	}
 
@@ -30,6 +23,6 @@ public function __construct(
 	 * @inheritdoc
 	 */
 	public function standard($post_url, array $inputs) {
-		return new Standard($this->signal_generator, $this->field_factory, $post_url, $inputs);
+		return new Standard($this->field_factory, $post_url, $inputs);
 	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Form.php b/src/UI/Implementation/Component/Input/Container/Form/Form.php
index b52c281d4857..c55c1f312bb2 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Form.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Form.php
@@ -13,9 +13,6 @@
 use ILIAS\Data;
 use ILIAS\Refinery;
 
-use ILIAS\UI\Implementation\Component\JavaScriptBindable;
-use ILIAS\UI\Implementation\Component\Signal;
-use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 use Psr\Http\Message\ServerRequestInterface;
 
 /**
@@ -24,7 +21,6 @@
 abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource {
 
 	use ComponentHelper;
-	use JavaScriptBindable;
 	/**
 	 * @var    C\Input\Field\Group
 	 */
@@ -39,21 +35,12 @@ abstract class Form implements C\Input\Container\Form\Form, CI\Input\NameSource
 	 * @var    int
 	 */
 	private $count = 0;
-	/**
-	 * @var SignalGeneratorInterface
-	 */
-	protected $signal_generator;
-
-	/**
-	 * @var Signal
-	 */
-	protected $update_signal;
 
 
 	/**
 	 * @param array $inputs
 	 */
-	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $field_factory, array $inputs) {
+	public function __construct(Input\Field\Factory $field_factory, array $inputs) {
 		$classes = [CI\Input\Field\Input::class];
 		$this->checkArgListElements("input", $inputs, $classes);
 		// TODO: this is a dependency and should be treated as such. `use` statements can be removed then.
@@ -63,8 +50,6 @@ public function __construct(SignalGeneratorInterface $signal_generator, Input\Fi
 			""
 		)->withNameFrom($this);
 		$this->transformation = null;
-		$this->signal_generator = $signal_generator;
-		$this->initSignals();
 	}
 
 
@@ -158,27 +143,4 @@ public function getNewName() {
 
 		return $name;
 	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function getUpdateSignal() {
-		return $this->update_signal;
-	}
-
-	/**
-	 * @inheritdoc
-	 */
-	public function withResetSignals() {
-		$clone = clone $this;
-		$clone->initSignals();
-		return $clone;
-	}
-
-	/**
-	 * Set the update signal for this input
-	 */
-	protected function initSignals() {
-		$this->update_signal = $this->signal_generator->create();
-	}
 }
diff --git a/src/UI/Implementation/Component/Input/Container/Form/Standard.php b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
index 1d11f7bdac2f..341824601f97 100644
--- a/src/UI/Implementation/Component/Input/Container/Form/Standard.php
+++ b/src/UI/Implementation/Component/Input/Container/Form/Standard.php
@@ -6,7 +6,6 @@
 
 use ILIAS\UI\Component as C;
 use ILIAS\UI\Implementation\Component\Input;
-use ILIAS\UI\Implementation\Component\SignalGeneratorInterface;
 
 /**
  * This implements a standard form.
@@ -19,8 +18,8 @@ class Standard extends Form implements C\Input\Container\Form\Standard {
 	protected $post_url;
 
 
-	public function __construct(SignalGeneratorInterface $signal_generator, Input\Field\Factory $input_factory, $post_url, array $inputs) {
-		parent::__construct($signal_generator, $input_factory, $inputs);
+	public function __construct(Input\Field\Factory $input_factory, $post_url, array $inputs) {
+		parent::__construct($input_factory, $inputs);
 		$this->checkStringArg("post_url", $post_url);
 		$this->post_url = $post_url;
 	}

From f694ce98a25ac055664ab5b2f4eee247c19b4100 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Thu, 18 Jul 2019 11:27:16 +0200
Subject: [PATCH 11/13] Improvements in FilterContextRenderer

---
 .../Input/Field/FilterContextRenderer.php     | 51 ++++++++++++-------
 1 file changed, 33 insertions(+), 18 deletions(-)

diff --git a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
index 993454176e2c..74d7f005bdbd 100644
--- a/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
+++ b/src/UI/Implementation/Component/Input/Field/FilterContextRenderer.php
@@ -38,6 +38,34 @@ public function render(Component\Component $component, RendererInterface $defaul
 	}
 
 
+	/**
+	 * @param Input $input
+	 * @return Input|\ILIAS\UI\Implementation\Component\JavaScriptBindable
+	 */
+	protected function setSignals(Input $input) {
+		foreach ($input->getTriggeredSignals() as $s)
+		{
+			$signals[] = [
+				"signal_id" => $s->getSignal()->getId(),
+				"event" => $s->getEvent(),
+				"options" => $s->getSignal()->getOptions()
+			];
+		}
+		if ($signals !== null) {
+			$signals = json_encode($signals);
+
+
+			$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
+				$code = "il.UI.input.setSignalsForId('$id', $signals);";
+				return $code;
+			});
+
+			$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
+		}
+		return $input;
+	}
+
+
 	/**
 	 * @param Component\Input\Field\Input $input
 	 * @param RendererInterface $default_renderer
@@ -158,6 +186,9 @@ protected function renderProxyField(Template $input_tpl, Input $input, RendererI
 	 */
 	protected function renderInputField(Template $tpl, Input $input) {
 
+		$id = null;
+		$input = $this->setSignals($input);
+
 		switch (true) {
 			case ($input instanceof Text):
 			case ($input instanceof Numeric):
@@ -186,24 +217,8 @@ protected function renderInputField(Template $tpl, Input $input) {
 
 		}
 
-		foreach ($input->getTriggeredSignals() as $s)
-		{
-			$signals[] = [
-				"signal_id" => $s->getSignal()->getId(),
-				"event" => $s->getEvent(),
-				"options" => $s->getSignal()->getOptions()
-			];
-		}
-		$signals = json_encode($signals);
-
-		$input = $input->withAdditionalOnLoadCode(function ($id) use ($signals) {
-			$code = "il.UI.input.setSignalsForId('$id', $signals);";
-			return $code;
-		});
-		$input = $input->withAdditionalOnLoadCode($input->getUpdateOnLoadCode());
-		$id = $this->bindJavaScript($input);
-		if ($id !== null) {
-			$tpl->setVariable("ID", $id);
+		if ($id === null) {
+			$this->maybeRenderId($input, $tpl);
 		}
 
 		return $tpl->get();

From 6d44cd245e32158b5af7415c9bcc4716e7a8ca83 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Wed, 4 Sep 2019 11:20:20 +0200
Subject: [PATCH 12/13] Resolving conflicts with trunk

---
 .../Component/Input/Field/Checkbox.php          | 14 ++++++++++++++
 .../Component/Input/Field/Group.php             | 17 ++++++++++++++---
 .../Component/Input/Field/Renderer.php          |  1 +
 3 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/src/UI/Implementation/Component/Input/Field/Checkbox.php b/src/UI/Implementation/Component/Input/Field/Checkbox.php
index fdd91c6f727d..3585b0a9d36f 100644
--- a/src/UI/Implementation/Component/Input/Field/Checkbox.php
+++ b/src/UI/Implementation/Component/Input/Field/Checkbox.php
@@ -106,4 +106,18 @@ public function appendOnChange(C\Signal $signal) {
 	public function withOnLoad(C\Signal $signal) {
 		return $this->withTriggeredSignal($signal, 'load');
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function ($id) {
+			$code = "$('#$id').on('input', function(event) {
+			il.UI.input.onFieldUpdate(event, '$id', $('#$id').prop('checked').toString());
+		});
+		il.UI.input.onFieldUpdate(event, '$id', $('#$id').prop('checked').toString());";
+			return $code;
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Group.php b/src/UI/Implementation/Component/Input/Field/Group.php
index 3ca8e67045f8..6e83614cbfb6 100644
--- a/src/UI/Implementation/Component/Input/Field/Group.php
+++ b/src/UI/Implementation/Component/Input/Field/Group.php
@@ -70,9 +70,7 @@ public function withRequired($is_required) {
 	}
 
 	public function withOnUpdate(Signal $signal) {
-		//TODO: use $clone = parent::withOnUpdate($signal); once the exception there
-		//is solved.
-		$clone = $this->withTriggeredSignal($signal, 'update');
+		$clone = parent::withOnUpdate($signal);
 		$clone->inputs = array_map(function($i) use ($signal) {
 			return $i->withOnUpdate($signal);
 		}, $this->inputs);	
@@ -208,4 +206,17 @@ public function getInputs() {
 	protected function getConstraintForRequirement() {
 		return null;
 	}
+
+	/**
+	 * @inheritdoc
+	 */
+	public function getUpdateOnLoadCode(): \Closure
+	{
+		return function () {
+			/*
+			 * Currently, there is no use case for Group here. The single Inputs
+			 * within the Group are responsible for handling getUpdateOnLoadCode().
+			 */
+		};
+	}
 }
diff --git a/src/UI/Implementation/Component/Input/Field/Renderer.php b/src/UI/Implementation/Component/Input/Field/Renderer.php
index c96f908a6134..bbcbaf112a2b 100644
--- a/src/UI/Implementation/Component/Input/Field/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Field/Renderer.php
@@ -544,6 +544,7 @@ protected function renderRadioField(Component\Input\Field\Radio $input, Renderer
 		$input_tpl = $this->getTemplate("tpl.radio.html", true, true);
 
 		//monitor change-events
+		$input = $this->setSignals($input);
 		$id = $this->bindJavaScript($input) ?? $this->createId();
 		$input_tpl->setVariable("ID", $id);
 

From 733d2c7c3ca5df8b2b3f4f0568593a8ef81b6263 Mon Sep 17 00:00:00 2001
From: Thomas Famula <famula@leifos.de>
Date: Wed, 4 Sep 2019 14:43:39 +0200
Subject: [PATCH 13/13] Test fixes

---
 .../Component/Input/Field/Renderer.php               |  6 +++---
 tests/UI/Component/Input/Field/InputTest.php         |  5 +++++
 tests/UI/Component/Input/Field/TextareaTest.php      | 12 ++++--------
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/src/UI/Implementation/Component/Input/Field/Renderer.php b/src/UI/Implementation/Component/Input/Field/Renderer.php
index bbcbaf112a2b..6ea50b0e8e43 100644
--- a/src/UI/Implementation/Component/Input/Field/Renderer.php
+++ b/src/UI/Implementation/Component/Input/Field/Renderer.php
@@ -110,6 +110,7 @@ public function registerResources(ResourceRegistry $registry) {
 	 * @return Input|\ILIAS\UI\Implementation\Component\JavaScriptBindable
 	 */
 	protected function setSignals(Input $input) {
+		$signals = null;
 		foreach ($input->getTriggeredSignals() as $s)
 		{
 			$signals[] = [
@@ -318,7 +319,7 @@ protected function renderInputField(Template $tpl, Input $input, $id) {
 		}
 
 		if($input instanceof Textarea){
-			$id = $this->renderTextareaField($tpl, $input);
+			$this->renderTextareaField($tpl, $input);
 		}
 
 		$tpl->setVariable("NAME", $input->getName());
@@ -467,6 +468,7 @@ public function renderMultiSelectInput(Template $tpl, MultiSelect $input) : Temp
 	 * @return string | false
 	 */
 	protected function additionalRenderPassword(Template $tpl, Component\Input\Field\Password $input) {
+		$id = null;
 		if($input->getRevelation()) {
 			global $DIC;
 			$f = $this->getUIFactory();
@@ -529,8 +531,6 @@ protected function renderTextareaField(Template $tpl, Textarea $input)
 			$tpl->setVariable("FEEDBACK_MAX_LIMIT", $max);
 			$tpl->parseCurrentBlock();
 		}
-
-		return $textarea_id;
 	}
 
 
diff --git a/tests/UI/Component/Input/Field/InputTest.php b/tests/UI/Component/Input/Field/InputTest.php
index 80c4bc89270f..7d27df1102eb 100644
--- a/tests/UI/Component/Input/Field/InputTest.php
+++ b/tests/UI/Component/Input/Field/InputTest.php
@@ -27,6 +27,11 @@ protected function isClientSideValueOk($value) {
 	protected function getConstraintForRequirement() {
 		return $this->requirement_constraint;
 	}
+
+
+	public function getUpdateOnLoadCode() : \Closure {
+		return function () {};
+	}
 }
 
 class DefNamesource implements NameSource {
diff --git a/tests/UI/Component/Input/Field/TextareaTest.php b/tests/UI/Component/Input/Field/TextareaTest.php
index db8f263af245..e66f9b34fd94 100644
--- a/tests/UI/Component/Input/Field/TextareaTest.php
+++ b/tests/UI/Component/Input/Field/TextareaTest.php
@@ -119,8 +119,7 @@ public function test_renderer() {
 		$expected = "<div class=\"form-group row\">"
 				."<label for=\"$name\" class=\"control-label col-sm-3\">$label</label>"
 				."<div class=\"col-sm-9\">"
-				."<textarea name=\"$name\" class=\"form-control form-control-sm\" id=\"\"></textarea>"
-				."<div id=\"textarea_feedback_\" data-maxchars=\"\"></div>"
+				."<textarea name=\"$name\" class=\"form-control form-control-sm\"></textarea>"
 				."<div class=\"help-block\">byline</div>"
 				."</div>"
 				."</div>";
@@ -217,8 +216,7 @@ public function test_renderer_counter_with_value()
 		$expected = "<div class=\"form-group row\">"
 			."<label for=\"$name\" class=\"control-label col-sm-3\">$label</label>"
 			."<div class=\"col-sm-9\">"
-			."<textarea name=\"$name\" class=\"form-control form-control-sm\" id=\"\">$value</textarea>"
-			."<div id=\"textarea_feedback_\" data-maxchars=\"\"></div>"
+			."<textarea name=\"$name\" class=\"form-control form-control-sm\">$value</textarea>"
 			."<div class=\"help-block\">byline</div>"
 			."</div>"
 			."</div>";
@@ -241,8 +239,7 @@ public function test_renderer_with_error()
 		$expected = "<div class=\"form-group row\">"
 			."<label for=\"$name\" class=\"control-label col-sm-3\">$label</label>"
 			."<div class=\"col-sm-9\">"
-			."<textarea name=\"$name\" class=\"form-control form-control-sm\" id=\"\"></textarea>"
-			."<div id=\"textarea_feedback_\" data-maxchars=\"\"></div>"
+			."<textarea name=\"$name\" class=\"form-control form-control-sm\"></textarea>"
 			."<div class=\"help-block\">$byline</div>"
 			."<div class=\"help-block alert alert-danger\" role=\"alert\">"
 			."<img border=\"0\" src=\"./templates/default/images/icon_alert.svg\" alt=\"alert\" />"
@@ -266,8 +263,7 @@ public function test_renderer_with_disabled()
 		$expected = "<div class=\"form-group row\">"
 			."<label for=\"$name\" class=\"control-label col-sm-3\">$label</label>"
 			."<div class=\"col-sm-9\">"
-			."<textarea name=\"$name\" disabled=\"disabled\" class=\"form-control form-control-sm\" id=\"\"></textarea>"
-			."<div id=\"textarea_feedback_\" data-maxchars=\"\"></div>"
+			."<textarea name=\"$name\" disabled=\"disabled\" class=\"form-control form-control-sm\"></textarea>"
 			."<div class=\"help-block\">byline</div>"
 			."</div>"
 			."</div>";