Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make incoming and archive structure data-handling optional #443

Merged
merged 9 commits into from
Feb 16, 2022

Conversation

lenakinzel
Copy link
Collaborator

Description

  • Added a flag named "use-data-handling" to the config file to make incoming and archive structure data-handling optional
  • this enables to to switch whether the workflow should archive its results and needs the incoming, archive and data directories (=True) or not (=False)

Related Issue

#327

Checklist

…r the reorganization and the archiving within the data-handling
@lenakinzel lenakinzel requested a review from thomasbtf January 6, 2022 16:16
@thomasbtf
Copy link
Contributor

thomasbtf commented Jan 11, 2022

You can just run pre-commit run --all-files. Normally this will fix all the formatting errors. See https://ikim-essen.github.io/uncovar/dev-guide/contributing/#pre-commit for more information :)

Copy link
Collaborator

@alethomas alethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer two separate flags to have also incoming data handling without archiving and vice versa

@thomasbtf thomasbtf linked an issue Feb 14, 2022 that may be closed by this pull request
Copy link
Contributor

@thomasbtf thomasbtf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @alethomas could you also please review?

@thomasbtf thomasbtf merged commit 559e9c1 into master Feb 16, 2022
@thomasbtf thomasbtf deleted the make-parts-of-data-handling-optional branch February 16, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the incoming and archive structure data-handling optional
3 participants