Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prettier to pre-commit #427

Merged
merged 11 commits into from
Jan 3, 2022
Merged

feat: add prettier to pre-commit #427

merged 11 commits into from
Jan 3, 2022

Conversation

thomasbtf
Copy link
Contributor

Description

Adds prettier for js and markdown linting & formatting

Related Issue

None

Checklist

@thomasbtf thomasbtf requested a review from alethomas December 21, 2021 17:42
Copy link
Collaborator

@alethomas alethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we are sure that those changes all still work I approve them. Please wait before merging

Comment on lines 1 to 5
var formatter = {
Lineage: function format(value) {
$(function () {
$('[data-toggle="tooltip"]').tooltip();
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially these changes. Not sure if they still produce the same output. We should have an eye on that

@thomasbtf thomasbtf merged commit e7cb0a7 into master Jan 3, 2022
@thomasbtf thomasbtf deleted the add-js-linter branch January 3, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants