Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bikeshed: Is timeMode the best name? #1602

Closed
azaroth42 opened this issue May 9, 2018 · 3 comments
Closed

bikeshed: Is timeMode the best name? #1602

azaroth42 opened this issue May 9, 2018 · 3 comments

Comments

@azaroth42
Copy link
Member

azaroth42 commented May 9, 2018

It's a behavior for rendering the body time-based media resource. timeMode is pretty unintuitive.

@tomcrane
Copy link
Contributor

Are its three possible values just behaviors that are only permitted on Annotation?

@zimeon
Copy link
Member

zimeon commented May 16, 2018

I suppose if we went that route then we'd have to change names to indicate what they are talking about, something along the lines of trim -> trimDuration, scale -> fitDuration, loop to stay? But, given the specific use, I wonder whether hiding these three behaviors inside an already large set of behaviors is just going to be more confusing? On balance I lean toward the status quo, though we could also consider alternate names

@azaroth42
Copy link
Member Author

After 6 months, clearly we don't care enough to come up with a new name :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants