We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canvas.getCanonicalImageUri currently falls back to the thumbnail property if it fails to find an image annotation:
https://github.com/UniversalViewer/manifesto/blob/master/src/Canvas.ts#L57
This should be moved back to canvas.getThumbUri:
https://github.com/UniversalViewer/manifesto/blob/master/src/Canvas.ts#L95
Canvas.getThumbUri should contain all logic for acquiring the thumb URI, including calls to getCanonicalImageUri.
https://gist.github.com/tomcrane/093c6281d74b3bc8f59d https://github.com/sul-dlss/iiifManifestLayouts/blob/master/src/thumbnailFactory.js
The text was updated successfully, but these errors were encountered:
I'm not sure if this is the right place to report this or if I should open a new issue. Open the following manifest: http://dms-data.stanford.edu/data/manifests/Walters/qm670kv1873/manifest.json in the manifest editor (e.g. under http://iiif.bodleian.ox.ac.uk/manifest-editor/). The thumbnails do not load. It looks like manifesto's canvas.getThumbUri() method returns "native.jpg" but it should be "default.jpg".
Example image request: https://stacks.stanford.edu/image/iiif/qm670kv1873%252FW168_000008_300/full/,150/0/native.jpg
Should be: https://stacks.stanford.edu/image/iiif/qm670kv1873%252FW168_000008_300/full/,150/0/default.jpg
The info.json (https://stacks.stanford.edu/image/iiif/qm670kv1873%252FW168_000008_300/info.json) has the following profile: http://iiif.io/api/image/2/level0.json
Sorry, something went wrong.
No branches or pull requests
Canvas.getCanonicalImageUri currently falls back to the thumbnail property if it fails to find an image annotation:
https://github.com/UniversalViewer/manifesto/blob/master/src/Canvas.ts#L57
This should be moved back to canvas.getThumbUri:
https://github.com/UniversalViewer/manifesto/blob/master/src/Canvas.ts#L95
Canvas.getThumbUri should contain all logic for acquiring the thumb URI, including calls to getCanonicalImageUri.
https://gist.github.com/tomcrane/093c6281d74b3bc8f59d
https://github.com/sul-dlss/iiifManifestLayouts/blob/master/src/thumbnailFactory.js
The text was updated successfully, but these errors were encountered: