Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support for study_parser.py #36

Open
dominikl opened this issue Feb 26, 2021 · 1 comment
Open

Unicode support for study_parser.py #36

dominikl opened this issue Feb 26, 2021 · 1 comment

Comments

@dominikl
Copy link
Member

dominikl commented Feb 26, 2021

The study_parser.py doesn't work with unicode characters. We should look into that. Hopefully won't be hard to fix, as the metadata plugin for example works fine with unicode.

For example if the study file contains an umlaut you'll get:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfc in position 2515: invalid start byte

@sbesson
Copy link
Member

sbesson commented Mar 2, 2021

@dominikl agreed it would be good for the parser to just do the right thing for any incoming study file. Immediate thought would be to try and force the encoding in

with open(self._study_file, 'r') as f:

Otherwise, we could look at an example file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants