Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating message missed on conversion of data and a more general point on translations #8200

Closed
rdstern opened this issue Mar 7, 2023 · 2 comments
Assignees
Labels
Translation (JSON) For issues when text is translated but translated incorrectly; JSON update needed Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Mar 7, 2023

@lloyddewit I write this issue afer my first day of using R-Instat in Portuguese. I make some general points before this particular issue:
a) Getting this Language "system" working has been so much work for many people, but perhaps particularly for you. But, the value for even this potential group is huge. That's because we are aiming for some relative beginners in computing and statistics. So not having to add a foreign language for the menus is going to be just so helpful.
b) I have had to go back to Version 0.7.6 and the improvements from there are also important.
c) Our "trick" of being able to switch to English is a very useful component.
d) So I agree we should mention to Bob Muenchen. And we really should continue. And even the machine translation is pretty useful - which is fantastic for further langues when needed. But also there is a way to go, particularly to "complete" the machine translation part, because any improvements there apply immediately to all langueges.

So here is the latest bit we have missed. As well as correcting it, I am keen to check on our "system", see below:

image

This is an example of a message that is only displayed when we sort of make a mistake. And there seem to be a lot of these messages scattered in the code.

Currently we only include these improvements when we find them, so when a user makes that particular mistake.

Could we instead look for the messages in the code? And, when a developer changes a message, or adds a new message, then could they alert the system in some way, because that will need to be included in the translation system. So another rule for developers. It is also a feature that will be quite hard for me to check as a tester, but may be easy for the code checker to become alert to?

I feel that currently we are only finding and adding these bits for tranlsation when a user happens to make an error, or has data with odd propertires. And checking only from the user end will not be the best or most efficient?

@rdstern rdstern added Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed Translation (JSON) For issues when text is translated but translated incorrectly; JSON update needed labels Mar 7, 2023
@rdstern rdstern added this to the 0.7.10 milestone Mar 7, 2023
@rdstern
Copy link
Collaborator Author

rdstern commented Mar 27, 2023

@lloyddewit I am adding some other messages that are not translated. I still wonder about looking in the code, but I hope a quick win (on translation) will include the one above, when converting back to numeric. This message comes from File > Close Data Book

image

Here is the right click > delete column message:

image

I assume there will be quite a lot of other ones, with some from individual dialogues? But these 3 will be a useful start. Is this you, or could you allocate?

@lloyddewit
Copy link
Contributor

@rdstern Thank you again for all the feedback. I will add a mechanism to translate the message boxes. I will use an auto search for all the message boxes in R-Instat and translate them all together. This is already covered by issue #3721 so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation (JSON) For issues when text is translated but translated incorrectly; JSON update needed Translation (mechanism) For issues when text should be translated but is not (or other way around); code update needed
Projects
None yet
Development

No branches or pull requests

2 participants