Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making save control automatically adjust its width when more space is needed due to translation #6456

Open
Patowhiz opened this issue May 6, 2021 · 3 comments

Comments

@Patowhiz
Copy link
Contributor

Patowhiz commented May 6, 2021

Some languages result into the label of the save control being longer that the text used in English. This forces the design developers to make the width of the save control be longer than needed just incase a translation results in longer label.

@rdstern @lloyddewit I propose to have the save control be dynamic in regards to its width and to detect when the label is not visible enough. This could have been done automatically if the control was a typical VB.NET control but that's not the case.

@Patowhiz Patowhiz changed the title Making save control label automatically adjust its width when more space is needed due to translation Making save control automatically adjust its width when more space is needed due to translation May 6, 2021
@Patowhiz
Copy link
Contributor Author

Patowhiz commented May 6, 2021

This feature can be done once PR #6434 has been merged.

@lloyddewit
Copy link
Contributor

@Patowhiz

Some languages result into the label of the save control being longer that the text used in English. This forces the design developers to make the width of the save control be longer than needed just incase a translation results in longer label.

@rdstern @lloyddewit I propose to have the save control be dynamic in regards to its width and to detect when the label is not visible enough. This could have been done automatically if the control was a typical VB.NET control but that's not the case.

@Patowhiz Thanks for the suggestion, here's my personal view:

I can see the advantages. Possible risks could be:

  • if the control expands then it may affect other controls in the dialog
  • it may be quite complex to implement and test a solution that copes with all the permutations
  • if the user toggles between languages then the dialog controls will shift, this may look strange

I suggest we first try the simpler fixed-width approach and see how it looks. If we decide that the fixed approach looks too ugly when dialogs are displayed in English, then we could consider the variable-width approach above.

@Patowhiz
Copy link
Contributor Author

@lloyddewit yes this can wait. No need to implement this if a simple fixed-width approach works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants