Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parameter(s?) from geom_smooth #5067

Closed
dannyparsons opened this issue Oct 21, 2018 · 3 comments · Fixed by #5069
Closed

Missing parameter(s?) from geom_smooth #5067

dannyparsons opened this issue Oct 21, 2018 · 3 comments · Fixed by #5069
Assignees

Comments

@dannyparsons
Copy link
Contributor

Colour is missing as a layer parameter for geom_smooth. Can it be added to the geom definition? This would be a good time to check if any other parameters are missing from geom_smooth.

@dannyparsons dannyparsons changed the title Missing parameter(s) from geom_smooth Missing parameter(s?) from geom_smooth Oct 21, 2018
@dannyparsons
Copy link
Contributor Author

This is a good task for @Ogik99 to do with @maxwellfundi to understand how geoms are implemented in R-Instat.

@maxwellfundi
Copy link
Contributor

Great, we will be looking at this today. I remember formula was left out because we did not have editable input textboxes. We can actually revisit that as well.

@dannyparsons
Copy link
Contributor Author

That would be good to look into. The common ones like colour are most important to get working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants