Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is checkpointing supported / should it be added? #228

Closed
FabianSchuetze opened this issue Mar 8, 2023 · 3 comments
Closed

Is checkpointing supported / should it be added? #228

FabianSchuetze opened this issue Mar 8, 2023 · 3 comments

Comments

@FabianSchuetze
Copy link

FabianSchuetze commented Mar 8, 2023

Thanks for the wonderful repo - it's a pleasure to work with it and to read the code.

Is checkpointing currently supported by detrex? If not, would there be an interest in a PR that adds checkpointing? I have added it for the Dino encoder and decoder and it seemed to work well.

@rentainhe
Copy link
Collaborator

Thanks for the wonderful repo - it's a pleasure to work with it and to read the code.

Is checkpointing currently supported by detrex? If not, would there be an interest in a PR that adds checkpointing? I have added it for the Dino encoder and decoder and it seemed to work well.

Sure, we appreciate any kind of contribution from the community~ You can open a pull request about this, thank you so much~

@rentainhe
Copy link
Collaborator

BTW, we simply support checkpointing in DINO before, but a little bit not that elegant, we will highly appreciate your pull request about it~

@FabianSchuetze
Copy link
Author

I just saw the new release and PR #200 . The solution is very elegant and useful. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants