You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PriceTaker class must still be merged into the main codebase. This class and associated workflow can be useful for projects related to DISPATCHES-type work. For example, modeling flexible desalination in WaterTAP is of interest, and we could make use of the Pricetaker class.
Here is a to-do list based on @andrewlee94 's suggested changes and @radhakrishnatg 's suggestions for enhancement.
Add test file for design_and_operation_model.py @radhakrishnatg
Strengthen unit tests across the board (e.g., test add_startup_shutdown and other methods); consider simpler dummy cases for unit testing all the methods in isolation @adam-a-a
Create new PR(s) for the following
Enable addition of startup, shutdown, ramping, etc. constraints when representative days (as opposed to full-year price signal) are used
Enable addition of cash flow/cost expressions when representative days are used
consider testing with IDAES process model (beyond simplified surrogate models that don't use typical IDAES unit models)
allow for different temporal resolution; cashflow calcs limited to hourly
The text was updated successfully, but these errors were encountered:
@adam-a-a, @MarcusHolly, @radhakrishnatg will you be opening PRs here in idaes-pse for this? If so, might one of you be able to join the dev call to discuss and track progress? If not any of you, then who?
@ksbeattie the initial plan is to help get #1358 merged first, and we broke down separate tasks (and assignees) for getting that done. At least one of us should be able to attend every now and then to give updates.
As for new PRs, we would open these here on idaes-PSE, only after merging said PR.
@ksbeattie the initial plan is to help get #1358 merged first, and we broke down separate tasks (and assignees) for getting that done. At least one of us should be able to attend every now and then to give updates.
As for new PRs, we would open these here on idaes-PSE, only after merging said PR.
I just joined the call and gave a brief update, more or less saying what you've stated here. I can join the calls in the future.
The PriceTaker class must still be merged into the main codebase. This class and associated workflow can be useful for projects related to DISPATCHES-type work. For example, modeling flexible desalination in WaterTAP is of interest, and we could make use of the Pricetaker class.
Here is a to-do list based on @andrewlee94 's suggested changes and @radhakrishnatg 's suggestions for enhancement.
**Finish PR #1358 **
add_startup_shutdown
and other methods); consider simpler dummy cases for unit testing all the methods in isolation @adam-a-aCreate new PR(s) for the following
The text was updated successfully, but these errors were encountered: