Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Fomantic UI CSS with Semantic UI CSS #3233

Closed
fniessink opened this issue Jan 13, 2022 · 1 comment · Fixed by #3574
Closed

Replace Fomantic UI CSS with Semantic UI CSS #3233

fniessink opened this issue Jan 13, 2022 · 1 comment · Fixed by #3574
Labels
Tech Technical change without significant user impact

Comments

@fniessink
Copy link
Member

fniessink commented Jan 13, 2022 •
edited by wkoot
Loading

Upgrade of CRA to v5 fails due to Semantic-Org/Semantic-UI-CSS#75. The issue is fixed in this PR: Semantic-Org/Semantic-UI-CSS#76. There is now a release on npm: https://www.npmjs.com/package/semantic-ui-css.

We've started to use Fomantic UI CSS to work around the failing upgrade of CRA. Now that Semantic UI CSS has been released we can move back to Semantic UI CSS version. However, a first attempt made clear that a lot of UI fiddling is needed to get dark mode to properly work. Postponing this issue for the time being.

Open issue: dark mode is not supported by Semantic UI, this causes a lot of extra work to implement. The latest version (v3) of Semantic UI is still in beta: Semantic-Org/Semantic-UI-React#4409
@fniessink fniessink added the Tech Technical change without significant user impact label Jan 13, 2022
@fniessink fniessink mentioned this issue Jan 14, 2022
Closed
@fniessink fniessink mentioned this issue Mar 23, 2022
Merged
@fniessink fniessink reopened this Apr 14, 2022
@fniessink fniessink self-assigned this Nov 3, 2022
@fniessink fniessink changed the title Fix upgrade of Create React App when new release of Semantic UI CSS is available Replace Romantic UI CSS with Semantic UI CSS Nov 10, 2022
@fniessink fniessink removed their assignment Nov 10, 2022
@fniessink fniessink changed the title Replace Romantic UI CSS with Semantic UI CSS Replace Fomantic UI CSS with Semantic UI CSS Nov 17, 2022
@fniessink fniessink moved this to Blocked by other issue or time in Quality-time backlog May 24, 2024
@fniessink fniessink mentioned this issue Aug 27, 2024
Closed
@fniessink
Copy link
Member Author

This issue is obsolete as we're replacing SUIR with MUI. See #9796.

@github-project-automation github-project-automation bot moved this from Blocked by other issue or time to Merged in Quality-time backlog Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tech Technical change without significant user impact
Projects
None yet
Milestone
No milestone
1 participant
@fniessink