Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After reload report page, form fields are writable without permissions #2373

Closed
emdv88 opened this issue Jul 15, 2021 · 0 comments · Fixed by #2374
Closed

After reload report page, form fields are writable without permissions #2373

emdv88 opened this issue Jul 15, 2021 · 0 comments · Fixed by #2374
Assignees

Comments

@emdv88
Copy link
Contributor

emdv88 commented Jul 15, 2021

Steps to reproduce:

  • log in as a user without edit report permission
  • navigate to a report
  • reload page
  • All form fields are now writable, but the changes will have no effect because the api correctly returns a 403

This bug occurs because in App.js the reload_reports function is never called when the page is loaded directly on a specific report.
Possible solution: in reload_report, also make a call to the reports_overview api endpoint. Possibly store that data in a context provider, along with the datamodel and the permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant