Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snyk Parser should consolidate findings better #1616

Closed
greckko opened this issue Oct 27, 2020 · 3 comments · Fixed by #1641
Closed

Snyk Parser should consolidate findings better #1616

greckko opened this issue Oct 27, 2020 · 3 comments · Fixed by #1641
Labels
Source(s) New, enhanced, or removed metric source

Comments

@greckko
Copy link
Contributor

greckko commented Oct 27, 2020

2020-10-27 13_08_00-Window

Currently the Snyk parser does not consolidate findings correctly. This results in an enormous amount of warnings.

The number of warnings should be equal to the number of top-level packages that need to be updated not the total amount of vulnerabilities

@greckko greckko changed the title Snyk should consolidate findings better Snyk Parser should consolidate findings better Oct 27, 2020
@greckko
Copy link
Contributor Author

greckko commented Oct 29, 2020

This is what I aim to achieve. Instead of 1211 Security Warnings, It now only shows 4 top level packages that all contain 1211 vulnerabilities sourcing from transitive dependencies.

2020-10-29 08_59_44-Window

For a developer it's easy to review that only 4 packages will need to be updated in order to mitigate 1211 vulnerabilities.

@fniessink what do you think ?

@fniessink
Copy link
Member

fniessink commented Oct 30, 2020

I think it's a good idea, and it's similar to how the OWASP dependency check security warnings are reported: per direct dependency the highest severity and the number of vulnerable (direct and indirect) dependencies.

@fniessink fniessink added Feature New, enhanced, or removed feature Source(s) New, enhanced, or removed metric source and removed Feature New, enhanced, or removed feature labels Oct 30, 2020
@greckko
Copy link
Contributor Author

greckko commented Nov 3, 2020

2020-11-03 18_53_14-Window

#1641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source(s) New, enhanced, or removed metric source
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants