Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: open source links in new window/tab #1203

Closed
Erik-Stel opened this issue Jun 4, 2020 · 1 comment · Fixed by #1202
Closed

Feature request: open source links in new window/tab #1203

Erik-Stel opened this issue Jun 4, 2020 · 1 comment · Fixed by #1202
Labels
Feature New, enhanced, or removed feature

Comments

@Erik-Stel
Copy link
Contributor

Opening source links in the same window will, when returning to QT using the back-button, result in coming back to the main QT screen. This means losing the focus of your work.

I added a PR #1202 for this issue.

@fniessink fniessink added the Feature New, enhanced, or removed feature label Jun 4, 2020
@fniessink
Copy link
Member

WCAG recommends to be conservative with links opening in new windows (see https://www.w3.org/TR/WCAG20-TECHS/G200.html). There are two exceptions, one of which reads: "Opening a page containing context-sensitive information, such as help instructions, or an alternate means of completing a form, such as a calendar-based date picker, will significantly disrupt a multi-step workflow, such as filling in and submitting a form, if the page is opened in the same window or tab." I guess you could (and would) argue that a source link provides context-sensitive information, as in detail information of a metric that you're looking at. Okay, let's do this.

@fniessink fniessink linked a pull request Jun 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New, enhanced, or removed feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants