Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG element can have any role #346

Closed
carmacleod opened this issue Mar 10, 2021 · 4 comments
Closed

SVG element can have any role #346

carmacleod opened this issue Mar 10, 2021 · 4 comments
Assignees
Labels
Bug Something isn't working engine Issues in the accessibility-checker-engine component

Comments

@carmacleod
Copy link
Contributor

carmacleod commented Mar 10, 2021

New: Allow any role on SVG w3c/html-aria#264

Spec: https://w3c.github.io/html-aria/#el-svg

Test cases: https://w3c.github.io/html-aria/tests/svg-test.html

@carmacleod carmacleod added the Bug Something isn't working label Mar 10, 2021
@tombrunet tombrunet added the engine Issues in the accessibility-checker-engine component label Apr 21, 2021
@MHoov
Copy link

MHoov commented Jun 1, 2021

As of June 1

  • general rule description (SME & Dev)
  • testcases written (Dev)
  • rule developed / bug (Dev)
  • message written (SME)
  • help written (SME)

@tombrunet
Copy link
Member

@carmacleod I believe this is fixed... when I look at the rules triggering when I focus on the testcase element:
image
These are errors about missing required attributes and nesting, but it seems to allow all of the roles to me. If you agree, please close.

@tombrunet tombrunet self-assigned this Dec 6, 2021
@carmacleod
Copy link
Contributor Author

Agreed that this is fixed. The fix is here: https://github.com/IBMa/equal-access/blob/master/accessibility-checker-engine/src/v2/aria/ARIADefinitions.ts#L1990

There's a weird problem I noticed, though - Checker doesn't select the svg elements in the Elements panel when I click on a violation. Not sure what's up with that. I can open a new issue, so that you can close this one.

@tombrunet
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working engine Issues in the accessibility-checker-engine component
Projects
None yet
Development

No branches or pull requests

3 participants