From b20187b0f9ebb2da454e317dc3956f13903adfe1 Mon Sep 17 00:00:00 2001 From: Shunguo Date: Tue, 23 Apr 2024 11:37:35 -0500 Subject: [PATCH 1/8] update the rules, test cases and help files #1834 --- .../help-v4/en-US/meta_viewport_zoomable.html | 1 - .../src/v4/rules/a_text_purpose.ts | 18 ++++++------- .../src/v4/rules/meta_viewport_zoomable.ts | 27 +++++++------------ .../a_text_purpose_ruleunit/A-nonTabable.html | 10 +++---- .../A-slot-text-error1.html | 4 +-- .../A-slot-text-error2.html | 4 +-- .../A-slot-text-pass.html | 4 +-- .../A-slot-text-pass1.html | 4 +-- .../Hyperlinks_img.html | 4 +-- .../a_text_purpose_ruleunit/a-with-slot.html | 2 +- .../a_text_purpose_ruleunit/svg-title.html | 4 +-- .../a_text_purpose_ruleunit/webComponent.html | 2 +- .../viewport_fail_maximum_user_scale_1.0.html | 2 +- .../viewport_fail_maximum_user_scale_1.5.html | 2 +- ...wport_fail_unknown_maximum_user_scale.html | 2 +- .../viewport_fail_user_scale_no.html | 2 +- .../viewport_fail_yes_maximum_user_scale.html | 2 +- .../viewport_pass_allow_user_scale.html | 2 +- ...iewport_pass_enough_maxium_user_scale.html | 2 +- ...wport_pass_ignored_maximum_user_scale.html | 2 +- 20 files changed, 46 insertions(+), 54 deletions(-) diff --git a/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html b/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html index 1bfcfaa20..96ad8301f 100644 --- a/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html +++ b/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html @@ -76,7 +76,6 @@

### About this requirement * [IBM 1.4.4 Resize text](https://www.ibm.com/able/requirements/requirements/#1_4_4) -* [IBM 1.4.10 Reflow](https://www.ibm.com/able/requirements/requirements/#1_4_10) * [ACT rule: meta viewport allows for zoom](https://act-rules.github.io/rules/b4f0c3) ### Who does this affect? diff --git a/accessibility-checker-engine/src/v4/rules/a_text_purpose.ts b/accessibility-checker-engine/src/v4/rules/a_text_purpose.ts index 4dfab036c..1e5b25e43 100644 --- a/accessibility-checker-engine/src/v4/rules/a_text_purpose.ts +++ b/accessibility-checker-engine/src/v4/rules/a_text_purpose.ts @@ -12,7 +12,7 @@ *****************************************************************************/ import { ARIAMapper } from "../../v2/aria/ARIAMapper"; -import { Rule, RuleResult, RuleFail, RuleContext, RulePotential, RuleManual, RulePass, RuleContextHierarchy } from "../api/IRule"; +import { Rule, RuleResult, RuleFail, RuleContext, RulePass } from "../api/IRule"; import { RPTUtil } from "../../v2/checker/accessibility/util/legacy"; import { VisUtil } from "../../v2/dom/VisUtil"; import { eRulePolicy, eToolkitLevel } from "../api/IRule"; @@ -23,22 +23,22 @@ export let a_text_purpose: Rule = { context: "aria:link,aria:doc-biblioref", refactor: { "WCAG20_A_HasText": { - "Pass_0": "Pass_0", - "Fail_1": "Fail_1" + "Pass_0": "pass", + "Fail_1": "fail_acc_name" } }, help: { "en-US": { "group": `a_text_purpose.html`, - "Pass_0": `a_text_purpose.html`, - "Fail_1": `a_text_purpose.html` + "pass": `a_text_purpose.html`, + "fail_acc_name": `a_text_purpose.html` } }, messages: { "en-US": { "group": "Hyperlinks must have an accessible name for their purpose", - "Pass_0": "Hyperlink has a description of its purpose", - "Fail_1": "Hyperlink has no link text, label or image with a text alternative" + "pass": "Hyperlink has a description of its purpose", + "fail_acc_name": "Hyperlink has no link text, label or image with a text alternative" } }, rulesets: [{ @@ -62,9 +62,9 @@ export let a_text_purpose: Rule = { ARIAMapper.computeName(ruleContext).trim().length > 0 || RPTUtil.nonTabableChildCheck(ruleContext); if (!passed) { - return RuleFail("Fail_1"); + return RuleFail("fail_acc_name"); } else { - return RulePass("Pass_0"); + return RulePass("pass"); } } } diff --git a/accessibility-checker-engine/src/v4/rules/meta_viewport_zoomable.ts b/accessibility-checker-engine/src/v4/rules/meta_viewport_zoomable.ts index d323ce576..aae28cbdf 100644 --- a/accessibility-checker-engine/src/v4/rules/meta_viewport_zoomable.ts +++ b/accessibility-checker-engine/src/v4/rules/meta_viewport_zoomable.ts @@ -11,31 +11,30 @@ limitations under the License. *****************************************************************************/ -import { Rule, RuleResult, RuleFail, RuleContext, RulePotential, RuleManual, RulePass, RuleContextHierarchy } from "../api/IRule"; +import { Rule, RuleResult, RuleContext, RulePotential, RulePass, RuleContextHierarchy } from "../api/IRule"; import { eRulePolicy, eToolkitLevel } from "../api/IRule"; -import { RPTUtil } from "../../v2/checker/accessibility/util/legacy"; export let meta_viewport_zoomable: Rule = { id: "meta_viewport_zoomable", context: "dom:meta[name][content]", refactor: { "meta_viewport_zoom": { - "Pass_0": "Pass_0", - "Potential_1": "Potential_1" + "Pass_0": "pass", + "Potential_1": "potential_zoomable" } }, help: { "en-US": { "group": "meta_viewport_zoomable.html", - "Pass_0": "meta_viewport_zoomable.html", - "Potential_1": "meta_viewport_zoomable.html" + "pass": "meta_viewport_zoomable.html", + "potential_zoomable": "meta_viewport_zoomable.html" } }, messages: { "en-US": { "group": "The 'meta[name=viewport]' should not prevent the browser zooming the content", - "Pass_0": "The 'meta[name=viewport]' does not prevent the browser zooming the content", - "Potential_1": "Confirm the 'meta[name=viewport]' with \"{0}\" can be zoomed by user" + "pass": "The 'meta[name=viewport]' does not prevent the browser zooming the content", + "potential_zoomable": "Confirm the 'meta[name=viewport]' with \"{0}\" can be zoomed by user" } }, rulesets: [{ @@ -43,12 +42,6 @@ export let meta_viewport_zoomable: Rule = { "num": ["1.4.4"], "level": eRulePolicy.RECOMMENDATION, "toolkitLevel": eToolkitLevel.LEVEL_THREE - }, - { - "id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_2"], - "num": ["1.4.10"], - "level": eRulePolicy.RECOMMENDATION, - "toolkitLevel": eToolkitLevel.LEVEL_THREE }], act: [{ "b4f0c3": { @@ -107,12 +100,12 @@ export let meta_viewport_zoomable: Rule = { // user-scalable is not set to 'yes', ignore maximum_scale if (user_scale_value !== 'yes') { - return RulePotential("Potential_1", [user_msg]); + return RulePotential("potential_zoomable", [user_msg]); } // user-scalable is 'yes', but maximum_scale is too small if (maximum_scale < 2.0) { - return RulePotential("Potential_1", [max_msg]); + return RulePotential("potential_zoomable", [max_msg]); } - return RulePass("Pass_0"); + return RulePass("pass"); } } \ No newline at end of file diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-nonTabable.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-nonTabable.html index cb7dfc28e..309b70edd 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-nonTabable.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-nonTabable.html @@ -83,7 +83,7 @@

"dom": "/html[1]/body[1]/a[1]", "aria": "/document[1]/link[1]" }, - "reasonId": "Fail_1", + "reasonId": "fail_acc_name", //"message": "Hyperlink is missing link text or an image with alt text.", "message": "Hyperlink has no link text, label or image with a text alternative", "messageArgs": [], @@ -98,7 +98,7 @@

"dom": "/html[1]/body[1]/a[2]", "aria": "/document[1]/link[2]" }, - "reasonId": "Pass_0", + "reasonId": "pass", //"message": "Hyperlink contains content that is readable by assistive technologies.", "message": "Hyperlink has a description of its purpose", "messageArgs": [], @@ -113,7 +113,7 @@

"dom": "/html[1]/body[1]/a[3]", "aria": "/document[1]/link[3]" }, - "reasonId": "Fail_1", + "reasonId": "fail_acc_name", //"message": "Hyperlink is missing link text or an image with alt text.", "message": "Hyperlink has no link text, label or image with a text alternative", "messageArgs": [], @@ -128,7 +128,7 @@

"dom": "/html[1]/body[1]/a[4]", "aria": "/document[1]/link[4]" }, - "reasonId": "Fail_1", + "reasonId": "fail_acc_name", //"message": "Hyperlink is missing link text or an image with alt text.", "message": "Hyperlink has no link text, label or image with a text alternative", "messageArgs": [], @@ -143,7 +143,7 @@

"dom": "/html[1]/body[1]/a[5]", "aria": "/document[1]/link[5]" }, - "reasonId": "Pass_0", + "reasonId": "pass", //"message": "Hyperlink contains content that is readable by assistive technologies.", "message": "Hyperlink has a description of its purpose", "messageArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error1.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error1.html index c8a2cc0b3..aedd0c022 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error1.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error1.html @@ -42,7 +42,7 @@ "dom": "/html[1]/body[1]/main[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], @@ -58,7 +58,7 @@ "dom": "/html[1]/body[1]/main[1]/div[2]/#document-fragment[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[2]" }, - "reasonId": "Fail_1", + "reasonId": "fail_acc_name", "message": "Hyperlink has no link text, label or image with a text alternative", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error2.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error2.html index 2c96cd71b..03444d814 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error2.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-error2.html @@ -43,7 +43,7 @@ "dom": "/html[1]/body[1]/main[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], @@ -59,7 +59,7 @@ "dom": "/html[1]/body[1]/main[1]/div[2]/#document-fragment[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[2]" }, - "reasonId": "Fail_1", + "reasonId": "fail_acc_name", "message": "Hyperlink has no link text, label or image with a text alternative", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass.html index e5c591799..272d448b9 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass.html @@ -44,7 +44,7 @@ "dom": "/html[1]/body[1]/main[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], @@ -60,7 +60,7 @@ "dom": "/html[1]/body[1]/main[1]/div[2]/#document-fragment[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[2]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass1.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass1.html index 38e4eb80d..e500b14c9 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass1.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/A-slot-text-pass1.html @@ -44,7 +44,7 @@ "dom": "/html[1]/body[1]/main[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], @@ -60,7 +60,7 @@ "dom": "/html[1]/body[1]/main[1]/div[2]/#document-fragment[1]/div[1]/a[1]", "aria": "/document[1]/main[1]/link[2]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/Hyperlinks_img.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/Hyperlinks_img.html index a10d8c0fe..e84171c4a 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/Hyperlinks_img.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/Hyperlinks_img.html @@ -57,7 +57,7 @@ "dom": "/html[1]/body[1]/a[1]", "aria": "/document[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", //"message": "Hyperlink contains content that is readable by assistive technologies.", "message": "Hyperlink has a description of its purpose", "messageArgs": [], @@ -70,7 +70,7 @@ "dom": "/html[1]/body[1]/a[2]", "aria": "/document[1]/link[2]" }, - "reasonId": "Pass_0", + "reasonId": "pass", //"message": "Hyperlink contains content that is readable by assistive technologies.", "message": "Hyperlink has a description of its purpose", "messageArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/a-with-slot.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/a-with-slot.html index c1a2eaf9f..ce60ad6e8 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/a-with-slot.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/a-with-slot.html @@ -46,7 +46,7 @@

Test page

"dom": "/html[1]/body[1]/main[1]/my-link[1]/#document-fragment[1]/a[1]", "aria": "/document[1]/main[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/svg-title.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/svg-title.html index 39de31992..87196547d 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/svg-title.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/svg-title.html @@ -57,7 +57,7 @@ "dom": "/html[1]/body[1]/header[1]/a[1]", "aria": "/document[1]/banner[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], @@ -73,7 +73,7 @@ "dom": "/html[1]/body[1]/header[2]/a[1]", "aria": "/document[1]/banner[2]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/webComponent.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/webComponent.html index 8ed3e632c..8f5a7d68c 100644 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/webComponent.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/a_text_purpose_ruleunit/webComponent.html @@ -46,7 +46,7 @@

Test page

"dom": "/html[1]/body[1]/main[1]/my-link[1]/#document-fragment[1]/a[1]", "aria": "/document[1]/main[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.0.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.0.html index 4f54573cc..248e0b1de 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.0.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.0.html @@ -42,7 +42,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Potential_1", + "reasonId": "potential_zoomable", "message": "Confirm the 'meta[name=viewport]' with \"maximum-scale=1.0\" can be zoomed by user", "messageArgs": [ "maximum-scale=1.0" diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.5.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.5.html index 5e0d44902..bba8b66c6 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.5.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_maximum_user_scale_1.5.html @@ -41,7 +41,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Potential_1", + "reasonId": "potential_zoomable", "message": "Confirm the 'meta[name=viewport]' with \" maximum-scale=1.5\" can be zoomed by user", "messageArgs": [ " maximum-scale=1.5" diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_unknown_maximum_user_scale.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_unknown_maximum_user_scale.html index 16d2dcec8..2fb3842b9 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_unknown_maximum_user_scale.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_unknown_maximum_user_scale.html @@ -41,7 +41,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Potential_1", + "reasonId": "potential_zoomable", "message": "Confirm the 'meta[name=viewport]' with \"maximum-scale=ok\" can be zoomed by user", "messageArgs": [ "maximum-scale=ok" diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_user_scale_no.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_user_scale_no.html index 4c39b222b..a536d0119 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_user_scale_no.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_user_scale_no.html @@ -41,7 +41,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Potential_1", + "reasonId": "potential_zoomable", "message": "Confirm the 'meta[name=viewport]' with \"user-scalable=no\" can be zoomed by user", "messageArgs": [ "user-scalable=no" diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_yes_maximum_user_scale.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_yes_maximum_user_scale.html index bb734a7a8..3351c613d 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_yes_maximum_user_scale.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_fail_yes_maximum_user_scale.html @@ -42,7 +42,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Potential_1", + "reasonId": "potential_zoomable", "message": "Confirm the 'meta[name=viewport]' with \"maximum-scale=yes\" can be zoomed by user", "messageArgs": [ "maximum-scale=yes" diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_allow_user_scale.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_allow_user_scale.html index 6bbcb081e..715c994aa 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_allow_user_scale.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_allow_user_scale.html @@ -41,7 +41,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "The 'meta[name=viewport]' does not prevent the browser zooming the content", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_enough_maxium_user_scale.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_enough_maxium_user_scale.html index 711080142..85e5d1187 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_enough_maxium_user_scale.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_enough_maxium_user_scale.html @@ -41,7 +41,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "The 'meta[name=viewport]' does not prevent the browser zooming the content", "messageArgs": [], "apiArgs": [], diff --git a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_ignored_maximum_user_scale.html b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_ignored_maximum_user_scale.html index ee32fb527..134a2be9c 100755 --- a/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_ignored_maximum_user_scale.html +++ b/accessibility-checker-engine/test/v2/checker/accessibility/rules/meta_viewport_zoomable_ruleunit/viewport_pass_ignored_maximum_user_scale.html @@ -41,7 +41,7 @@ "dom": "/html[1]/head[1]/meta[2]", "aria": "/document[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "The 'meta[name=viewport]' does not prevent the browser zooming the content", "messageArgs": [], "apiArgs": [], From 070dd7597687a26e9daba785ebabbb4e848efa1c Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Wed, 24 Apr 2024 13:29:04 -0500 Subject: [PATCH 2/8] map to 2.1.1 see issue #1834 --- .../src/v4/rules/widget_tabbable_exists.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accessibility-checker-engine/src/v4/rules/widget_tabbable_exists.ts b/accessibility-checker-engine/src/v4/rules/widget_tabbable_exists.ts index 38d50b61d..9174b58f8 100644 --- a/accessibility-checker-engine/src/v4/rules/widget_tabbable_exists.ts +++ b/accessibility-checker-engine/src/v4/rules/widget_tabbable_exists.ts @@ -41,7 +41,7 @@ export let widget_tabbable_exists: Rule = { }, rulesets: [{ "id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"], - "num": ["2.4.3"], + "num": ["2.1.1"], "level": eRulePolicy.VIOLATION, "toolkitLevel": eToolkitLevel.LEVEL_ONE }], @@ -87,4 +87,4 @@ export let widget_tabbable_exists: Rule = { let passed = count >= 1; return passed ? RulePass("pass") : RulePotential("fail_no_tabbable", [role]); } -} \ No newline at end of file +} From 7628594017af0b2a8eb078849e36e66979abbf49 Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Wed, 24 Apr 2024 13:35:24 -0500 Subject: [PATCH 3/8] add map to 2.1.1 see #1834 --- .../src/v4/rules/widget_tabbable_single.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accessibility-checker-engine/src/v4/rules/widget_tabbable_single.ts b/accessibility-checker-engine/src/v4/rules/widget_tabbable_single.ts index c0ca94553..04de68b81 100644 --- a/accessibility-checker-engine/src/v4/rules/widget_tabbable_single.ts +++ b/accessibility-checker-engine/src/v4/rules/widget_tabbable_single.ts @@ -43,7 +43,7 @@ export let widget_tabbable_single: Rule = { }, rulesets: [{ "id": ["IBM_Accessibility", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"], - "num": ["2.4.3"], + "num": ["2.1.1", "2.4.3"], "level": eRulePolicy.VIOLATION, "toolkitLevel": eToolkitLevel.LEVEL_ONE }], @@ -79,4 +79,4 @@ export let widget_tabbable_single: Rule = { setCache(ruleContext, "widget_tabbable_single", "fail_multiple_tabbable"); return passed ? RulePass("pass") : RulePotential("fail_multiple_tabbable", [role]); } -} \ No newline at end of file +} From 818e0856605183ace589e79a00e6f2e4b86ba4b5 Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Wed, 24 Apr 2024 13:57:45 -0500 Subject: [PATCH 4/8] add 2.4.3 Focus Order mapping see #1834 --- .../help-v4/en-US/widget_tabbable_single.html | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html b/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html index 59a1e8ca0..0f797b82d 100644 --- a/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html +++ b/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html @@ -47,7 +47,8 @@

The primary keyboard navigation convention uses `Tab` and `Shift+Tab` keys to move focus from one UI component to another. Other keys (primarily the arrow keys) move focus within components comprised of multiple focusable elements. -Authors must follow this convention and provide no more than one tab stop per component (providing keyboard focus). +Authors must follow this convention and provide no more than one tab stop per component (providing keyboard focus) and insure the keyboard tab sequence is logical. +In addition, the keyboard operations should be consistent with common keyboard interface conventions described in the [ARIA Patterns](https://www.w3.org/WAI/ARIA/apg/patterns/), especially for assistive technology users.
@@ -68,6 +69,8 @@

### About this requirement * [IBM 2.1.1 Keyboard](https://www.ibm.com/able/requirements/requirements/#2_1_1) +* [IBM 2.4.3 Focus Order](https://www.ibm.com/able/requirements/requirements/#2_4_3) +* [ARIA practices - Patterns](https://www.w3.org/WAI/ARIA/apg/patterns/) * [ARIA practices - Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) ### Who does this affect? From a138030ee1b9957845352815e7fd6d0381318608 Mon Sep 17 00:00:00 2001 From: Shunguo Date: Wed, 24 Apr 2024 14:38:37 -0500 Subject: [PATCH 5/8] update the baselines #1834 --- .../JSONObjectStructureVerification.html.json | 74 +++++++++---------- ...ectStructureVerificationSelenium.html.json | 10 +-- ...nce.JSONObjectVerificationSelenium.test.js | 2 +- 3 files changed, 43 insertions(+), 43 deletions(-) diff --git a/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json b/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json index 7bb063c6c..ff8e8d0e7 100644 --- a/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json +++ b/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json @@ -320,7 +320,7 @@ "category": "Accessibility", "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "ruleId": "img_alt_background", @@ -468,7 +468,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -494,7 +494,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -520,7 +520,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -549,7 +549,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -575,7 +575,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -601,7 +601,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -627,7 +627,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -653,7 +653,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -679,7 +679,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -705,7 +705,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 143, + "top": 144, "height": 0, "width": 784 }, @@ -1021,7 +1021,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1047,7 +1047,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1073,7 +1073,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1099,7 +1099,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1133,14 +1133,14 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", "category": "Accessibility", "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "ruleId": "style_focus_visible", @@ -1159,7 +1159,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1185,7 +1185,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1211,7 +1211,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1237,7 +1237,7 @@ "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", @@ -1256,21 +1256,21 @@ "dom": "/html[1]/body[1]/div[1]/a[1]", "aria": "/document[1]/navigation[1]/link[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "message": "Hyperlink has a description of its purpose", "messageArgs": [], "apiArgs": [], "bounds": { "left": 8, "top": 8, - "height": 17, + "height": 18, "width": 56 }, "snippet": "", "category": "Accessibility", "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/a_text_purpose.html#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22Pass_0%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doca_text_purpose_pass#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" }, { "ruleId": "text_whitespace_valid", @@ -1289,7 +1289,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1315,7 +1315,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1341,7 +1341,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1370,7 +1370,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1396,7 +1396,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1422,7 +1422,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1448,7 +1448,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 19, "width": 784 }, "snippet": "
", @@ -1604,7 +1604,7 @@ "bounds": { "left": 0, "top": 0, - "height": 143, + "height": 144, "width": 800 }, "snippet": "", @@ -1630,7 +1630,7 @@ "bounds": { "left": 0, "top": 0, - "height": 143, + "height": 144, "width": 800 }, "snippet": "", @@ -1656,7 +1656,7 @@ "bounds": { "left": 0, "top": 0, - "height": 143, + "height": 144, "width": 800 }, "snippet": "", @@ -1682,7 +1682,7 @@ "bounds": { "left": 0, "top": 0, - "height": 143, + "height": 144, "width": 800 }, "snippet": "", @@ -1710,7 +1710,7 @@ "bounds": { "left": 0, "top": 0, - "height": 143, + "height": 144, "width": 800 }, "snippet": "", @@ -1797,7 +1797,7 @@ }, "a_text_purpose": { "0": "Hyperlinks must have an accessible name for their purpose", - "Pass_0": "Hyperlink has a description of its purpose" + "pass": "Hyperlink has a description of its purpose" }, "widget_tabbable_exists": { "0": "Component must have at least one tabbable element", diff --git a/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json b/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json index 8c90727d2..faa622bd0 100644 --- a/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json +++ b/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json @@ -2,7 +2,7 @@ "nls": { "a_text_purpose": { "0": "Hyperlinks must have an accessible name for their purpose", - "Pass_0": "Hyperlink has a description of its purpose" + "pass": "Hyperlink has a description of its purpose" }, "aria_accessiblename_exists": { "0": "Elements with certain roles should have accessible names", @@ -424,7 +424,7 @@ ], "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "apiArgs": [], @@ -1244,7 +1244,7 @@ ], "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "apiArgs": [], @@ -1365,7 +1365,7 @@ "aria": "/document[1]/navigation[1]/link[1]", "dom": "/html[1]/body[1]/div[1]/a[1]" }, - "reasonId": "Pass_0", + "reasonId": "pass", "ruleId": "a_text_purpose", "snippet": "", "value": [ @@ -1374,7 +1374,7 @@ ], "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/a_text_purpose.html#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22Pass_0%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doca_text_purpose_pass#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" }, { "apiArgs": [], diff --git a/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js b/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js index 9a95cb28c..5144e963b 100644 --- a/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js +++ b/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js @@ -181,7 +181,7 @@ describe("JSON Structure Verification Selenium", function () { return b.ruleId.localeCompare(a.ruleId); }) // Run the diff algo to get the list of differences - differences = aChecker.diffResultsWithExpected(report, expected, false); + differences = aChecker.diffResultsWithExpected(report, expected, false);console.log("report=" + JSON.stringify(report)); } expect(typeof differences).to.equal("undefined", "\nDoes not follow the correct JSON structure or can't load baselines" + JSON.stringify(differences, null, ' ')); From c132c444932eb832f1f0348c1ba4e204d1dcd3a9 Mon Sep 17 00:00:00 2001 From: Shunguo Date: Wed, 24 Apr 2024 14:51:36 -0500 Subject: [PATCH 6/8] update the baseline results #1834 --- .../JSONObjectStructureVerification.html.json | 70 +++++++++---------- ...ectStructureVerificationSelenium.html.json | 6 +- ...tCompliance.JSONObjectVerification.test.js | 2 +- ...nce.JSONObjectVerificationSelenium.test.js | 2 +- 4 files changed, 40 insertions(+), 40 deletions(-) diff --git a/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json b/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json index ff8e8d0e7..15073d5b7 100644 --- a/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json +++ b/accessibility-checker/test/baselines/JSONObjectStructureVerification.html.json @@ -320,7 +320,7 @@ "category": "Accessibility", "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "ruleId": "img_alt_background", @@ -468,7 +468,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -494,7 +494,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -520,7 +520,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -549,7 +549,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -575,7 +575,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -601,7 +601,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -627,7 +627,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -653,7 +653,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -679,7 +679,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -705,7 +705,7 @@ "apiArgs": [], "bounds": { "left": 8, - "top": 144, + "top": 143, "height": 0, "width": 784 }, @@ -1021,7 +1021,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1047,7 +1047,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1073,7 +1073,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1099,7 +1099,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1133,14 +1133,14 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", "category": "Accessibility", "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "ruleId": "style_focus_visible", @@ -1159,7 +1159,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1185,7 +1185,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1211,7 +1211,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1237,7 +1237,7 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", @@ -1263,14 +1263,14 @@ "bounds": { "left": 8, "top": 8, - "height": 18, + "height": 17, "width": 56 }, "snippet": "", "category": "Accessibility", "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doca_text_purpose_pass#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/a_text_purpose.html#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" }, { "ruleId": "text_whitespace_valid", @@ -1289,7 +1289,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1315,7 +1315,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1341,7 +1341,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1370,7 +1370,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1396,7 +1396,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1422,7 +1422,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1448,7 +1448,7 @@ "bounds": { "left": 8, "top": 8, - "height": 19, + "height": 18, "width": 784 }, "snippet": "
", @@ -1604,7 +1604,7 @@ "bounds": { "left": 0, "top": 0, - "height": 144, + "height": 143, "width": 800 }, "snippet": "", @@ -1630,7 +1630,7 @@ "bounds": { "left": 0, "top": 0, - "height": 144, + "height": 143, "width": 800 }, "snippet": "", @@ -1656,7 +1656,7 @@ "bounds": { "left": 0, "top": 0, - "height": 144, + "height": 143, "width": 800 }, "snippet": "", @@ -1682,7 +1682,7 @@ "bounds": { "left": 0, "top": 0, - "height": 144, + "height": 143, "width": 800 }, "snippet": "", @@ -1710,7 +1710,7 @@ "bounds": { "left": 0, "top": 0, - "height": 144, + "height": 143, "width": 800 }, "snippet": "", diff --git a/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json b/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json index faa622bd0..3caffcc3d 100644 --- a/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json +++ b/accessibility-checker/test/baselines/JSONObjectStructureVerificationSelenium.html.json @@ -424,7 +424,7 @@ ], "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ch1%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%2221.00%22%2C32%2C700%2C%22%23000000%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "apiArgs": [], @@ -1244,7 +1244,7 @@ ], "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doctext_contrast_sufficient_pass#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/text_contrast_sufficient.html#%7B%22message%22%3A%22The%20contrast%20ratio%20of%20text%20with%20its%20background%20meets%20WCAG%20AA%20requirements%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22text_contrast_sufficient%22%2C%22msgArgs%22%3A%5B%229.40%22%2C16%2C400%2C%22%230000ee%22%2C%22%23ffffff%22%2Cfalse%2Cfalse%5D%7D" }, { "apiArgs": [], @@ -1374,7 +1374,7 @@ ], "ignored": false, "level": "pass", - "help": "https://able.ibm.com/rules/archives/preview/doca_text_purpose_pass#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" + "help": "https://able.ibm.com/rules/archives/preview/doc/en-US/a_text_purpose.html#%7B%22message%22%3A%22Hyperlink%20has%20a%20description%20of%20its%20purpose%22%2C%22snippet%22%3A%22%3Ca%20alt%3D%5C%22skip%20to%20main%20content%5C%22%20href%3D%5C%22%23navskip%5C%22%3E%22%2C%22value%22%3A%5B%22VIOLATION%22%2C%22PASS%22%5D%2C%22reasonId%22%3A%22pass%22%2C%22ruleId%22%3A%22a_text_purpose%22%2C%22msgArgs%22%3A%5B%5D%7D" }, { "apiArgs": [], diff --git a/accessibility-checker/test/mocha/aChecker.Fast/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerification.test.js b/accessibility-checker/test/mocha/aChecker.Fast/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerification.test.js index 7269c8405..8df075f4a 100644 --- a/accessibility-checker/test/mocha/aChecker.Fast/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerification.test.js +++ b/accessibility-checker/test/mocha/aChecker.Fast/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerification.test.js @@ -127,7 +127,7 @@ describe("JSON Structure Verification Zombie", function () { return b.ruleId.localeCompare(a.ruleId); }) // Run the diff algo to get the list of differences - differences = aChecker.diffResultsWithExpected(report, expected, false);console.log("report=" + JSON.stringify(report)); + differences = aChecker.diffResultsWithExpected(report, expected, false); } expect(typeof differences).to.equal("undefined", "\nDoes not follow the correct JSON structure or can't load baselines" + JSON.stringify(differences, null, ' ')); // Mark the testcase as done. diff --git a/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js b/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js index 5144e963b..9a95cb28c 100644 --- a/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js +++ b/accessibility-checker/test/mocha/aChecker.Slow1/aChecker.ObjectStructure/aChecker.getCompliance.JSONObjectVerificationSelenium.test.js @@ -181,7 +181,7 @@ describe("JSON Structure Verification Selenium", function () { return b.ruleId.localeCompare(a.ruleId); }) // Run the diff algo to get the list of differences - differences = aChecker.diffResultsWithExpected(report, expected, false);console.log("report=" + JSON.stringify(report)); + differences = aChecker.diffResultsWithExpected(report, expected, false); } expect(typeof differences).to.equal("undefined", "\nDoes not follow the correct JSON structure or can't load baselines" + JSON.stringify(differences, null, ' ')); From 9807ce04821195cd8784d84a4212eae0834521ed Mon Sep 17 00:00:00 2001 From: Phill Jenkins Date: Wed, 24 Apr 2024 16:07:07 -0500 Subject: [PATCH 7/8] add Verify references see #1834 --- .../help-v4/en-US/widget_tabbable_single.html | 2 ++ 1 file changed, 2 insertions(+) diff --git a/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html b/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html index 0f797b82d..826ee463e 100644 --- a/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html +++ b/accessibility-checker-engine/help-v4/en-US/widget_tabbable_single.html @@ -72,6 +72,8 @@

* [IBM 2.4.3 Focus Order](https://www.ibm.com/able/requirements/requirements/#2_4_3) * [ARIA practices - Patterns](https://www.w3.org/WAI/ARIA/apg/patterns/) * [ARIA practices - Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) +* [Verify - Check tab or navigation order](https://www.ibm.com/able/toolkit/verify/manual/#tabnavorder) +* [Verify - Maintaining user's point of regard](https://www.ibm.com/able/toolkit/verify/manual/#pointofregard) ### Who does this affect? From 577d78d95fd01d73708767be9799c0b079f26e42 Mon Sep 17 00:00:00 2001 From: Shunguo Date: Mon, 29 Apr 2024 14:31:02 -0500 Subject: [PATCH 8/8] update the help content #1834 --- .../help-v4/en-US/meta_viewport_zoomable.html | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html b/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html index 96ad8301f..d4ce1ebfe 100644 --- a/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html +++ b/accessibility-checker-engine/help-v4/en-US/meta_viewport_zoomable.html @@ -51,9 +51,7 @@

Only users with older mobile browsers can experience issues tested by this rule. This rule is designed specifically for testing [1.4.4 Resize text](https://www.ibm.com/able/requirements/requirements/#1_4_4), -which requires that text can be resized up to 200%. -Because text that cannot be resized up to 200% cannot fit in an area of 320 by 256 CSS pixels, -this rule maps to [1.4.10 Reflow](https://www.ibm.com/able/requirements/requirements/#1_4_10) as well. +which requires that text can be resized up to 200%.