update gokrb5 to v8.4.1 #1762
Closed
update gokrb5 to v8.4.1 #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kmhagan
force-pushed
the
update-gokrb5-version
branch
from
25d7501
to
cf2c8d5
Compare
bai
approved these changes
Jul 25, 2020
|
@bai I’m pretty sure I attempted this upgrade as part of #1626 and had to revert in #1630 because it broke some users. Essentially:
|
|
Oh good point, I missed that one 👍 |
|
I’m happy for us to just start prepping a v2 though 😄 |
|
Looking forward to v2! I'll go ahead and close this PR and in the meantime I'll use my branch to handle this scenario |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This updates gokrb5 dependency to v8.4.1 which fixes an issue I ran into when a KDC server was unresponsive: jcmturner/gokrb5#399