Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh 3rdparty dependencies #1626

Merged
merged 1 commit into from
Feb 24, 2020
Merged

refresh 3rdparty dependencies #1626

merged 1 commit into from
Feb 24, 2020

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Feb 21, 2020

  • move to versioned go modules
  • bump all to latest releases
  • go mod tidy

@dnwe dnwe requested a review from bai as a code owner February 21, 2020 21:39
@dnwe
Copy link
Collaborator Author

dnwe commented Feb 21, 2020

lz4 will get a basic workout as part of functional_consumer_test.go, but it doesn't look like there's any kerberos testing in that suite — we should probably add something to at least do a basic sniff test

@dnwe
refresh 3rdparty dependencies
660e640 
- move to versioned go modules
- bump all to latest releases
- go mod tidy

Signed-off-by: Dominic Evans <[email protected]>
@dnwe dnwe merged commit 6e063e6 into master Feb 24, 2020
@dnwe dnwe deleted the bump-deps branch February 24, 2020 16:07
@Jianli-lin
Copy link

Hey. @dnwe Got this error when go build.
/Shopify/sarama/compress.go:10:2: cannot find package "github.com/pierrec/lz4/v3"
Does this change make it impossible to use this lib without go mod?

@dnwe
Copy link
Collaborator Author

dnwe commented Feb 25, 2020

Yes you're right I'd forgotten that implication of migrating the deps. We should probably revert this until v2 of Sarama. I'll submit a follow up PR later today

@dnwe dnwe mentioned this pull request Feb 25, 2020
Merged
@dnwe dnwe mentioned this pull request Jul 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bai bai bai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnwe @Jianli-lin @bai