Correctly encode RecordBatch.LastOffsetDelta #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code always encodes zero. I'm not sure what the implications are, since consumers are working just fine, but `kafka.tools.DumpLogSegments` reports invalid data where all record batches have the same one record size.
|
Could this be the cause of #1013? |
|
Seems possible, although I can't say for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing code always encodes zero. I'm not sure what the implications are, since consumers are working just fine, but
kafka.tools.DumpLogSegmentsreports invalid data where all record batches have the same one record size.cc @wladh