-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SCSS variables to control included fonts #329
Comments
The IBM Engineering Lifecyle Management (ELM) suite has also hit a size issue with bundling the fonts. At 129M, multiplied by each application in the suite, we've added over 1GB of girth to our download files, as reported in 534224: IBM i LICPGM builds are failing due to unexpected increase in IBMi workbench zip file. |
@tom-poulin The next major version of Plex resolves this, you can try it out at |
@vpicone, is there an ETA for the release of this? |
This is a great font!
I'd like to include it in an Electron app. This means bundling the fonts. Unfortunately, the nice way to import fonts is to go through the
@ibm/plex/scss/ibm-plex.scss
, which will cause every font to be bundled, which has a pretty heavy disk size. There are nested files, but for example I can't import the "light" base font without also importing cyrillic fonts, which I don't need at the moment. And since I'm targeting Electron, I know I don't need.woff
fonts, onlywoff2
.Of course, I could write create webpack rules that stubs the files I don't need via the
null-loader
, but a more graceful way would be appreciated 🙂It would be cool if the imported files were configurable via variables. For example, I could say:
The text was updated successfully, but these errors were encountered: