-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Enterprise Management): update enterprise management sdk after recent api changes #94
Conversation
…e to lack of account creation
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 3041 3041
Branches 393 393
=========================================
Hits 3041 3041
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the comments I made in the Java PR apply here as well. Please update this PR after we've resolved things in the Java PR.
// ENTERPRISE_MANAGEMENT_AUTH_URL=<IAM token service base URL - omit this if using the production environment> | ||
// ENTERPRISE_MANAGEMENT_ENTERPRISE_ID=<ID of the enterprise> | ||
// ENTERPRISE_MANAGEMENT_ACCOUNT_ID=<enterprise account ID> | ||
// ENTERPRISE_MANAGEMENT_ACCOUNT_IAM_ID=<IAM ID of the enterprise account></IAM> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// ENTERPRISE_MANAGEMENT_ACCOUNT_IAM_ID=<IAM ID of the enterprise account></IAM> | |
// ENTERPRISE_MANAGEMENT_ACCOUNT_IAM_ID=<IAM ID of the enterprise account> |
…ervices-node-sdk into update-enterprise-manager
13fa67e
to
f33b6af
Compare
## [0.18.5](v0.18.4...v0.18.5) (2021-04-13) ### Bug Fixes * **Enterprise Management:** update service after recent API changes and add examples ([#94](#94)) ([a6ca662](a6ca662))
🎉 This PR is included in version 0.18.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR summary
This PR updates Enterprise Manager Service SDK after recent Api changes. The PR also introduces new integration tests. These tests cannot cover import account and create enterprise methods due to that they require updated account, which we cannot create programatically at the moment.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information