Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Enterprise Management): update enterprise management sdk after recent api changes #94

Merged
merged 17 commits into from
Apr 13, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Apr 8, 2021

PR summary

This PR updates Enterprise Manager Service SDK after recent Api changes. The PR also introduces new integration tests. These tests cannot cover import account and create enterprise methods due to that they require updated account, which we cannot create programatically at the moment.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi Andras-Csanyi requested a review from padamstx April 8, 2021 18:32
@Andras-Csanyi Andras-Csanyi self-assigned this Apr 8, 2021
@Andras-Csanyi Andras-Csanyi requested a review from pyrooka April 8, 2021 18:32
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #94 (e578d9f) into main (f79d649) will not change coverage.
The diff coverage is n/a.

❗ Current head e578d9f differs from pull request most recent head f33b6af. Consider uploading reports for the commit f33b6af to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3041      3041           
  Branches       393       393           
=========================================
  Hits          3041      3041           
Impacted Files Coverage Δ
enterprise-management/v1.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1159f47...f33b6af. Read the comment docs.

@pyrooka pyrooka changed the title fix(enterprise-manager): update enterprise manager sdk after recent api changes fix(Enterprise Management): update enterprise manager sdk after recent api changes Apr 9, 2021
@pyrooka pyrooka changed the title fix(Enterprise Management): update enterprise manager sdk after recent api changes fix(Enterprise Management): update enterprise management sdk after recent api changes Apr 9, 2021
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments I made in the Java PR apply here as well. Please update this PR after we've resolved things in the Java PR.

// ENTERPRISE_MANAGEMENT_AUTH_URL=<IAM token service base URL - omit this if using the production environment>
// ENTERPRISE_MANAGEMENT_ENTERPRISE_ID=<ID of the enterprise>
// ENTERPRISE_MANAGEMENT_ACCOUNT_ID=<enterprise account ID>
// ENTERPRISE_MANAGEMENT_ACCOUNT_IAM_ID=<IAM ID of the enterprise account></IAM>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// ENTERPRISE_MANAGEMENT_ACCOUNT_IAM_ID=<IAM ID of the enterprise account></IAM>
// ENTERPRISE_MANAGEMENT_ACCOUNT_IAM_ID=<IAM ID of the enterprise account>

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2021

CLA assistant check
All committers have signed the CLA.

@pyrooka pyrooka force-pushed the update-enterprise-manager branch from 13fa67e to f33b6af Compare April 13, 2021 16:51
@padamstx padamstx merged commit a6ca662 into main Apr 13, 2021
@padamstx padamstx deleted the update-enterprise-manager branch April 13, 2021 19:02
ibm-devx-sdk pushed a commit that referenced this pull request Apr 13, 2021
## [0.18.5](v0.18.4...v0.18.5) (2021-04-13)

### Bug Fixes

* **Enterprise Management:** update service after recent API changes and add examples ([#94](#94)) ([a6ca662](a6ca662))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.18.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants