Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resource controller): update sdk after recent api changes #91

Merged
merged 2 commits into from
Mar 31, 2021
Merged

fix(resource controller): update sdk after recent api changes #91

merged 2 commits into from
Mar 31, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Mar 30, 2021 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi Andras-Csanyi self-assigned this Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021 •
edited
Loading

Codecov Report

Merging #91 (450cbaa) into main (ce01276) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 450cbaa differs from pull request most recent head a8d704f. Consider uploading reports for the commit a8d704f to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3021      3030    +9     
  Branches       388       392    +4     
=========================================
+ Hits          3021      3030    +9
Impacted Files Coverage Δ
resource-controller/v2.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce01276...a8d704f. Read the comment docs.

padamstx
padamstx approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit c01a258 into main Mar 31, 2021
@padamstx padamstx deleted the resource-controller-update branch March 31, 2021 12:18
ibm-devx-automation pushed a commit that referenced this pull request Mar 31, 2021
@semantic-release-bot
chore(release): 0.18.1 [skip ci]
aab7292 
## [0.18.1](v0.18.0...v0.18.1) (2021-03-31)

### Bug Fixes

* **resource controller:** update sdk after recent api changes ([#91](#91)) ([c01a258](c01a258))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.18.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

@pyrooka pyrooka Awaiting requested review from pyrooka

Assignees

@Andras-Csanyi Andras-Csanyi

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Andras-Csanyi @ibm-devx-automation @padamstx