Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Policy Management): add restore policy functionality #88

Merged
merged 8 commits into from
Apr 6, 2021
Merged

fix(IAM Policy Management): add restore policy functionality #88

merged 8 commits into from
Apr 6, 2021

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Mar 24, 2021 •
edited
Loading

PR summary

Updating SDK to include new changes from API for PATCH for v1/policies and additional new params.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@swcolley swcolley changed the title Update ipm restore policies fix(IAM Policy Management): add restore policy functionality Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021 •
edited
Loading

Codecov Report

Merging #88 (68fc54f) into main (3d03569) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 68fc54f differs from pull request most recent head 4f73515. Consider uploading reports for the commit 4f73515 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main       #88   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3030      3041   +11     
  Branches       392       393    +1     
=========================================
+ Hits          3030      3041   +11
Impacted Files Coverage Δ
iam-policy-management/v1.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49c39c...4f73515. Read the comment docs.

@swcolley swcolley marked this pull request as ready for review March 31, 2021 13:02
@padamstx padamstx self-assigned this Mar 31, 2021
@padamstx padamstx self-requested a review March 31, 2021 21:47
padamstx
padamstx approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just wondering if we really need the .only() in the examples is all.

examples/iam-policy-management.v1.test.js Outdated Show resolved Hide resolved
@padamstx padamstx merged commit f79d649 into IBM:main Apr 6, 2021
ibm-devx-automation pushed a commit that referenced this pull request Apr 6, 2021
@semantic-release-bot
chore(release): 0.18.4 [skip ci]
6860b5e 
## [0.18.4](v0.18.3...v0.18.4) (2021-04-06)

### Bug Fixes

* **IAM Policy Management:** add restore policy functionality ([#88](#88)) ([f79d649](f79d649))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.18.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swcolley swcolley deleted the update-ipm-restore-policies branch April 6, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guicabr guicabr guicabr left review comments

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swcolley @ibm-devx-automation @padamstx @guicabr