Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Resource Manager): update service after recent API changes and generate examples #84

Merged
merged 11 commits into from
Mar 18, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Mar 8, 2021

PR summary

This PR updates the Resource Manager service, adds examples and move configuration values out from tests into a configuration file.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Andras-Csanyi Andras-Csanyi requested a review from pyrooka March 8, 2021 13:27
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #84 (3a7707c) into main (d284dfc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         2967      2967           
  Branches       378       378           
=========================================
  Hits          2967      2967           
Impacted Files Coverage Δ
resource-manager/v2.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d284dfc...3a7707c. Read the comment docs.

@Andras-Csanyi Andras-Csanyi self-assigned this Mar 9, 2021
@Andras-Csanyi Andras-Csanyi marked this pull request as draft March 10, 2021 13:02
@Andras-Csanyi Andras-Csanyi marked this pull request as ready for review March 16, 2021 09:49
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
test/integration/resource-manager.v2.test.js Outdated Show resolved Hide resolved
test/integration/resource-manager.v2.test.js Outdated Show resolved Hide resolved
test/integration/resource-manager.v2.test.js Outdated Show resolved Hide resolved
test/integration/resource-manager.v2.test.js Outdated Show resolved Hide resolved
test/integration/resource-manager.v2.test.js Outdated Show resolved Hide resolved
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
@Andras-Csanyi Andras-Csanyi requested a review from padamstx March 16, 2021 15:40
@Andras-Csanyi Andras-Csanyi changed the title fix(Resource Manager): update service after recent API changes and generate examples - DRAFT fix(Resource Manager): update service after recent API changes and generate examples Mar 16, 2021
@Andras-Csanyi Andras-Csanyi requested a review from pyrooka March 16, 2021 16:00
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I suggested a few minor changes.

examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
examples/resource-manager.v2.test.js Show resolved Hide resolved
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
examples/resource-manager.v2.test.js Outdated Show resolved Hide resolved
@padamstx padamstx assigned padamstx and unassigned Andras-Csanyi Mar 16, 2021
@Andras-Csanyi Andras-Csanyi requested a review from padamstx March 17, 2021 14:32
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 4d63345 into main Mar 18, 2021
@padamstx padamstx deleted the update-rm branch March 18, 2021 14:33
ibm-devx-automation pushed a commit that referenced this pull request Mar 18, 2021
## [0.17.16](v0.17.15...v0.17.16) (2021-03-18)

### Bug Fixes

* **Resource Manager:** update service after recent API changes and generate examples ([#84](#84)) ([4d63345](4d63345))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants