Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Case Management): re-gen service and add examples #77

Merged
merged 5 commits into from
Feb 18, 2021
Merged

fix(Case Management): re-gen service and add examples #77

merged 5 commits into from
Feb 18, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Feb 17, 2021

PR summary

This PR adds examples to the Case Management service.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx February 17, 2021 12:56
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@6664cb4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #77   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        19           
  Lines           ?      2898           
  Branches        ?       369           
========================================
  Hits            ?      2898           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6664cb4...4b5823f. Read the comment docs.

padamstx
padamstx approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I approved this pre-maturely before I found a way to fix the async response body reading stuff in the global catalog examples :)

padamstx
padamstx requested changes Feb 18, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I found a couple things to address.

examples/case-management.v1.test.js Outdated Show resolved Hide resolved
examples/case-management.v1.test.js Show resolved Hide resolved
padamstx
padamstx approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 34eb26b into main Feb 18, 2021
@padamstx padamstx deleted the update-cm branch February 18, 2021 20:56
ibm-devx-automation pushed a commit that referenced this pull request Feb 18, 2021
@semantic-release-bot
chore(release): 0.17.9 [skip ci]
7fccc58 
## [0.17.9](v0.17.8...v0.17.9) (2021-02-18)

### Bug Fixes

* **Case Management:** re-gen service and add examples ([#77](#77)) ([34eb26b](34eb26b))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyrooka @ibm-devx-automation @padamstx