-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IAM Policy Management): re-gen service and add examples after recent API changes #74
Conversation
Codecov Report
@@ Coverage Diff @@
## main #74 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 19
Lines ? 2898
Branches ? 369
========================================
Hits ? 2898
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just the 1 comment about variable names
|
||
describe('IamPolicyManagementV1', () => { | ||
|
||
let testAccountId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment re: variable names :)
…k into update-ipm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## [0.17.13](v0.17.12...v0.17.13) (2021-02-25) ### Bug Fixes * **IAM Policy Management:** re-gen service and add examples after recent API changes ([#74](#74)) ([9938847](9938847))
🎉 This PR is included in version 0.17.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR summary
This PR includes new service and unit test code plus a new examples file for the IAM Policy Management service.
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information