Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): re-gen service and add examples after recent API changes #74

Merged
merged 14 commits into from
Feb 25, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Jan 22, 2021

PR summary

This PR includes new service and unit test code plus a new examples file for the IAM Policy Management service.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@66b9e65). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #74   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        19           
  Lines           ?      2898           
  Branches        ?       369           
========================================
  Hits            ?      2898           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66b9e65...70c2950. Read the comment docs.

@padamstx padamstx changed the base branch from master to main February 9, 2021 22:32
@padamstx padamstx self-assigned this Feb 16, 2021
Copy link
Member Author

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the 1 comment about variable names


describe('IamPolicyManagementV1', () => {

let testAccountId;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment re: variable names :)

Copy link
Contributor

@guicabr guicabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guicabr guicabr merged commit 9938847 into main Feb 25, 2021
ibm-devx-automation pushed a commit that referenced this pull request Feb 25, 2021
## [0.17.13](v0.17.12...v0.17.13) (2021-02-25)

### Bug Fixes

* **IAM Policy Management:** re-gen service and add examples after recent API changes ([#74](#74)) ([9938847](9938847))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.17.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants