Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Partner Billing Units): add new service to project #241

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

manukm-ibm
Copy link
Member

@manukm-ibm manukm-ibm commented Feb 12, 2024

PR summary

Adding new partner APIs to fetch reports of billing options and credits pools services.
TRI: https://github.ibm.com/BSS/architecture/blob/master/design-docs/cosell/partner.md
Issue: https://github.ibm.com/BSS/metering-deliverables/issues/2063

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Feb 12, 2024
@padamstx padamstx self-requested a review February 12, 2024 14:57
@manukm-ibm
Copy link
Member Author

Integration test results
Screenshot 2024-01-19 at 1 08 04 PM

Example test results
Screenshot 2024-01-19 at 1 14 13 PM

@padamstx padamstx changed the title feat(Partner Billing Units): add billing options & credit pools service to Partner Billing Units feat(Partner Billing Units): add new service to project Feb 15, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 8d154ae into IBM:main Feb 15, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Feb 15, 2024
# [0.51.0](v0.50.0...v0.51.0) (2024-02-15)

### Features

* **Partner Billing Units:** add new service to project ([#241](#241)) ([8d154ae](8d154ae))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.51.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

manukm-ibm added a commit to manukm-ibm/platform-services-node-sdk that referenced this pull request Feb 16, 2024
manukm-ibm pushed a commit to manukm-ibm/platform-services-node-sdk that referenced this pull request Feb 16, 2024
# [0.51.0](IBM/platform-services-node-sdk@v0.50.0...v0.51.0) (2024-02-15)

### Features

* **Partner Billing Units:** add new service to project ([IBM#241](IBM#241)) ([8d154ae](IBM@8d154ae))

Signed-off-by: manu.k.m <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants