Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): re-gen service after fix the template sate parameter #238

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Rajesh-Pirati
Copy link
Contributor

@Rajesh-Pirati Rajesh-Pirati commented Jan 10, 2024

PR summary

issue: https://github.ibm.com/IAM/AM-issues/issues/1949)

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@Rajesh-Pirati
Copy link
Contributor Author

integration test results
image

Examples:
image

@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review January 11, 2024 19:43
Copy link
Contributor

@swcolley swcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@padamstx padamstx self-assigned this Jan 12, 2024
@padamstx padamstx self-requested a review January 12, 2024 16:00
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 66ef839 into main Jan 12, 2024
3 checks passed
@padamstx padamstx deleted the template-state-update branch January 12, 2024 16:17
ibm-devx-sdk pushed a commit that referenced this pull request Jan 12, 2024
# [0.49.0](v0.48.1...v0.49.0) (2024-01-12)

### Features

* **IAM Policy Management:** re-gen service after fix the template state parameter ([#238](#238)) ([66ef839](66ef839))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants