Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable builds on Windows #220

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix: enable builds on Windows #220

merged 1 commit into from
Aug 31, 2023

Conversation

padamstx
Copy link
Member

PR summary

This PR modifies the project to enable developers to build and test on Windows.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Aug 24, 2023
@padamstx padamstx force-pushed the fix-windows branch 4 times, most recently from c461c36 to 5afb710 Compare August 24, 2023 20:34
@padamstx padamstx marked this pull request as ready for review August 25, 2023 14:25
@padamstx padamstx changed the title fix: enable builds on Windows [skip ci] fix: enable builds on Windows Aug 25, 2023
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit a678743 into main Aug 31, 2023
@padamstx padamstx deleted the fix-windows branch August 31, 2023 20:25
ibm-devx-sdk pushed a commit that referenced this pull request Aug 31, 2023
## [0.39.1](v0.39.0...v0.39.1) (2023-08-31)

### Bug Fixes

* enable builds on Windows ([#220](#220)) ([a678743](a678743))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.39.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants