Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Identity): re-gen with latest API definition #195

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

Somchavan
Copy link
Contributor

Node SDK doc for IAM identity. PR includes changes related

Create mfa report
Get mfa report
Get mfa user status
Change token expiration max and default value to 259200

@Somchavan Somchavan requested a review from padamstx February 15, 2023 14:02
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2023

CLA assistant check
All committers have signed the CLA.

@Somchavan Somchavan force-pushed the iam-identity-user-mfa branch from 18d0e7a to f16ff35 Compare February 15, 2023 14:41
@padamstx padamstx self-assigned this Feb 15, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but we need to address the default service URL

iam-identity/v1.ts Outdated Show resolved Hide resolved
Signed-off-by: Somanath Chavan <[email protected]>
@Somchavan Somchavan force-pushed the iam-identity-user-mfa branch from f16ff35 to 5ade082 Compare February 15, 2023 23:11
@padamstx padamstx changed the title iam identity user mfa fix(IAM Identity): re-gen with latest API definition Feb 15, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit beb4067 into main Feb 15, 2023
@padamstx padamstx deleted the iam-identity-user-mfa branch February 15, 2023 23:26
ibm-devx-sdk pushed a commit that referenced this pull request Feb 15, 2023
## [0.31.2](v0.31.1...v0.31.2) (2023-02-15)

### Bug Fixes

* **IAM Identity:** re-gen with latest API definition ([#195](#195)) ([beb4067](beb4067))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants