Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename Account_Summary billing_month property #177

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Jdatechong
Copy link
Contributor

@Jdatechong Jdatechong commented Nov 28, 2022

PR summary

Rename the billing_month property in the Account_Summary schema to month

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

The Account_Summary schema should now correctly have the month property instead of the billing_month property.

Does this PR introduce a breaking change?

  • Yes
  • No

Sorry, something went wrong.

Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2022

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx self-assigned this Dec 2, 2022
@padamstx padamstx self-requested a review December 2, 2022 17:22
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis build shows lint errors. Please run npm run lint-fix in order to fix the linter errors.

Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need evidence that the integration tests and examples ran clean with your changes.

@Jdatechong
Copy link
Contributor Author

 PASS  test/integration/usage-reports.v4.test.js (13.068 s)
---------------|---------|----------|---------|---------|--------------------------------------------------------------------------------------------------------
File           | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                                                                      
---------------|---------|----------|---------|---------|--------------------------------------------------------------------------------------------------------
All files      |   57.33 |     12.9 |   55.55 |   58.96 |                                                                                                        
 lib           |     100 |      100 |     100 |     100 |                                                                                                        
  common.ts    |     100 |      100 |     100 |     100 |                                                                                                        
 usage-reports |   55.34 |     12.9 |   53.84 |   56.93 |                                                                                                        
  v4.ts        |   55.34 |     12.9 |   53.84 |   56.93 | ...1176,1184,1192-1212,1220-1225,1253-1260,1268,1276-1296,1304-1309,1334-1341,1349,1357-1377,1385-1390 
---------------|---------|----------|---------|---------|--------------------------------------------------------------------------------------------------------

Test Suites: 1 passed, 1 total
Tests:       7 passed, 7 total
Snapshots:   0 total
Time:        9.403 s, estimated 14 s

^ integration test results

@padamstx padamstx merged commit 871e644 into IBM:main Dec 5, 2022
ibm-devx-sdk pushed a commit that referenced this pull request Dec 5, 2022
## [0.29.1](v0.29.0...v0.29.1) (2022-12-05)

### Bug Fixes

* **Usage Reports:** rename Account_Summary billing_month property ([#177](#177)) ([871e644](871e644))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.29.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants