add list rule with service_group_id test #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cameron Davis <[email protected]>
|
|
soohoowoohoo
suggested changes
Oct 12, 2022
| @@ -18,7 +18,8 @@ | |||
|
|
|||
| const { readExternalSources } = require('ibm-cloud-sdk-core'); | |||
| const { v4: uuidv4 } = require('uuid'); | |||
| const ContextBasedRestrictionsV1 = require('../../dist/context-based-restrictions/v1'); | |||
| // const ContextBasedRestrictionsV1 = require('../../dist/context-based-restrictions/v1'); | |||
| const ContextBasedRestrictionsV1 = require('@ibm-cloud/platform-services/context-based-restrictions/v1'); | |||
There was a problem hiding this comment.
@cam-d12 did you make this change or the generator code? The dist folder should have the latest locally built code. If you need to help with how to build the code into the dist folder, try the readme or reach out and I can try to help.
| ruleEtag = res.headers.etag; | ||
|
|
||
| //list rule with service_group_id attribute | ||
| const listParams = { |
There was a problem hiding this comment.
I would expect that we'd want to pass the serviceGroupId parameter to make sure filtering by the property is working as expected?
Signed-off-by: Cameron Davis <[email protected]>
Signed-off-by: Cameron Davis <[email protected]>
Signed-off-by: Cameron Davis <[email protected]>
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Oct 14, 2022
## [0.26.1](v0.26.0...v0.26.1) (2022-10-14) ### Bug Fixes * **Context Based Restrictions:** add list rule with service_group_id test ([#168](#168)) ([8dbfe4b](8dbfe4b))
|
🎉 This PR is included in version 0.26.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cameron Davis [email protected]
PR summary
This PR adds CBR support for the new service_group_id parameter in rules.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
No current behavior should be modified. Adds the further control to be able to apply rules to service groups
Does this PR introduce a breaking change?
Other information