Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Access Groups): add support for dynamic membership #157

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

narinder-kaur
Copy link
Member

@narinder-kaur narinder-kaur commented Mar 30, 2022

PR summary

this Pr includes the changes for dynamic membership in access groups

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Narinder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@narinder-kaur narinder-kaur force-pushed the accessgroup-dynamic-memberships branch from b1fcdc9 to ce76104 Compare March 30, 2022 10:34
@narinder-kaur narinder-kaur changed the title feature(membership_type support): Added membership supports to acces… feature(membership_type support): Added membership supports to access groups Mar 30, 2022
@padamstx padamstx changed the title feature(membership_type support): Added membership supports to access groups feature(IAM Access Groups): add support for dynamic membership Apr 1, 2022
@padamstx padamstx self-requested a review April 1, 2022 20:10
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the SDK code look good, but we need to revert the changes that were made to package-lock.json

package-lock.json Outdated Show resolved Hide resolved
@padamstx padamstx self-assigned this Apr 1, 2022
@narinder-kaur narinder-kaur force-pushed the accessgroup-dynamic-memberships branch from ce76104 to d669825 Compare April 4, 2022 05:39
@narinder-kaur
Copy link
Member Author

@padamstx Changes are done. Please review again

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title feature(IAM Access Groups): add support for dynamic membership feat(IAM Access Groups): add support for dynamic membership Apr 4, 2022
@padamstx padamstx merged commit 80b711b into main Apr 4, 2022
@padamstx padamstx deleted the accessgroup-dynamic-memberships branch April 4, 2022 14:23
ibm-devx-sdk pushed a commit that referenced this pull request Apr 4, 2022
# [0.23.0](v0.22.10...v0.23.0) (2022-04-04)

### Features

* **IAM Access Groups:** add support for dynamic membership ([#157](#157)) ([80b711b](80b711b))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants