Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Catalog Management): update service to add patch operation #150

Merged
merged 6 commits into from
Dec 17, 2021
Merged

fix(Catalog Management): update service to add patch operation #150

merged 6 commits into from
Dec 17, 2021

Conversation

JensenAlexander
Copy link
Contributor

PR summary

Re-generated the Catalog Management SDK code to contain the new PATCH operation for offerings.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@padamstx padamstx self-requested a review December 13, 2021 19:50
padamstx
padamstx requested changes Dec 13, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the SDK service and unit test code look good.

I'm not sure why package.json (and package-lock.json) need to be modified however.
I'll reach out via slack to discuss this more

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
padamstx
padamstx requested changes Dec 17, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except the lint errors need to be addressed.

@padamstx padamstx self-assigned this Dec 17, 2021
padamstx
padamstx approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the latest changes and everything looks good!

@padamstx padamstx merged commit 01ff1f6 into IBM:main Dec 17, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Dec 17, 2021
@semantic-release-bot
chore(release): 0.22.5 [skip ci]
25bd259 
## [0.22.5](v0.22.4...v0.22.5) (2021-12-17)

### Bug Fixes

* **Catalog Management:** update service to add patch operation ([#150](#150)) ([01ff1f6](01ff1f6))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.22.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JensenAlexander @CLAassistant @ibm-devx-sdk @padamstx