Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): support of new query params for v2/roles #141

Merged
merged 5 commits into from
Oct 20, 2021

Conversation

Rajesh-Pirati
Copy link
Contributor

@Rajesh-Pirati Rajesh-Pirati commented Oct 13, 2021

PR summary

Support of new query parameters for v2/roles

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

API docs for the details: https://cloud.ibm.com/apidocs/iam-policy-management#list-roles

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2021

CLA assistant check
All committers have signed the CLA.

@Rajesh-Pirati Rajesh-Pirati changed the title feat(IAM Policy Management): support of new query parameters for v2/r… feat(IAM Policy Management): support of new query params for v2/roles Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #141 (89c70da) into main (409f06e) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 89c70da differs from pull request most recent head 33a04f3. Consider uploading reports for the commit 33a04f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         3616      3643   +27     
  Branches       437       446    +9     
=========================================
+ Hits          3616      3643   +27     
Impacted Files Coverage Δ
iam-policy-management/v1.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409f06e...33a04f3. Read the comment docs.

@Rajesh-Pirati Rajesh-Pirati marked this pull request as ready for review October 20, 2021 10:11
@Andras-Csanyi Andras-Csanyi self-requested a review October 20, 2021 11:20
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Andras-Csanyi Andras-Csanyi merged commit e19e101 into IBM:main Oct 20, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Oct 20, 2021
# [0.22.0](v0.21.1...v0.22.0) (2021-10-20)

### Features

* **IAM Policy Management:** support of new query params for v2/roles ([#141](#141)) ([e19e101](e19e101))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Andras-Csanyi Andras-Csanyi self-assigned this Oct 20, 2021
@Rajesh-Pirati Rajesh-Pirati deleted the iam-am-v2Roles branch October 21, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants