-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jest): vulnerability fix #139
Conversation
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 3616 3616
Branches 437 437
=========================================
Hits 3616 3616 Continue to review full report at Codecov.
|
# Conflicts: # package-lock.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I didn't look at every file but I feel I reviewed a representative sample since you made the same changes to all files. The changes look great! 👍
## [0.21.1](v0.21.0...v0.21.1) (2021-10-12) ### Bug Fixes * **jest:** vulnerability fix ([#139](#139)) ([ff04e5e](ff04e5e))
🎉 This PR is included in version 0.21.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR summary
This PR brings a major update for jest (v27), and covers the consequences of it.
done
has been removed from unit testsdone
is removed from integration tests, but the methods are not refactored toasync
done
is removed from examples too, and all the examples are refactored toasync
due to using some custom logic aroundconsole.log
andconsole.warn
.env
file provided (in this case the test skips execution).env
file providedPossible follow up tasks:
We also have to figure out whether
async
pattern orpromise
pattern is the preferred one in the reference.PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information