Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Access Groups): update service after recent api changes #116

Merged
merged 1 commit into from
Jun 25, 2021
Merged

fix(IAM Access Groups): update service after recent api changes #116

merged 1 commit into from
Jun 25, 2021

Conversation

mamillapalle
Copy link
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mamillapalle mamillapalle requested a review from padamstx June 25, 2021 15:23
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

iamauto seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jun 25, 2021 •
edited
Loading

Codecov Report

Merging #116 (3fc5743) into main (2d6e35c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #116   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3284      3284           
  Branches       392       392           
=========================================
  Hits          3284      3284
Impacted Files Coverage Δ
iam-access-groups/v2.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d6e35c...3fc5743. Read the comment docs.

padamstx
padamstx approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 513d1b7 into main Jun 25, 2021
@padamstx padamstx deleted the access_groups branch June 25, 2021 19:55
ibm-devx-sdk pushed a commit that referenced this pull request Jun 25, 2021
@semantic-release-bot
chore(release): 0.18.12 [skip ci]
3f7b609 
## [0.18.12](v0.18.11...v0.18.12) (2021-06-25)

### Bug Fixes

* **IAM Access Groups:** update service after recent api changes ([#116](#116)) ([513d1b7](513d1b7))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.18.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mamillapalle @CLAassistant @ibm-devx-sdk @padamstx