-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IAM Policy Management): add nested conditions to rule.conditions #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaun Colley <[email protected]>
Signed-off-by: Shaun Colley <[email protected]>
Signed-off-by: Shaun Colley <[email protected]>
…orm-services-java-sdk into policyNestedConditions
Signed-off-by: Shaun Colley <[email protected]>
Latest tests: Running com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.72 s -- in com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- failsafe:3.1.2:verify (default) @ iam-policy-management ---
[INFO]
[INFO] --- install:3.1.1:install (default-install) @ iam-policy-management ---
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/pom.xml to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.pom
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.jar
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-javadoc.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-javadoc.jar
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-sources.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 49.356 s
[INFO] Finished at: 2023-11-07T12:20:41-05:00
[INFO] ------------------------------------------------------------------------ Examples: [INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 24.837 s
[INFO] Finished at: 2023-11-07T12:21:29-05:00
[INFO] ------------------------------------------------------------------------ |
padamstx
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
padamstx
changed the title
Policy nested conditions
fix(IAM Policy Management): update rule conditions based on API def
Nov 7, 2023
padamstx
changed the title
fix(IAM Policy Management): update rule conditions based on API def
fix(IAM Policy Management): add nested conditions to rule.conditions
Nov 7, 2023
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 7, 2023
## [0.45.1](0.45.0...0.45.1) (2023-11-07) ### Bug Fixes * **IAM Policy Management:** add nested conditions to rule.conditions ([#221](#221)) ([9753e83](9753e83))
🎉 This PR is included in version 0.45.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Updated based on minor api definition update.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
in modules/iam-policy-management
integration test:
examples: