Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): add nested conditions to rule.conditions #221

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Nov 7, 2023

PR summary

Updated based on minor api definition update.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

in modules/iam-policy-management
integration test:

mvn clean install
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  27.012 s
[INFO] Finished at: 2023-11-07T07:21:05-05:00
[INFO] ------------------------------------------------------------------------


examples:


[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  21.718 s
[INFO] Finished at: 2023-11-07T07:23:50-05:00

```


@padamstx padamstx self-requested a review November 7, 2023 14:18
@padamstx padamstx self-assigned this Nov 7, 2023
@swcolley
Copy link
Contributor Author

swcolley commented Nov 7, 2023

Latest tests:

Running com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.72 s -- in com.ibm.cloud.platform_services.iam_policy_management.v1.IamPolicyManagementIT
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 25, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] 
[INFO] --- failsafe:3.1.2:verify (default) @ iam-policy-management ---
[INFO] 
[INFO] --- install:3.1.1:install (default-install) @ iam-policy-management ---
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/pom.xml to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.pom
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT.jar
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-javadoc.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-javadoc.jar
[INFO] Installing /Users/shaunsmacibm/Desktop/cloud-platform/iam/sdk/platform-services-java-sdk/modules/iam-policy-management/target/iam-policy-management-99-SNAPSHOT-sources.jar to /Users/shaunsmacibm/.m2/repository/com/ibm/cloud/iam-policy-management/99-SNAPSHOT/iam-policy-management-99-SNAPSHOT-sources.jar
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  49.356 s
[INFO] Finished at: 2023-11-07T12:20:41-05:00
[INFO] ------------------------------------------------------------------------

Examples:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  24.837 s
[INFO] Finished at: 2023-11-07T12:21:29-05:00
[INFO] ------------------------------------------------------------------------

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title Policy nested conditions fix(IAM Policy Management): update rule conditions based on API def Nov 7, 2023
@padamstx padamstx changed the title fix(IAM Policy Management): update rule conditions based on API def fix(IAM Policy Management): add nested conditions to rule.conditions Nov 7, 2023
@padamstx padamstx merged commit 9753e83 into main Nov 7, 2023
3 checks passed
@padamstx padamstx deleted the policyNestedConditions branch November 7, 2023 18:45
ibm-devx-sdk pushed a commit that referenced this pull request Nov 7, 2023
## [0.45.1](0.45.0...0.45.1) (2023-11-07)

### Bug Fixes

* **IAM Policy Management:** add nested conditions to rule.conditions ([#221](#221)) ([9753e83](9753e83))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.45.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants